Skip to content

Comments

fix(plugin/vite-resolve): try non-prefixed id before prefixed id#5711

Merged
sapphi-red merged 1 commit intomainfrom
08-12-fix_plugin_vite-resolve_try_non-prefixed_id_before_prefixed_id
Aug 12, 2025
Merged

fix(plugin/vite-resolve): try non-prefixed id before prefixed id#5711
sapphi-red merged 1 commit intomainfrom
08-12-fix_plugin_vite-resolve_try_non-prefixed_id_before_prefixed_id

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 12, 2025

Copy link
Member Author

sapphi-red commented Aug 12, 2025

@sapphi-red sapphi-red marked this pull request as ready for review August 12, 2025 13:10
@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2025

Benchmarks Rust

  • target: main(a0df256)
  • pr: 08-12-fix_plugin_vite-resolve_try_non-prefixed_id_before_prefixed_id(543cf11)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     77.4±2.14ms        ? ?/sec    1.14     88.1±7.11ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     86.0±1.58ms        ? ?/sec    1.11     95.9±5.33ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    115.4±4.28ms        ? ?/sec    1.03    118.9±4.15ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    136.3±2.30ms        ? ?/sec    1.03    140.8±3.66ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.5±2.40ms        ? ?/sec    1.04     44.0±1.83ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     50.6±1.04ms        ? ?/sec    1.06     53.5±1.87ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00   444.2±11.19ms        ? ?/sec    1.04   462.1±13.84ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    528.0±8.37ms        ? ?/sec    1.03   542.5±12.83ms        ? ?/sec
scan/scan@rome_ts                                            1.00     92.6±3.41ms        ? ?/sec    1.04     96.2±3.77ms        ? ?/sec
scan/scan@threejs                                            1.00     32.3±1.16ms        ? ?/sec    1.00     32.3±1.25ms        ? ?/sec
scan/scan@threejs10x                                         1.00    336.9±8.08ms        ? ?/sec    1.00   338.2±10.23ms        ? ?/sec

Base automatically changed from 08-12-fix_plugin_vite-resolve_fallback_on_more_resolution_errors_that_happened_when_trying_with_prefix to main August 12, 2025 14:49
@sapphi-red sapphi-red force-pushed the 08-12-fix_plugin_vite-resolve_try_non-prefixed_id_before_prefixed_id branch from febcb40 to 543cf11 Compare August 12, 2025 15:54
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 12, 2025

Merge activity

  • Aug 12, 3:54 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@netlify
Copy link

netlify bot commented Aug 12, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 543cf11
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/689b63a7076dc4000841c0ef

@sapphi-red sapphi-red added this pull request to the merge queue Aug 12, 2025
Merged via the queue into main with commit c09bd00 Aug 12, 2025
22 checks passed
@sapphi-red sapphi-red deleted the 08-12-fix_plugin_vite-resolve_try_non-prefixed_id_before_prefixed_id branch August 12, 2025 16:08
This was referenced Aug 18, 2025
hyf0 pushed a commit that referenced this pull request Aug 18, 2025
## [1.0.0-beta.33] - 2025-08-18

### 💥 BREAKING CHANGES

- only call `closeBundle` hook when bundling actually happens (#5715) by
@shulaoda

### 🚀 Features

- rolldown_plugin_vite_css_post: align transform logic except minify
(#5768) by @shulaoda
- rolldown_plugin_vite_css_post: align html inline css logic (#5767) by
@shulaoda
- support merge cjs ns in module group level (#5760) by @IWANABETHATGUY
- rolldown_plugin_vite_css_post: filter transform id (#5766) by
@shulaoda
- rolldown: oxc v0.82.2 (#5754) by @Boshen
- rollup-test: log error when `pringStatus` (#5744) by @situ2001
- rolldown_plugin_vite_css_post: initialize (#5743) by @shulaoda
- rolldown_plugin_vite_css: align `transform` hook logic (#5736) by
@shulaoda
- rolldown_plugin_vite_css: align partial transform hook logic (#5733)
by @shulaoda
- add original wrap_kind (#5729) by @IWANABETHATGUY
- concatenateWrappedModule (#5724) by @IWANABETHATGUY
- rolldown: oxc v0.82.1 (#5717) by @Boshen
- improve error message for `unresolved_import` when platform is
`neutral` (#5700) by @IWANABETHATGUY

### 🐛 Bug Fixes

- rolldown_plugin_transform: merge tsconfig jsx options even when
`oxc.jsx.runtime` is set (#5771) by @hi-ogawa
- jsx preserve break component which is default export (#5764) by
@shulaoda
- rolldown_plugin_asset: should directly stringify raw content (#5749)
by @situ2001
- resolve symbol deconfliction order for cross-chunk imports by
@IWANABETHATGUY
- rolldown_error: improve resolve diagnostic message (#5740) by
@shulaoda
- vitest ci failed (#5741) by @IWANABETHATGUY
- rolldown: options `context` should be available in renderStart (#5672)
by @situ2001
- ensure lazy module eval order when import variable from other chunk
(#5727) by @IWANABETHATGUY
- wasm build panic on stackblitz (#5723) by @shulaoda
- plugin/vite-resolve: try non-prefixed id before prefixed id (#5711) by
@sapphi-red
- devtool: shouldn't filter out spans for devtool use case (#5713) by
@hyf0
- plugin/vite-resolve: fallback on more resolution errors that happened
when trying with prefix (#5710) by @sapphi-red
- plugin/vite-resolve: don't consider ids with `npm:` prefix as a
built-in module (#5709) by @sapphi-red

### 🚜 Refactor

- rolldown_plugin_json: use common plugin utils (#5769) by @shulaoda
- hmr: remove unnecessary code of handling runtime module (#5752) by
@hyf0
- hmr: enhance HMR update logic and improve clarity (#5748) by @hyf0
- improve `ScopeHoistingFinalizerContext` (#5739) by @shulaoda
- move `finalize_normal_module` into `ScopeHoistingFinalizerContext`
(#5738) by @shulaoda
- private fields `wrap_kind` and `original_wrap_kind` and keep them sync
(#5730) by @IWANABETHATGUY

### 📚 Documentation

- rolldown_plugin_data_uri: update README (#5746) by @situ2001
- install guide for minor platforms (#5716) by @sapphi-red
- update description for platform `neutral` (#5701) by @IWANABETHATGUY

### ⚡ Performance

- hmr: only refetch changed modules (#5753) by @hyf0
- rolldown_plugin_reporter: gzip size computation (#5734) by
@IWANABETHATGUY
- hmr: reuse previous ast for non-changed modules (#5725) by @hyf0
- rolldown_ecmascript: do not run semantic twice for `dce-only` (#5707)
by @Boshen

### 🧪 Testing

- rolldown: should await for `toMatchFileSnapshot` (#5759) by @situ2001
- hmr: improve test of `import.meta.hot.invalidate` (#5747) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance (#5765) by @renovate[bot]
- deps: lock file maintenance rust crates (#5763) by @renovate[bot]
- deps: lock file maintenance npm packages (#5762) by @renovate[bot]
- deps: update github-actions (#5755) by @renovate[bot]
- deps: update dependency tinybench to v5 (#5756) by @renovate[bot]
- deps: update github-actions (major) (#5757) by @renovate[bot]
- deps: update crate-ci/typos action to v1.35.4 (#5714) by
@renovate[bot]
- prepare-release: regenerate `binding.js` after version bump (#5704) by
@shulaoda
- deps: update dependency tsdown to v0.14.1 (#5705) by @renovate[bot]
- rollup-tests: skip occasionally failing test case (#5703) by @shulaoda
- update binding.js (#5702) by @shulaoda

Co-authored-by: sapphi-red <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants