Skip to content

Comments

test(hmr): properly execute patch chunks#5617

Merged
sapphi-red merged 1 commit intomainfrom
08-05-test_hmr_execute_patch_chunks
Aug 6, 2025
Merged

test(hmr): properly execute patch chunks#5617
sapphi-red merged 1 commit intomainfrom
08-05-test_hmr_execute_patch_chunks

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 5, 2025

Execute the patch chunks to run the assertions.

Copy link
Member Author

sapphi-red commented Aug 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Aug 5, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit a409c22
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6892cae345b7fa000843f7ea

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

Benchmarks Rust

  • target: main(920f9b7)
  • pr: 08-05-test_hmr_execute_patch_chunks(a409c22)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     87.6±2.82ms        ? ?/sec    1.03     90.0±2.08ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     99.5±2.32ms        ? ?/sec    1.02    101.2±1.67ms        ? ?/sec
bundle/bundle@rome_ts                                        1.04    128.0±3.70ms        ? ?/sec    1.00    123.4±3.57ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    146.2±2.73ms        ? ?/sec    1.00    146.6±3.03ms        ? ?/sec
bundle/bundle@threejs                                        1.00     45.8±2.17ms        ? ?/sec    1.00     45.7±0.99ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     55.5±0.95ms        ? ?/sec    1.00     54.4±0.80ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00   456.6±10.56ms        ? ?/sec    1.04    475.8±7.90ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    547.7±5.81ms        ? ?/sec    1.02    558.0±4.51ms        ? ?/sec
scan/scan@rome_ts                                            1.00     96.5±3.46ms        ? ?/sec    1.06    101.9±5.00ms        ? ?/sec
scan/scan@threejs                                            1.00     33.5±0.53ms        ? ?/sec    1.00     33.5±0.40ms        ? ?/sec
scan/scan@threejs10x                                         1.01    341.0±4.81ms        ? ?/sec    1.00    337.5±6.56ms        ? ?/sec

@shulaoda shulaoda added this pull request to the merge queue Aug 5, 2025
@hyf0 hyf0 removed this pull request from the merge queue due to a manual request Aug 5, 2025
@hyf0 hyf0 self-assigned this Aug 5, 2025
@hyf0
Copy link
Member

hyf0 commented Aug 5, 2025

Need some changes. Let's wait for @sapphi-red.

@sapphi-red sapphi-red marked this pull request as draft August 6, 2025 01:56
@sapphi-red sapphi-red force-pushed the 08-05-test_hmr_execute_patch_chunks branch from dd21330 to 0de0ee1 Compare August 6, 2025 03:15
@sapphi-red sapphi-red marked this pull request as ready for review August 6, 2025 03:17
@sapphi-red sapphi-red changed the title test(hmr): execute patch chunks test(hmr): properly execute patch chunks Aug 6, 2025
@sapphi-red sapphi-red requested review from hyf0 and shulaoda August 6, 2025 03:19
@sapphi-red
Copy link
Member Author

Ah, I broke windows.

@sapphi-red sapphi-red force-pushed the 08-05-test_hmr_execute_patch_chunks branch from 0de0ee1 to a409c22 Compare August 6, 2025 03:24
@sapphi-red sapphi-red enabled auto-merge August 6, 2025 05:32
@sapphi-red sapphi-red added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 97f2134 Aug 6, 2025
23 checks passed
@sapphi-red sapphi-red deleted the 08-05-test_hmr_execute_patch_chunks branch August 6, 2025 05:46
shulaoda added a commit that referenced this pull request Aug 11, 2025
## [1.0.0-beta.32] - 2025-08-11

### 💥 BREAKING CHANGES

- advanceChunks: remove interaction between `advanceChunks` and `preserveEntrySignatures` (#5629) by @hyf0
- types: align `TreeshakingOptions` type with Rollup (#5592) by @sapphi-red

### 🚀 Features

- rolldown_plugin_manifest: support legacy (#5694) by @shulaoda
- rolldown_plugin_vite_css: align load hook logic (#5667) by @shulaoda
- rolldown_plugin_transform: throw error for invalid tsconfig (#5657) by @shulaoda
- support `context` option (#5631) by @7086cmd
- rolldown: oxc v0.81.0 (#5642) by @Boshen
- include plugin name in the message of UNHANDLEABLE_ERRORs that happened in plugins (#5636) by @sapphi-red
- pass plugin name to log (#5635) by @sapphi-red
- rolldown_plugin_import_glob: support glob-safe paths (#5640) by @shulaoda
- rolldown_binding: Add configurable max_blocking_threads with environment variable override (#5559) by @Copilot
- output better error message for callable plugins (#5632) by @sapphi-red
- rolldown_plugin_manifest: support names for asset (#5627) by @shulaoda
- rolldown_plugin_manifest: align the logic related to css entries (#5626) by @shulaoda
- hmr: handle `import ... from 'external-module'` in rolldown's best (#5599) by @hyf0
- add array support for `treeshake.moduleSideEffects` option (#5593) by @sapphi-red

### 🐛 Bug Fixes

- ensure `./` prefix for relative imports starting with `.` (#5687) by @shulaoda
- hmr: fix regression test `deconflict_import_bindings` (#5684) by @hyf0
- hmr: only modules in the propagation chain need to re-execute (#5683) by @hyf0
- preserve empty `export {}` to ensure correct ESM detection (#5686) by @shulaoda
- vite test failed (#5675) by @IWANABETHATGUY
- incorrect module execution order with sideeffectful CJS module (#5661) by @IWANABETHATGUY
- rollup-tests: update ignored tests for `option.context` (#5669) by @situ2001
- hmr: ensure correctness of `typeof require === 'function'` (#5651) by @hyf0
- hmr: rewrite `this` to `exports` for cjs modules (#5641) by @hyf0
- don't generate namespace reexport code for reexport external record that has been moved to entry point (#5622) by @IWANABETHATGUY
- esm export * from 'externalized-dep' generates unnecessary code (#5612) by @IWANABETHATGUY
- hmr: correct runtime behavior for manual reexports (#5614) by @hyf0
- ci: resolve potential sync issue in `this.emitFile` (#5611) by @shulaoda
- hmr: support re-assignment on `module.exports` (#5607) by @hyf0
- hmr: rewrite `require(...)` to sensible form (#5604) by @hyf0
- align behavior when returning `undefined` from `treeshake.moduleSideEffects` function (#5595) by @sapphi-red

### 🚜 Refactor

- rolldown_binding: improve the use of `FxHashSet` and `FxHashMap` (#5665) by @shulaoda
- hmr: move constants to `constants.rs` (#5650) by @hyf0
- hmr: rewrite `exports,module` to `__rolldown_exports__,__rolldown_module__` (#5647) by @hyf0
- hmr: migrate `VisitMut` to `Traverse` (#5646) by @hyf0
- use `bit_index` function to get `RuntimeHelper` bit index (#5634) by @IWANABETHATGUY
- improve `JsCallback` and `MaybeAsyncJsCallback` (#5628) by @shulaoda
- use bitflags instead of boolean to represent module_namespace included reason (#5621) by @IWANABETHATGUY
- rolldown_debug,rolldown_tracing: remove `EnvFilter` (#5231) by @Boshen
- align parameter name for `treeshake.moduleSideEffects` (#5594) by @sapphi-red

### 📚 Documentation

- contrib-guide: add CPU profile steps (#5677) by @sapphi-red
- rollup-tests: update README to correct  commands (#5658) by @situ2001

### ⚡ Performance

- reduce memory usage when calc none wrapped modules implicit dependency (#5679) by @IWANABETHATGUY
- hmr: do codegen in parallel (#5590) by @hyf0

### 🧪 Testing

- Runtime error when using rolldown to build a page using tinymce (#5678) by @IWANABETHATGUY
- rollup: enable testing for `option.context` (#5663) by @situ2001
- hmr: run patch exectution after the normal execution (#5645) by @sapphi-red
- hmr: properly execute patch chunks (#5617) by @sapphi-red
- rust/hmr: hide unnecessary rolldown runtime, hmr module (#5606) by @hyf0
- rust/hmr: support writting assertion tests (#5598) by @hyf0
- rust: simplify global variable injection logic (#5597) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance (#5693) by @renovate[bot]
- deps: lock file maintenance (#5692) by @renovate[bot]
- deps: lock file maintenance rust crates (#5691) by @renovate[bot]
- deps: update github-actions (#5688) by @renovate[bot]
- deps: lock file maintenance npm packages (#5690) by @renovate[bot]
- deps: update github-actions (major) (#5689) by @renovate[bot]
- upgrade NAPI-RS to 3.2 (#5680) by @Brooooooklyn
- deps: update dependency tsdown to v0.14.0 (#5681) by @renovate[bot]
- clean up basic-vue example (#5676) by @IWANABETHATGUY
- deps: update crate-ci/typos action to v1.35.3 (#5674) by @renovate[bot]
- remove duplicate hook tracing (#5673) by @IWANABETHATGUY
- deps: update dependency tsdown to v0.13.4 (#5668) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.15.6 (#5666) by @renovate[bot]
- deps: update crate-ci/typos action to v1.35.2 (#5664) by @renovate[bot]
- deps: update dependency rust to v1.89.0 (#5652) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.15.5 (#5649) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.15.4 (#5638) by @renovate[bot]
- add `just debug-test` alias to run test without extended test case (#5633) by @IWANABETHATGUY
- update lable related to auto labeled documentation ci (#5630) by @IWANABETHATGUY
- clippy: allow `case_sensitive_file_extension_comparisons` (#5625) by @shulaoda
- fix wasi build failed (#5624) by @sapphi-red
- use env variable to control whether run extended tests (#5623) by @IWANABETHATGUY
- remove redundant track_caller (#5620) by @IWANABETHATGUY
- replace unmaintained goto-bus-stop/setup-zig with mlugg/setup-zig action (#5605) by @Copilot
- deps: update crate-ci/typos action to v1.35.1 (#5603) by @renovate[bot]
- deps: update crate-ci/typos action to v1.35.0 (#5601) by @renovate[bot]
- deps: update dependency tsdown to v0.13.3 (#5602) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.15.3 (#5600) by @renovate[bot]

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants