Skip to content

Comments

Revert "feat(plugin/generateBundle): add support for modifying chunk filename (#5564)"#5583

Closed
sapphi-red wants to merge 1 commit intomainfrom
revert-5564
Closed

Revert "feat(plugin/generateBundle): add support for modifying chunk filename (#5564)"#5583
sapphi-red wants to merge 1 commit intomainfrom
revert-5564

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 4, 2025

This reverts commit 2a5dd53.

@shulaoda shulaoda mentioned this pull request Aug 4, 2025
Merged
@sapphi-red
Copy link
Member Author

sapphi-red commented Aug 4, 2025

Vite tests: https://github.com/rolldown/rolldown/actions/runs/16712192187

@shulaoda
Copy link
Member

shulaoda commented Aug 4, 2025

Fixed it in #5580

@netlify
Copy link

netlify bot commented Aug 4, 2025

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit e239ecd
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6890138e920c38000881eee7
😎 Deploy Preview https://deploy-preview-5583--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     80.0±2.44ms        ? ?/sec    1.00     79.4±1.67ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     89.8±1.86ms        ? ?/sec    1.00     89.5±1.72ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    118.2±4.16ms        ? ?/sec    1.01    118.9±2.24ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    139.2±2.06ms        ? ?/sec    1.01    140.3±2.62ms        ? ?/sec
bundle/bundle@threejs                                        1.00     43.7±2.64ms        ? ?/sec    1.01     44.0±1.46ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     52.4±0.79ms        ? ?/sec    1.03     54.1±1.41ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    450.4±7.05ms        ? ?/sec    1.01    457.1±8.06ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    533.8±5.59ms        ? ?/sec    1.01    540.5±8.74ms        ? ?/sec
scan/scan@rome_ts                                            1.00     93.0±1.62ms        ? ?/sec    1.02     95.2±2.73ms        ? ?/sec
scan/scan@threejs                                            1.00     31.9±1.95ms        ? ?/sec    1.01     32.3±0.93ms        ? ?/sec
scan/scan@threejs10x                                         1.01    339.0±4.37ms        ? ?/sec    1.00    336.7±5.75ms        ? ?/sec

@sapphi-red sapphi-red closed this Aug 4, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 4, 2025
@shulaoda
fix: modify output filename correctly in generateBundle and `writeB…
6808709 
…undle` (#5580)

closes #5583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @shulaoda