Skip to content

Comments

fix: modify output filename correctly in generateBundle and writeBundle#5580

Merged
shulaoda merged 1 commit intomainfrom
08-04-feat_add_support_for_modifying_output_filename_in_generatebundle_and_writebundle
Aug 4, 2025
Merged

fix: modify output filename correctly in generateBundle and writeBundle#5580
shulaoda merged 1 commit intomainfrom
08-04-feat_add_support_for_modifying_output_filename_in_generatebundle_and_writebundle

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Aug 3, 2025

closes #5583

Copy link
Member Author

shulaoda commented Aug 3, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda changed the title feat: add support for modifying output filename in generateBundle and writeBundle feat: add support for modifying output filename in generateBundle and writeBundle Aug 3, 2025
@shulaoda shulaoda marked this pull request as ready for review August 3, 2025 22:47
@netlify
Copy link

netlify bot commented Aug 3, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 4f8ee60
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/688fe7bdb70c7f0008f704af
😎 Deploy Preview https://deploy-preview-5580--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shulaoda shulaoda force-pushed the 08-04-feat_add_support_for_modifying_output_filename_in_generatebundle_and_writebundle branch from bcab83d to 4f8ee60 Compare August 3, 2025 22:50
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2025

Benchmarks Rust

  • target: main(6c148ba)
  • pr: 08-04-feat_add_support_for_modifying_output_filename_in_generatebundle_and_writebundle(4f8ee60)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     76.3±2.56ms        ? ?/sec    1.01     77.2±1.93ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     86.4±2.57ms        ? ?/sec    1.00     86.2±2.39ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    115.0±2.86ms        ? ?/sec    1.00    113.7±1.58ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    133.5±1.97ms        ? ?/sec    1.01    134.5±3.35ms        ? ?/sec
bundle/bundle@threejs                                        1.04     42.2±2.55ms        ? ?/sec    1.00     40.6±1.21ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     51.6±1.68ms        ? ?/sec    1.00     50.9±0.87ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    434.9±6.21ms        ? ?/sec    1.00    430.9±3.97ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    509.3±3.48ms        ? ?/sec    1.00    509.3±3.82ms        ? ?/sec
scan/scan@rome_ts                                            1.00     87.5±1.16ms        ? ?/sec    1.00     87.9±1.36ms        ? ?/sec
scan/scan@threejs                                            1.00     30.1±0.35ms        ? ?/sec    1.00     30.2±0.85ms        ? ?/sec
scan/scan@threejs10x                                         1.00    318.6±3.48ms        ? ?/sec    1.00    319.1±4.23ms        ? ?/sec

@sapphi-red
Copy link
Member

@shulaoda shulaoda changed the title feat: add support for modifying output filename in generateBundle and writeBundle fix: modify output filename correctly in generateBundle and writeBundle Aug 4, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 4, 2025

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@5580

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@5580

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@5580

rolldown

npm i https://pkg.pr.new/rolldown@5580

@rolldown/binding-android-arm64

npm i https://pkg.pr.new/@rolldown/binding-android-arm64@5580

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@5580

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@5580

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@5580

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@5580

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@5580

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@5580

@rolldown/binding-linux-arm64-ohos

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-ohos@5580

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@5580

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@5580

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@5580

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@5580

@rolldown/binding-win32-ia32-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-ia32-msvc@5580

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@5580

commit: 4f8ee60

@shulaoda shulaoda added this pull request to the merge queue Aug 4, 2025
Merged via the queue into main with commit 6808709 Aug 4, 2025
51 checks passed
@shulaoda shulaoda deleted the 08-04-feat_add_support_for_modifying_output_filename_in_generatebundle_and_writebundle branch August 4, 2025 03:30
This was referenced Aug 4, 2025
shulaoda added a commit that referenced this pull request Aug 4, 2025
## [1.0.0-beta.31] - 2025-08-04

### 🚀 Features

- support function for asset_inline_limit (#5453) by @AliceLanniste
- hmr: generate initializer for `export * from ...` (#5577) by @hyf0
- hmr: remove meaningless stmt instead of replacing with empty stmt (#5570) by @hyf0
- option `watch.clearScreen` (#5518) by @situ2001
- rolldown: oxc v0.80.0 (#5538) by @Boshen
- plugin/generateBundle: add support for modifying chunk filename (#5564) by @shulaoda
- assetFileNames: support `name` and `originalFileName` (#5555) by @shulaoda
- add optional `onInvalidate` schema to validator (#5528) by @situ2001
- don't throw resolve errors for dynamic import inside try block (#5537) by @shulaoda
- rolldown: oxc v0.79.0 (#5512) by @Boshen
- rolldown_plugin_asset: align `render_chunk` logic (#5511) by @shulaoda
- rolldown_plugin_utls: finish `render_asset_url_in_js` (#5508) by @shulaoda
- rolldown_plugin_utils: align replacement logic for `__VITE_ASSET__` (#5507) by @shulaoda
- rolldown_plugin_utils: add partial `render_asset_url_in_js` support (#5504) by @shulaoda
- expose `sourcemapBaseUrl` from NormalizedOutputOptions (#5513) by @sapphi-red

### 🐛 Bug Fixes

- modify output filename correctly in `generateBundle` and `writeBundle` (#5580) by @shulaoda
- hmr: ensure correct runtime behavior for `export * from ...` (#5578) by @hyf0
- hmr: repeated imports should point to the same binding (#5571) by @hyf0
- hmr: handle `export * from ...` (#5566) by @hyf0
- rolldown_plugin_web_worker_post: handle `import.meta` correctly (#5565) by @shulaoda
- antd bundle output not correct (#5549) by @IWANABETHATGUY
- hmr: module namespace object should be included via treeshaking mechanism normally (#5543) by @hyf0
- plugin/vite-resolve: use `import` / `require` conditions for external modules resolution (#5540) by @sapphi-red
- rolldown_plugin_asset: InvalidAsset#is should match InvalidAsset::True (#5529) by @AliceLanniste
- __name lacks require('./chunk-containing-runtime') when format: 'cjs' + keepNames: true (#5526) by @IWANABETHATGUY
- plugin/vite-resolve: resolve externalized packages with `resolve.externalConditions` (#5491) by @sapphi-red
- optimization.inlineConst: true does not keep export names when output.minifyInternalExports: true is enabled (#5520) by @IWANABETHATGUY
- scanner: identify `module.exports.__esModule = true` (#5503) by @overlookmotel
- error instead of panic if `sourcemapBaseUrl` is an invalid URL (#5514) by @sapphi-red

### 🚜 Refactor

- hmr: use `__rolldown_exports__` as the name for esm module namespace object (#5579) by @hyf0
- tests: rename `_configName` to `_testName` in configuration files and update variant formatting in snapshots (#5569) by @hyf0
- rolldown: remove unnecessary comments (#5552) by @situ2001
- rolldown: Remove `rolldown_rstr` crate and use `CompactStr` directly (#5542) by @Copilot
- hide namespace statement index knowledge inside StmtInfos (#5545) by @sapphi-red
- use pascal case when naming bitflags field for `ImportRecordMeta` (#5539) by @IWANABETHATGUY
- use concat_string! to simplify string concatenation (#5527) by @IWANABETHATGUY
- use combinator function handle `sourcemap_base_url` parsing (#5517) by @IWANABETHATGUY
- rolldown_plugin_utils: improve `to_output_file_path_in_js` (#5505) by @shulaoda

### 📚 Documentation

- wording nit (#5521) by @nullxone

### 🧪 Testing

- rust: rename `configName` to `_configName` and add comments (#5568) by @hyf0
- rust: re-organize `rolldown_testing_config` (#5567) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance npm packages (#5582) by @renovate[bot]
- deps: lock file maintenance (#5581) by @renovate[bot]
- deps: lock file maintenance rust crates (#5576) by @renovate[bot]
- deps: lock file maintenance npm packages (#5574) by @renovate[bot]
- deps: update github-actions (#5573) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.15.1 (#5572) by @renovate[bot]
- deps: update dependency tsdown to v0.13.2 (#5562) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to ^0.15.0 (#5563) by @renovate[bot]
- ai: Add AGENTS.md and GitHub Copilot setup workflow (#5556) by @Copilot
- deps: update dependency tsdown to v0.13.1 (#5551) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.14.3 (#5544) by @renovate[bot]
- ensure all diagnostics in self.errors have Severity::Error (#5494) by @sapphi-red
- vscode: remove `code-spell-checker` extension (#5530) by @shulaoda
- deps: update dependency rolldown-plugin-dts to v0.14.2 (#5522) by @renovate[bot]
- add link to the REPL in the reproduction field description (#5519) by @sapphi-red
- enable some rollup tests (#5515) by @sapphi-red

### ❤️ New Contributors

* @Copilot made their first contribution in [#5556](#5556)
* @nullxone made their first contribution in [#5521](#5521)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants