Skip to content

Comments

refactor(hmr): use __rolldown_exports__ as the name for esm module namespace object#5579

Merged
hyf0 merged 1 commit intomainfrom
08-04-refactor_hmr_use___rolldown_exports___as_the_name_for_esm_moduoe_namespace_object
Aug 4, 2025
Merged

refactor(hmr): use __rolldown_exports__ as the name for esm module namespace object#5579
hyf0 merged 1 commit intomainfrom
08-04-refactor_hmr_use___rolldown_exports___as_the_name_for_esm_moduoe_namespace_object

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Aug 3, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2025

Benchmarks Rust

  • target: main(6808709)
  • pr: 08-04-refactor_hmr_use___rolldown_exports___as_the_name_for_esm_moduoe_namespace_object(e274910)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     82.1±2.69ms        ? ?/sec    1.00     80.9±2.33ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     93.6±4.08ms        ? ?/sec    1.00     91.5±2.79ms        ? ?/sec
bundle/bundle@rome_ts                                        1.04    121.9±4.78ms        ? ?/sec    1.00    117.4±2.01ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    140.5±3.20ms        ? ?/sec    1.00    138.3±1.60ms        ? ?/sec
bundle/bundle@threejs                                        1.01     43.2±1.32ms        ? ?/sec    1.00     42.7±0.91ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.03     53.4±2.90ms        ? ?/sec    1.00     52.0±0.72ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    448.2±6.64ms        ? ?/sec    1.00    449.1±5.05ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    535.3±7.36ms        ? ?/sec    1.00    536.3±8.08ms        ? ?/sec
scan/scan@rome_ts                                            1.00     92.3±2.36ms        ? ?/sec    1.02     93.9±2.42ms        ? ?/sec
scan/scan@threejs                                            1.01     31.7±0.96ms        ? ?/sec    1.00     31.5±0.53ms        ? ?/sec
scan/scan@threejs10x                                         1.00    329.7±4.19ms        ? ?/sec    1.00    329.2±4.10ms        ? ?/sec

@sapphi-red sapphi-red changed the title refactor(hmr): use __rolldown_exports__ as the name for esm moduoe namespace object refactor(hmr): use __rolldown_exports__ as the name for esm module namespace object Aug 4, 2025
@hyf0 hyf0 force-pushed the 08-04-refactor_hmr_use___rolldown_exports___as_the_name_for_esm_moduoe_namespace_object branch from 7b6283b to 7c97447 Compare August 4, 2025 02:31
@hyf0 hyf0 force-pushed the 08-04-fix_hmr_ensure_correct_runtime_behavior_for_export_from_._ branch from 5ec6972 to 090001e Compare August 4, 2025 02:31
@graphite-app graphite-app bot changed the base branch from 08-04-fix_hmr_ensure_correct_runtime_behavior_for_export_from_._ to graphite-base/5579 August 4, 2025 02:51
@hyf0 hyf0 force-pushed the 08-04-refactor_hmr_use___rolldown_exports___as_the_name_for_esm_moduoe_namespace_object branch from 7c97447 to a4dbc3d Compare August 4, 2025 03:11
@hyf0 hyf0 force-pushed the graphite-base/5579 branch from 090001e to b0fe3e3 Compare August 4, 2025 03:11
@graphite-app graphite-app bot changed the base branch from graphite-base/5579 to main August 4, 2025 03:12
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 4, 2025

Merge activity

  • Aug 4, 3:12 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@hyf0 hyf0 force-pushed the 08-04-refactor_hmr_use___rolldown_exports___as_the_name_for_esm_moduoe_namespace_object branch from a4dbc3d to e274910 Compare August 4, 2025 06:04
@netlify
Copy link

netlify bot commented Aug 4, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit e274910
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68904d833b693b000800aa1c

@hyf0 hyf0 added this pull request to the merge queue Aug 4, 2025
Merged via the queue into main with commit 8513ff4 Aug 4, 2025
22 checks passed
@hyf0 hyf0 deleted the 08-04-refactor_hmr_use___rolldown_exports___as_the_name_for_esm_moduoe_namespace_object branch August 4, 2025 06:20
@github-actions github-actions bot mentioned this pull request Aug 4, 2025
shulaoda added a commit that referenced this pull request Aug 4, 2025
## [1.0.0-beta.31] - 2025-08-04

### 🚀 Features

- support function for asset_inline_limit (#5453) by @AliceLanniste
- hmr: generate initializer for `export * from ...` (#5577) by @hyf0
- hmr: remove meaningless stmt instead of replacing with empty stmt (#5570) by @hyf0
- option `watch.clearScreen` (#5518) by @situ2001
- rolldown: oxc v0.80.0 (#5538) by @Boshen
- plugin/generateBundle: add support for modifying chunk filename (#5564) by @shulaoda
- assetFileNames: support `name` and `originalFileName` (#5555) by @shulaoda
- add optional `onInvalidate` schema to validator (#5528) by @situ2001
- don't throw resolve errors for dynamic import inside try block (#5537) by @shulaoda
- rolldown: oxc v0.79.0 (#5512) by @Boshen
- rolldown_plugin_asset: align `render_chunk` logic (#5511) by @shulaoda
- rolldown_plugin_utls: finish `render_asset_url_in_js` (#5508) by @shulaoda
- rolldown_plugin_utils: align replacement logic for `__VITE_ASSET__` (#5507) by @shulaoda
- rolldown_plugin_utils: add partial `render_asset_url_in_js` support (#5504) by @shulaoda
- expose `sourcemapBaseUrl` from NormalizedOutputOptions (#5513) by @sapphi-red

### 🐛 Bug Fixes

- modify output filename correctly in `generateBundle` and `writeBundle` (#5580) by @shulaoda
- hmr: ensure correct runtime behavior for `export * from ...` (#5578) by @hyf0
- hmr: repeated imports should point to the same binding (#5571) by @hyf0
- hmr: handle `export * from ...` (#5566) by @hyf0
- rolldown_plugin_web_worker_post: handle `import.meta` correctly (#5565) by @shulaoda
- antd bundle output not correct (#5549) by @IWANABETHATGUY
- hmr: module namespace object should be included via treeshaking mechanism normally (#5543) by @hyf0
- plugin/vite-resolve: use `import` / `require` conditions for external modules resolution (#5540) by @sapphi-red
- rolldown_plugin_asset: InvalidAsset#is should match InvalidAsset::True (#5529) by @AliceLanniste
- __name lacks require('./chunk-containing-runtime') when format: 'cjs' + keepNames: true (#5526) by @IWANABETHATGUY
- plugin/vite-resolve: resolve externalized packages with `resolve.externalConditions` (#5491) by @sapphi-red
- optimization.inlineConst: true does not keep export names when output.minifyInternalExports: true is enabled (#5520) by @IWANABETHATGUY
- scanner: identify `module.exports.__esModule = true` (#5503) by @overlookmotel
- error instead of panic if `sourcemapBaseUrl` is an invalid URL (#5514) by @sapphi-red

### 🚜 Refactor

- hmr: use `__rolldown_exports__` as the name for esm module namespace object (#5579) by @hyf0
- tests: rename `_configName` to `_testName` in configuration files and update variant formatting in snapshots (#5569) by @hyf0
- rolldown: remove unnecessary comments (#5552) by @situ2001
- rolldown: Remove `rolldown_rstr` crate and use `CompactStr` directly (#5542) by @Copilot
- hide namespace statement index knowledge inside StmtInfos (#5545) by @sapphi-red
- use pascal case when naming bitflags field for `ImportRecordMeta` (#5539) by @IWANABETHATGUY
- use concat_string! to simplify string concatenation (#5527) by @IWANABETHATGUY
- use combinator function handle `sourcemap_base_url` parsing (#5517) by @IWANABETHATGUY
- rolldown_plugin_utils: improve `to_output_file_path_in_js` (#5505) by @shulaoda

### 📚 Documentation

- wording nit (#5521) by @nullxone

### 🧪 Testing

- rust: rename `configName` to `_configName` and add comments (#5568) by @hyf0
- rust: re-organize `rolldown_testing_config` (#5567) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance npm packages (#5582) by @renovate[bot]
- deps: lock file maintenance (#5581) by @renovate[bot]
- deps: lock file maintenance rust crates (#5576) by @renovate[bot]
- deps: lock file maintenance npm packages (#5574) by @renovate[bot]
- deps: update github-actions (#5573) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.15.1 (#5572) by @renovate[bot]
- deps: update dependency tsdown to v0.13.2 (#5562) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to ^0.15.0 (#5563) by @renovate[bot]
- ai: Add AGENTS.md and GitHub Copilot setup workflow (#5556) by @Copilot
- deps: update dependency tsdown to v0.13.1 (#5551) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.14.3 (#5544) by @renovate[bot]
- ensure all diagnostics in self.errors have Severity::Error (#5494) by @sapphi-red
- vscode: remove `code-spell-checker` extension (#5530) by @shulaoda
- deps: update dependency rolldown-plugin-dts to v0.14.2 (#5522) by @renovate[bot]
- add link to the REPL in the reproduction field description (#5519) by @sapphi-red
- enable some rollup tests (#5515) by @sapphi-red

### ❤️ New Contributors

* @Copilot made their first contribution in [#5556](#5556)
* @nullxone made their first contribution in [#5521](#5521)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants