Fix removal of AstKind::SimpleAssignmentTarget#5506
Closed
overlookmotel wants to merge 3 commits intorolldown:next-oxcfrom
Closed
Fix removal of AstKind::SimpleAssignmentTarget#5506overlookmotel wants to merge 3 commits intorolldown:next-oxcfrom
AstKind::SimpleAssignmentTarget#5506overlookmotel wants to merge 3 commits intorolldown:next-oxcfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turned out to be pretty painful! Without
AstKind::SimpleAssignmentTarget, the logic to determine if a node is being assigned to becomes really complicated.To avoid having to duplicate that logic in many places, I've added methods in Oxc. This commit relies on oxc-project/oxc#12596 (which isn't merged yet).
cargo checknow passes, because all explicit references toAstKind::SimpleAssignmentTargetare removed. But I'm not sure if this will fix everything. There may be logic elsewhere which relies onAstKind::SimpleAssignmentTargetexisting in the ancestry chain, and so skips over them, but they're no longer there to be skipped over.just rolldoesn't throw any errors, and no snapshot files change, but I'm not sure if that means all is well - not sure if Rolldown's conformance works in same way as Oxc's.