Skip to content

Comments

perf(plugin_driver): skip unused hooks early based on hook usage meta#5363

Merged
shulaoda merged 1 commit intomainfrom
07-20-perf_plugin_driver_skip_unused_hooks_early_based_on_hook_usage_meta
Jul 20, 2025
Merged

perf(plugin_driver): skip unused hooks early based on hook usage meta#5363
shulaoda merged 1 commit intomainfrom
07-20-perf_plugin_driver_skip_unused_hooks_early_based_on_hook_usage_meta

Conversation

@shulaoda
Copy link
Member

No description provided.

Copy link
Member Author

shulaoda commented Jul 20, 2025

@shulaoda shulaoda marked this pull request as ready for review July 20, 2025 12:42
@shulaoda shulaoda requested a review from IWANABETHATGUY July 20, 2025 12:44
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2025

Benchmarks Rust

  • target: main(73a2956)
  • pr: 07-20-perf_plugin_driver_skip_unused_hooks_early_based_on_hook_usage_meta(814489a)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     92.0±4.21ms        ? ?/sec    1.02     94.1±5.68ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00    102.7±5.05ms        ? ?/sec    1.03    105.3±5.43ms        ? ?/sec
bundle/bundle@rome_ts                                        1.04    135.8±5.95ms        ? ?/sec    1.00    130.9±5.20ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.03    158.9±5.65ms        ? ?/sec    1.00    154.3±5.53ms        ? ?/sec
bundle/bundle@threejs                                        1.07     50.7±3.16ms        ? ?/sec    1.00     47.3±1.91ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.04     61.6±2.42ms        ? ?/sec    1.00     59.3±2.24ms        ? ?/sec
bundle/bundle@threejs10x                                     1.04   527.0±18.02ms        ? ?/sec    1.00   505.6±16.02ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.07   635.6±21.25ms        ? ?/sec    1.00   594.6±15.39ms        ? ?/sec
scan/scan@rome_ts                                            1.02    100.6±3.76ms        ? ?/sec    1.00     98.9±3.67ms        ? ?/sec
scan/scan@threejs                                            1.07     35.4±2.25ms        ? ?/sec    1.00     33.1±1.26ms        ? ?/sec
scan/scan@threejs10x                                         1.04   372.7±10.75ms        ? ?/sec    1.00    359.5±9.63ms        ? ?/sec

IWANABETHATGUY
IWANABETHATGUY previously approved these changes Jul 20, 2025
Base automatically changed from 07-20-chore_extract_hookorderindicates_logic to main July 20, 2025 13:12
@shulaoda shulaoda force-pushed the 07-20-perf_plugin_driver_skip_unused_hooks_early_based_on_hook_usage_meta branch from aedf64f to 814489a Compare July 20, 2025 13:12
@netlify
Copy link

netlify bot commented Jul 20, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 814489a
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/687ceb4ecb47c90008987f55

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 20, 2025

Merge activity

  • Jul 20, 1:13 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@shulaoda shulaoda added this pull request to the merge queue Jul 20, 2025
@IWANABETHATGUY IWANABETHATGUY removed this pull request from the merge queue due to a manual request Jul 20, 2025
@shulaoda shulaoda added this pull request to the merge queue Jul 20, 2025
Merged via the queue into main with commit 0a6e380 Jul 20, 2025
22 checks passed
@shulaoda shulaoda deleted the 07-20-perf_plugin_driver_skip_unused_hooks_early_based_on_hook_usage_meta branch July 20, 2025 13:45
This was referenced Jul 22, 2025
shulaoda added a commit that referenced this pull request Jul 22, 2025
## [1.0.0-beta.29] - 2025-07-22

### 🚀 Features

- rolldown_plugin_chunk_import_map: support custom file name (#5383) by
@shulaoda
- rolldown_plugin_chunk_import_map: emit standard import map (#5382) by
@shulaoda
- rolldown_plugin_chunk_import_map: support custom base url (#5381) by
@shulaoda
- support plugin context meta for native plugins (#5371) by @shulaoda
- rolldown: oxc v0.77.3 (#5367) by @Boshen
- rolldown_plugin_transform: align sourcemap enable logic (#5348) by
@shulaoda
- plugin_driver: use hook usage for `close_bundle` (#5361) by @shulaoda
- hmr: attach region comments for hmr patch (#5358) by @hyf0
- rolldown: add transformHiresSourcemap option (#5346) by @Brooooooklyn
- rolldown_plugin_web_worker_post: align `transform_ast` hook metadata
order to `post` (#5339) by @shulaoda

### 🐛 Bug Fixes

- when preserveEntrySignatures: false is set, output includes a circular
import (#5365) by @IWANABETHATGUY
- do not normalize iife global names (#5228) by @redstonekasi
- hmr: should not panic for editing modules that contain `import(..)`
(#5351) by @hyf0
- sync ast for newly added modules (#5354) by @IWANABETHATGUY
- used exports from dynamic imported module are removed incorrectly
(#5341) by @IWANABETHATGUY
- keep top level variables for non-esm format when minify is enabled
(#5332) by @sapphi-red
- rust: correctly return watch option (#5334) by @HigherOrderLogic

### 🚜 Refactor

- rolldown_plugin_chunk_import_map: clarify import map paths and output
filename (#5376) by @shulaoda
- rolldown: `collapse_sourcemaps` does not need to own a Vec (#5352) by
@Boshen
- rolldown_plugin_asset: improve readability for easier maintenance
(#5359) by @shulaoda
- ecmascript: remove unnecessary `allocator.alloc(program)` call (#5350)
by @Boshen
- store ast with same shape as module_table (#5345) by @IWANABETHATGUY
- simplify `is_dynamic_entry_alive` (#5342) by @IWANABETHATGUY
- rolldown_plugin_web_worker_post: tweak code organization (#5338) by
@shulaoda
- store `ScopeFlags` instead of `ScopeId` when traverse ast (#5330) by
@IWANABETHATGUY
- simplify `keep_names` VarDeclaration rewrite (#5325) by
@IWANABETHATGUY

### 📚 Documentation

- experimental: update the description of `chunkImportMap` (#5384) by
@shulaoda
- experiment: add usage documentation for `chunkImportMap` (#5379) by
@shulaoda

### ⚡ Performance

- plugin_driver: skip unused hooks early based on hook usage meta
(#5363) by @shulaoda
- rolldown: box `TransformOptions` (#5353) by @Boshen

### 🧪 Testing

- rust: hide runtime module output in snapshots to improve clarity
(#5366) by @hyf0
- node: put minify related tests in a single directory (#5333) by
@sapphi-red

### ⚙️ Miscellaneous Tasks

- examples: update `chunk-import-map` (#5385) by @shulaoda
- add `examples/chunk-import-map` (#5380) by @shulaoda
- deps: lock file maintenance (#5373) by @renovate[bot]
- deps: lock file maintenance rust crates (#5372) by @renovate[bot]
- deps: lock file maintenance npm packages (#5370) by @renovate[bot]
- deps: update dependency @napi-rs/wasm-runtime to v1 (#5369) by
@renovate[bot]
- deps: update taiki-e/install-action action to v2.56.19 (#5368) by
@renovate[bot]
- extract `HookOrderIndicates` logic (#5362) by @shulaoda
- rust: remove unnecessary `#[allow(unused)]` (#5360) by @shulaoda
- deps: update dependency rolldown-plugin-dts to v0.14.1 (#5357) by
@renovate[bot]
- use `debug=1` for profile.dev and profile.test (#5355) by
@IWANABETHATGUY
- deps: update dependency rolldown-plugin-dts to ^0.14.0 (#5349) by
@renovate[bot]
- remove packages/rolldown/npm/* from workspace config (#5347) by
@Brooooooklyn
- pnpm,justfile: enable pnpm `verifyDepsBeforeRun: install` (#5331) by
@Boshen
- update `build-js-glue` script (#5335) by @btea

### ◀️ Revert

- `test(rust): prevent meaningless snapshot change from bumping oxc
runtime versions #5312` (#5336) by @hyf0

### ❤️ New Contributors

* @redstonekasi made their first contribution in
[#5228](#5228)
* @HigherOrderLogic made their first contribution in
[#5334](#5334)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants