chore: remove packages/rolldown/npm/* from workspace config#5347
Merged
Brooooooklyn merged 1 commit intomainfrom Jul 18, 2025
Merged
chore: remove packages/rolldown/npm/* from workspace config#5347Brooooooklyn merged 1 commit intomainfrom
Brooooooklyn merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hyf0
approved these changes
Jul 18, 2025
Brooooooklyn
force-pushed
the
remove-npm-xxx-from-workspace
branch
from
a6331d2 to
cd50e5f
Compare
@rolldown/browser
@rolldown/debug
@rolldown/pluginutils
rolldown
@rolldown/binding-android-arm64
@rolldown/binding-darwin-arm64
@rolldown/binding-darwin-x64
@rolldown/binding-freebsd-x64
@rolldown/binding-linux-arm-gnueabihf
@rolldown/binding-linux-arm64-gnu
@rolldown/binding-linux-arm64-musl
@rolldown/binding-linux-arm64-ohos
@rolldown/binding-linux-x64-gnu
@rolldown/binding-linux-x64-musl
@rolldown/binding-wasm32-wasi
@rolldown/binding-win32-arm64-msvc
@rolldown/binding-win32-ia32-msvc
@rolldown/binding-win32-x64-msvc
commit: |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| run: | | ||
| node --import @oxc-node/core/register ./scripts/misc/bump-version.js ${ROLLDOWN_VERSION} | ||
| pnpm --filter rolldown prepublishOnly | ||
| pnpm --filter rolldown prepublishOnly --skip-optional-publish |
Contributor
There was a problem hiding this comment.
It appears there's a flag placement issue. The --skip-optional-publish flag is being passed to the pnpm command, but based on the package.json changes, this flag is intended for the napi pre-publish command.
The flag was removed from the prepublishOnly script in package.json:
- "prepublishOnly": "napi pre-publish -t npm --no-gh-release --skip-optional-publish"
+ "prepublishOnly": "napi pre-publish -t npm --no-gh-release"But then added to the workflow command:
- pnpm --filter rolldown prepublishOnly
+ pnpm --filter rolldown prepublishOnly --skip-optional-publishFor consistency, either:
- Move the flag back to the
napicommand in package.json, or - Remove it from this workflow command
This will ensure the flag is passed to the correct tool.
Suggested change
| pnpm --filter rolldown prepublishOnly --skip-optional-publish | |
| pnpm --filter rolldown prepublishOnly |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This was referenced Jul 22, 2025
shulaoda
added a commit
that referenced
this pull request
Jul 22, 2025
## [1.0.0-beta.29] - 2025-07-22 ### 🚀 Features - rolldown_plugin_chunk_import_map: support custom file name (#5383) by @shulaoda - rolldown_plugin_chunk_import_map: emit standard import map (#5382) by @shulaoda - rolldown_plugin_chunk_import_map: support custom base url (#5381) by @shulaoda - support plugin context meta for native plugins (#5371) by @shulaoda - rolldown: oxc v0.77.3 (#5367) by @Boshen - rolldown_plugin_transform: align sourcemap enable logic (#5348) by @shulaoda - plugin_driver: use hook usage for `close_bundle` (#5361) by @shulaoda - hmr: attach region comments for hmr patch (#5358) by @hyf0 - rolldown: add transformHiresSourcemap option (#5346) by @Brooooooklyn - rolldown_plugin_web_worker_post: align `transform_ast` hook metadata order to `post` (#5339) by @shulaoda ### 🐛 Bug Fixes - when preserveEntrySignatures: false is set, output includes a circular import (#5365) by @IWANABETHATGUY - do not normalize iife global names (#5228) by @redstonekasi - hmr: should not panic for editing modules that contain `import(..)` (#5351) by @hyf0 - sync ast for newly added modules (#5354) by @IWANABETHATGUY - used exports from dynamic imported module are removed incorrectly (#5341) by @IWANABETHATGUY - keep top level variables for non-esm format when minify is enabled (#5332) by @sapphi-red - rust: correctly return watch option (#5334) by @HigherOrderLogic ### 🚜 Refactor - rolldown_plugin_chunk_import_map: clarify import map paths and output filename (#5376) by @shulaoda - rolldown: `collapse_sourcemaps` does not need to own a Vec (#5352) by @Boshen - rolldown_plugin_asset: improve readability for easier maintenance (#5359) by @shulaoda - ecmascript: remove unnecessary `allocator.alloc(program)` call (#5350) by @Boshen - store ast with same shape as module_table (#5345) by @IWANABETHATGUY - simplify `is_dynamic_entry_alive` (#5342) by @IWANABETHATGUY - rolldown_plugin_web_worker_post: tweak code organization (#5338) by @shulaoda - store `ScopeFlags` instead of `ScopeId` when traverse ast (#5330) by @IWANABETHATGUY - simplify `keep_names` VarDeclaration rewrite (#5325) by @IWANABETHATGUY ### 📚 Documentation - experimental: update the description of `chunkImportMap` (#5384) by @shulaoda - experiment: add usage documentation for `chunkImportMap` (#5379) by @shulaoda ### ⚡ Performance - plugin_driver: skip unused hooks early based on hook usage meta (#5363) by @shulaoda - rolldown: box `TransformOptions` (#5353) by @Boshen ### 🧪 Testing - rust: hide runtime module output in snapshots to improve clarity (#5366) by @hyf0 - node: put minify related tests in a single directory (#5333) by @sapphi-red ### ⚙️ Miscellaneous Tasks - examples: update `chunk-import-map` (#5385) by @shulaoda - add `examples/chunk-import-map` (#5380) by @shulaoda - deps: lock file maintenance (#5373) by @renovate[bot] - deps: lock file maintenance rust crates (#5372) by @renovate[bot] - deps: lock file maintenance npm packages (#5370) by @renovate[bot] - deps: update dependency @napi-rs/wasm-runtime to v1 (#5369) by @renovate[bot] - deps: update taiki-e/install-action action to v2.56.19 (#5368) by @renovate[bot] - extract `HookOrderIndicates` logic (#5362) by @shulaoda - rust: remove unnecessary `#[allow(unused)]` (#5360) by @shulaoda - deps: update dependency rolldown-plugin-dts to v0.14.1 (#5357) by @renovate[bot] - use `debug=1` for profile.dev and profile.test (#5355) by @IWANABETHATGUY - deps: update dependency rolldown-plugin-dts to ^0.14.0 (#5349) by @renovate[bot] - remove packages/rolldown/npm/* from workspace config (#5347) by @Brooooooklyn - pnpm,justfile: enable pnpm `verifyDepsBeforeRun: install` (#5331) by @Boshen - update `build-js-glue` script (#5335) by @btea ###◀️ Revert - `test(rust): prevent meaningless snapshot change from bumping oxc runtime versions #5312` (#5336) by @hyf0 ### ❤️ New Contributors * @redstonekasi made their first contribution in [#5228](#5228) * @HigherOrderLogic made their first contribution in [#5334](#5334) Co-authored-by: shulaoda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.