Skip to content

fix: incremental watch panic when adding dynamic import #5309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IWANABETHATGUY merged 1 commit into from
Jul 16, 2025
Merged

fix: incremental watch panic when adding dynamic import #5309

IWANABETHATGUY merged 1 commit into from
Jul 16, 2025

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jul 16, 2025 •
edited
Loading

Closed #5260

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jul 16, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jul 16, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 654260e
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6877c24a17a78200086a573d
😎 Deploy Preview https://deploy-preview-5309--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025 •
edited
Loading

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     77.5±2.73ms        ? ?/sec    1.00     75.9±2.13ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     87.3±1.99ms        ? ?/sec    1.00     86.5±1.60ms        ? ?/sec
bundle/bundle@rome_ts                                        1.03    116.5±3.94ms        ? ?/sec    1.00    113.1±1.50ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    138.1±3.05ms        ? ?/sec    1.00    135.5±2.30ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.2±2.50ms        ? ?/sec    1.00     42.3±2.62ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     52.6±1.06ms        ? ?/sec    1.00     51.5±0.85ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    438.6±4.99ms        ? ?/sec    1.00    436.9±6.22ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    522.4±4.92ms        ? ?/sec    1.00    520.0±3.64ms        ? ?/sec
scan/scan@rome_ts                                            1.00     88.4±1.25ms        ? ?/sec    1.01     88.9±1.59ms        ? ?/sec
scan/scan@threejs                                            1.00     30.6±0.35ms        ? ?/sec    1.01     30.8±0.76ms        ? ?/sec
scan/scan@threejs10x                                         1.00    325.1±5.40ms        ? ?/sec    1.00    324.6±4.10ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review July 16, 2025 15:16
@IWANABETHATGUY IWANABETHATGUY changed the title fix: 5260 fix: incremental watch panic when adding dynamic import Jul 16, 2025
graphite-app[bot]
graphite-app bot reviewed Jul 16, 2025
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jul 16, 2025
Merged via the queue into main with commit 53d1df9 Jul 16, 2025
34 of 36 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 07-16-fix_5260 branch July 16, 2025 15:52
This was referenced Jul 17, 2025
Closed
Merged
shulaoda pushed a commit that referenced this pull request Jul 17, 2025
@github-actions @IWANABETHATGUY
release: v1.0.0-beta.28 (#5329)
4afe097 
## [1.0.0-beta.28] - 2025-07-17

### 🚀 Features

- rolldown: oxc v0.77.2 (#5328) by @Boshen
- hmr: add `module` and `exports` parameters to CJS initializer
functions (#5322) by @hyf0
- rolldown_plugin_transform: align with `vitejs/rolldown-vite#318`
(#5318) by @shulaoda
- rolldown_plugin_transform: align with `vitejs/rolldown-vite#315`
(#5315) by @shulaoda
- hmr: automatically disable treeshaking in hmr (#5311) by @hyf0
- hmr: use `trait HmrAstBuilder` to unify ast construction (#5310) by
@hyf0
- rolldown_plugin_chunk_import_map: basic implementation (#5307) by
@shulaoda
- add `watch.onInvalidate` (#5239) by @situ2001
- rolldown_plugin_chunk_import_map: implement initial `render_chunk`
logic (#5306) by @shulaoda
- rolldown: oxc v0.77.1 (#5304) by @Boshen
- js: expose `experimental.incrementalBuild` option (#5300) by
@IWANABETHATGUY
- js: support `experimental.onDemandWrapping` option (#5299) by
@IWANABETHATGUY
- support on demand wrapping for entry chunk (#5291) by @IWANABETHATGUY
- rolldown_plugin_chunk_import_map: initialize (#5289) by @shulaoda
- show owner module id for "canonical name not found for" errors (#5288)
by @sapphi-red

### 🐛 Bug Fixes

- only transform VarDeclaration when enable `keepNames` (#5323) by
@IWANABETHATGUY
- keepNames with special Ifstmt (#5320) by @IWANABETHATGUY
- incremental watch panic when adding dynamic import (#5309) by
@IWANABETHATGUY
- make leaf module wrapping optimization opt-in (#5305) by
@IWANABETHATGUY
- `keepNames` should consider exportNamed function declaration (#5298)
by @IWANABETHATGUY
- undefined `process.versions` for browser build (#5295) by @sxzz
- sanitizeFileName: entry name should be sanitized (#5283) by @shulaoda
- minify-internal-exports: ensure minifying internal exports stably
(#5281) by @hyf0
- keep legal and annotation comments for `minify: 'dce-only'` (#5280) by
@sapphi-red
- unstable chunk generation when `preserveEntrySignatures: false` is
used (#5274) by @IWANABETHATGUY

### 🚜 Refactor

- pass the while CodegenOptions to `EcmaCompiler::minify` (#5279) by
@sapphi-red
- avoid iterate `canonical_exports` twice (#5276) by @IWANABETHATGUY

### 📚 Documentation

- pluginutils: add README file (#5262) by @TheAlexLichter

### ⚡ Performance

- inline function expression when rewriting `name` property with
`keepNames` enabled (#5321) by @IWANABETHATGUY
- rolldown_sourcemap: cache source id -> source text mapping (#5285) by
@Boshen
- rolldown_sourcemap: disable rayon (#5284) by @Boshen

### 🧪 Testing

- rust: prevent meaningless snapshot change from bumping oxc runtime
versions (#5312) by @hyf0

### ⚙️ Miscellaneous Tasks

- upgrade to NAPI-RS 3.0 stable (#5324) by @Brooooooklyn
- infra: add onlyBuiltDependencies (#5287) by @situ2001
- improve the order of import keys in the exports field (#5314) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.14 (#5293) by
@renovate[bot]
- deps: lock file maintenance rust crates (#5267) by @renovate[bot]
- deps: lock file maintenance npm packages (#5266) by @renovate[bot]
- deps: update github-actions (#5265) by @renovate[bot]

### ❤️ New Contributors

* @situ2001 made their first contribution in
[#5287](#5287)

Co-authored-by: IWANABETHATGUY <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@shulaoda shulaoda shulaoda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: incremental watch panic when adding dynamic import

3 participants

@IWANABETHATGUY @shulaoda