Skip to content

Comments

test(hmr): panics with no entry found for key when editing dynamic imports#5248

Closed
sapphi-red wants to merge 1 commit intomainfrom
07-11-test_hmr_panics_with_no_entry_found_for_key_when_editing_dynamic_imports
Closed

test(hmr): panics with no entry found for key when editing dynamic imports#5248
sapphi-red wants to merge 1 commit intomainfrom
07-11-test_hmr_panics_with_no_entry_found_for_key_when_editing_dynamic_imports

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 11, 2025 •
edited
Loading

See #5249

@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Jul 11, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jul 11, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 6dcfc70
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/687079f811afbc00085dcfdd

@sapphi-red sapphi-red mentioned this pull request Jul 11, 2025
Closed
@hyf0 hyf0 mentioned this pull request Jul 19, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 20, 2025
@hyf0
fix(hmr): should not panic for editing modules that contain `import(.…
a29b625 
….)` (#5351)

Run

```
RD_LOG=hmr=trace RUST_BACKTRACE=FULL cargo test -p rolldown -- fixture_with_config_tests__rolldown__topics__hmr__dynamic_import__config_json --nocapture
```

Closes #5249
Closes #5248
@hyf0 hyf0 closed this in #5351 Jul 20, 2025
@sapphi-red sapphi-red deleted the 07-11-test_hmr_panics_with_no_entry_found_for_key_when_editing_dynamic_imports branch July 20, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @IWANABETHATGUY