fix: fix unused export panic when hmr: true#5237
Closed
RomanHotsiy wants to merge 1 commit intorolldown:mainfrom
Closed
fix: fix unused export panic when hmr: true#5237RomanHotsiy wants to merge 1 commit intorolldown:mainfrom
RomanHotsiy wants to merge 1 commit intorolldown:mainfrom
Conversation
RomanHotsiy
commented
Jul 10, 2025
Comment on lines
+326
to
+327
| .iter() | ||
| .any(|id| m.stmt_infos[*id].is_included), |
Author
There was a problem hiding this comment.
I'm worried if this won't affect performance. Maybe the filtering needs to be done if only HMR is enabled?
RomanHotsiy
force-pushed
the
fix-barrel-unused
branch
from
00b9419 to
6b444f8
Compare
Member
|
Thanks for your work on this. It's not good that we're too busy to make some clarifications. HMR is an experitmental and incomplete core feature. The current focus is to make it work in rolldown-vite. So we currently don't have the bandwidth to accept contributions or deal with community issues. |
Member
|
HMR doesn't work with treeshaking is expected so far. To fix it, it requires a considerate design, we don't want to fix/handle it case by case at current stage, which might solves the problem for now but increase the complexity of handling it in the future. |
Author
|
Understood. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix #5235
Disclosure: this is AI-assisted as it's my first contribution into this repo and I'm not familiar with the code to be confident.
I confirmed that the test-case crashes before the fix and passes after the fix.