Skip to content

Comments

refactor: use sort_unstable_by_key for simple property access#5233

Merged
IWANABETHATGUY merged 1 commit intomainfrom
07-10-refactor_use_sort_unstable_by_key_for_simple_property_access
Jul 10, 2025
Merged

refactor: use sort_unstable_by_key for simple property access#5233
IWANABETHATGUY merged 1 commit intomainfrom
07-10-refactor_use_sort_unstable_by_key_for_simple_property_access

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jul 10, 2025

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b320447
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/686f55910622b90008dafc32

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review July 10, 2025 05:55
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 3982ebf Jul 10, 2025
25 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 07-10-refactor_use_sort_unstable_by_key_for_simple_property_access branch July 10, 2025 06:08
@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(66456bf)
  • pr: 07-10-refactor_use_sort_unstable_by_key_for_simple_property_access(b320447)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     81.3±3.08ms        ? ?/sec    1.02     83.1±3.06ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     95.8±3.15ms        ? ?/sec    1.00     94.8±3.32ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    119.4±4.68ms        ? ?/sec    1.00    119.8±3.03ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    139.5±2.96ms        ? ?/sec    1.03    143.3±2.97ms        ? ?/sec
bundle/bundle@threejs                                        1.00     44.4±2.67ms        ? ?/sec    1.01     45.0±2.79ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     52.3±1.13ms        ? ?/sec    1.03     53.9±1.90ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    458.9±8.35ms        ? ?/sec    1.01    463.7±7.89ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    535.6±7.67ms        ? ?/sec    1.00    533.9±8.22ms        ? ?/sec
scan/scan@rome_ts                                            1.02     94.2±2.14ms        ? ?/sec    1.00     92.8±2.55ms        ? ?/sec
scan/scan@threejs                                            1.00     32.4±0.70ms        ? ?/sec    1.01     32.8±3.10ms        ? ?/sec
scan/scan@threejs10x                                         1.01    338.8±4.48ms        ? ?/sec    1.00    336.3±7.52ms        ? ?/sec

IWANABETHATGUY pushed a commit that referenced this pull request Jul 10, 2025
## [1.0.0-beta.25] - 2025-07-10

### 🚀 Features

- hmr: should initialize cjs with correct initializer (#5234) by @hyf0
- hmr: handle `import(..)` on cjs modules (#5225) by @hyf0
- support `chunkModulesOrder`  (#5227) by @IWANABETHATGUY
- add `export`s to `rolldown:runtime` (#5224) by @hyf0
- hmr: support `import(..)` (#5223) by @hyf0
- add analyzed source code side effects field in ecmaMeta (#5226) by
@IWANABETHATGUY
- hmr: return `undefined` from `generateHmrPatch` when there is no patch
(#5218) by @sapphi-red
- pass `isEntry` to resolveId hook of CallableBuiltinPlugin (#5215) by
@sapphi-red
- pass `isEntry` from `this.resolve` (#5214) by @sapphi-red
- node: support `OutputOptions#minifyInternalExports` (#5210) by @hyf0
- rolldown: oxc v0.76.0 (#5212) by @Boshen
- rust: support `minify_internal_exports` (#5208) by @hyf0
- support opt-in `topLevelVar` (#5188) by @7086cmd
- rolldown: oxc-resolver v11.5.0 (yarn pnp) (#5147) by @Boshen

### 🐛 Bug Fixes

- do not optimize interop code for `mod.default` if mod bind from
default import (#5232) by @IWANABETHATGUY
- return `moduleSideEffects` instead of `sideEffects` from callable
plugins (#5206) by @sapphi-red
- return `moduleSideEffects` set by native plugins from `this.resolve`
(#5205) by @sapphi-red
- incorrect output when importing CJS package (#5201) by @IWANABETHATGUY
- use resolved id instead of module_request when analysis if a module is
a json module (#5200) by @IWANABETHATGUY

### 🚜 Refactor

- use `sort_unstable_by_key` for simple property access (#5233) by
@IWANABETHATGUY
- add Deref impl for TransformPluginContext to access PluginContext
(#5221) by @sapphi-red
- use `BindingHookSideEffects` in CallableBuiltinPlugin (#5204) by
@sapphi-red
- move side effects type bindings logic to rust side (#5203) by
@sapphi-red
- test: improve experience of writing manual integration test (#5186) by
@hyf0
- rust: unify logic of `IntegrationTest` (#5185) by @hyf0

### 🧪 Testing

- rust: automatically run extented test for `minify_internal_exports:
true` (#5213) by @hyf0
- rust: add basic tests for minifying internal exports (#5211) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: oxc-browserslist v2.0.10 and oxc-resolver v11.5.2 (#5222) by
@Boshen
- use jsonc schema for knip config (#5207) by @sapphi-red
- rust: remove unused code related to
`safe_cjs_to_eliminate_interop_default` (#5202) by @shulaoda
- inject test variant name to rust unit test script (#5195) by
@IWANABETHATGUY
- change CC => TARGET_CC (#5194) by @Brooooooklyn
- deps: lock file maintenance npm packages (#5191) by @renovate[bot]
- deps: lock file maintenance (#5193) by @renovate[bot]
- deps: lock file maintenance rust crates (#5192) by @renovate[bot]
- deps: update github-actions (#5190) by @renovate[bot]
- test: remove unnecessary test snapshots (#5183) by @shulaoda
- rolldown: upgrade to NAPI-RS 3.0.0-beta.12 (#5184) by @Brooooooklyn

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants