Skip to content

Comments

feat(hmr): handle import(..) on cjs modules#5225

Merged
hyf0 merged 1 commit intomainfrom
07-09-feat_hmr_handle_import_._on_cjs_modules
Jul 10, 2025
Merged

feat(hmr): handle import(..) on cjs modules#5225
hyf0 merged 1 commit intomainfrom
07-09-feat_hmr_handle_import_._on_cjs_modules

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jul 9, 2025

No description provided.

@hyf0 hyf0 marked this pull request as ready for review July 9, 2025 13:24
@hyf0 hyf0 requested a review from sapphi-red July 9, 2025 13:25
Copy link
Member Author

hyf0 commented Jul 9, 2025

@hyf0 hyf0 force-pushed the 07-09-feat_hmr_handle_import_._on_cjs_modules branch from ebde383 to 78c3736 Compare July 9, 2025 13:33
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Benchmarks Rust

  • target: main(66456bf)
  • pr: 07-09-feat_hmr_handle_import_._on_cjs_modules(f196b02)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     81.5±2.74ms        ? ?/sec    1.00     80.6±3.24ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03     94.6±2.81ms        ? ?/sec    1.00     92.2±2.78ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    120.3±4.38ms        ? ?/sec    1.00    118.3±2.04ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    141.2±3.00ms        ? ?/sec    1.00    139.8±2.60ms        ? ?/sec
bundle/bundle@threejs                                        1.00     45.6±1.61ms        ? ?/sec    1.00     45.7±2.53ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     54.3±1.68ms        ? ?/sec    1.00     53.1±1.11ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    460.7±6.54ms        ? ?/sec    1.00    458.0±5.43ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    537.0±6.22ms        ? ?/sec    1.00    533.4±7.69ms        ? ?/sec
scan/scan@rome_ts                                            1.00     91.1±2.26ms        ? ?/sec    1.01     91.9±1.85ms        ? ?/sec
scan/scan@threejs                                            1.01     32.5±2.04ms        ? ?/sec    1.00     32.3±2.07ms        ? ?/sec
scan/scan@threejs10x                                         1.00    337.7±4.89ms        ? ?/sec    1.00    337.4±4.49ms        ? ?/sec

Base automatically changed from 07-09-feat_add_export_s_to_rolldown_runtime_ to main July 10, 2025 02:12
@hyf0 hyf0 force-pushed the 07-09-feat_hmr_handle_import_._on_cjs_modules branch from 78c3736 to 924f73b Compare July 10, 2025 02:12
@netlify
Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit f196b02
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/686f55e2b7c16700087ebade

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 10, 2025

Merge activity

  • Jul 10, 2:13 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@hyf0 hyf0 force-pushed the 07-09-feat_hmr_handle_import_._on_cjs_modules branch from 924f73b to f196b02 Compare July 10, 2025 05:55
@hyf0 hyf0 added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit b8ccf52 Jul 10, 2025
23 checks passed
@hyf0 hyf0 deleted the 07-09-feat_hmr_handle_import_._on_cjs_modules branch July 10, 2025 06:08
IWANABETHATGUY pushed a commit that referenced this pull request Jul 10, 2025
## [1.0.0-beta.25] - 2025-07-10

### 🚀 Features

- hmr: should initialize cjs with correct initializer (#5234) by @hyf0
- hmr: handle `import(..)` on cjs modules (#5225) by @hyf0
- support `chunkModulesOrder`  (#5227) by @IWANABETHATGUY
- add `export`s to `rolldown:runtime` (#5224) by @hyf0
- hmr: support `import(..)` (#5223) by @hyf0
- add analyzed source code side effects field in ecmaMeta (#5226) by
@IWANABETHATGUY
- hmr: return `undefined` from `generateHmrPatch` when there is no patch
(#5218) by @sapphi-red
- pass `isEntry` to resolveId hook of CallableBuiltinPlugin (#5215) by
@sapphi-red
- pass `isEntry` from `this.resolve` (#5214) by @sapphi-red
- node: support `OutputOptions#minifyInternalExports` (#5210) by @hyf0
- rolldown: oxc v0.76.0 (#5212) by @Boshen
- rust: support `minify_internal_exports` (#5208) by @hyf0
- support opt-in `topLevelVar` (#5188) by @7086cmd
- rolldown: oxc-resolver v11.5.0 (yarn pnp) (#5147) by @Boshen

### 🐛 Bug Fixes

- do not optimize interop code for `mod.default` if mod bind from
default import (#5232) by @IWANABETHATGUY
- return `moduleSideEffects` instead of `sideEffects` from callable
plugins (#5206) by @sapphi-red
- return `moduleSideEffects` set by native plugins from `this.resolve`
(#5205) by @sapphi-red
- incorrect output when importing CJS package (#5201) by @IWANABETHATGUY
- use resolved id instead of module_request when analysis if a module is
a json module (#5200) by @IWANABETHATGUY

### 🚜 Refactor

- use `sort_unstable_by_key` for simple property access (#5233) by
@IWANABETHATGUY
- add Deref impl for TransformPluginContext to access PluginContext
(#5221) by @sapphi-red
- use `BindingHookSideEffects` in CallableBuiltinPlugin (#5204) by
@sapphi-red
- move side effects type bindings logic to rust side (#5203) by
@sapphi-red
- test: improve experience of writing manual integration test (#5186) by
@hyf0
- rust: unify logic of `IntegrationTest` (#5185) by @hyf0

### 🧪 Testing

- rust: automatically run extented test for `minify_internal_exports:
true` (#5213) by @hyf0
- rust: add basic tests for minifying internal exports (#5211) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: oxc-browserslist v2.0.10 and oxc-resolver v11.5.2 (#5222) by
@Boshen
- use jsonc schema for knip config (#5207) by @sapphi-red
- rust: remove unused code related to
`safe_cjs_to_eliminate_interop_default` (#5202) by @shulaoda
- inject test variant name to rust unit test script (#5195) by
@IWANABETHATGUY
- change CC => TARGET_CC (#5194) by @Brooooooklyn
- deps: lock file maintenance npm packages (#5191) by @renovate[bot]
- deps: lock file maintenance (#5193) by @renovate[bot]
- deps: lock file maintenance rust crates (#5192) by @renovate[bot]
- deps: update github-actions (#5190) by @renovate[bot]
- test: remove unnecessary test snapshots (#5183) by @shulaoda
- rolldown: upgrade to NAPI-RS 3.0.0-beta.12 (#5184) by @Brooooooklyn

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants