Skip to content

Comments

feat: pass isEntry from this.resolve#5214

Merged
sapphi-red merged 2 commits intomainfrom
07-09-feat_pass_isentry_from_this.resolve_
Jul 9, 2025
Merged

feat: pass isEntry from this.resolve#5214
sapphi-red merged 2 commits intomainfrom
07-09-feat_pass_isentry_from_this.resolve_

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 9, 2025

isEntry was not passed from this.resolve calls to the resolveId hooks. This PR implements that.

Copy link
Member Author

sapphi-red commented Jul 9, 2025

@netlify
Copy link

netlify bot commented Jul 9, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit bb75b39
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/686ddb71b77c85000870f372

@sapphi-red sapphi-red marked this pull request as ready for review July 9, 2025 03:02
@netlify
Copy link

netlify bot commented Jul 9, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 85f673a
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/686ddb9589311e0008787a49

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Benchmarks Rust

  • target: main(2b2acd4)
  • pr: 07-09-feat_pass_isentry_from_this.resolve_(85f673a)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     81.0±3.07ms        ? ?/sec    1.01     82.1±3.12ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     94.3±3.27ms        ? ?/sec    1.00     94.5±3.70ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    118.8±4.52ms        ? ?/sec    1.01    119.5±2.59ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    140.0±3.43ms        ? ?/sec    1.00    140.3±3.42ms        ? ?/sec
bundle/bundle@threejs                                        1.00     44.4±2.60ms        ? ?/sec    1.00     44.3±2.44ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     52.8±1.15ms        ? ?/sec    1.01     53.3±1.03ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    457.1±7.33ms        ? ?/sec    1.00    454.7±7.08ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01   531.3±10.30ms        ? ?/sec    1.00    526.7±6.16ms        ? ?/sec
scan/scan@rome_ts                                            1.01     92.3±2.75ms        ? ?/sec    1.00     91.6±2.90ms        ? ?/sec
scan/scan@threejs                                            1.02     32.5±1.94ms        ? ?/sec    1.00     31.9±1.79ms        ? ?/sec
scan/scan@threejs10x                                         1.01    332.5±3.77ms        ? ?/sec    1.00    330.5±4.10ms        ? ?/sec

@sapphi-red sapphi-red added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit 4055070 Jul 9, 2025
24 checks passed
@sapphi-red sapphi-red deleted the 07-09-feat_pass_isentry_from_this.resolve_ branch July 9, 2025 03:24
IWANABETHATGUY pushed a commit that referenced this pull request Jul 10, 2025
## [1.0.0-beta.25] - 2025-07-10

### 🚀 Features

- hmr: should initialize cjs with correct initializer (#5234) by @hyf0
- hmr: handle `import(..)` on cjs modules (#5225) by @hyf0
- support `chunkModulesOrder`  (#5227) by @IWANABETHATGUY
- add `export`s to `rolldown:runtime` (#5224) by @hyf0
- hmr: support `import(..)` (#5223) by @hyf0
- add analyzed source code side effects field in ecmaMeta (#5226) by
@IWANABETHATGUY
- hmr: return `undefined` from `generateHmrPatch` when there is no patch
(#5218) by @sapphi-red
- pass `isEntry` to resolveId hook of CallableBuiltinPlugin (#5215) by
@sapphi-red
- pass `isEntry` from `this.resolve` (#5214) by @sapphi-red
- node: support `OutputOptions#minifyInternalExports` (#5210) by @hyf0
- rolldown: oxc v0.76.0 (#5212) by @Boshen
- rust: support `minify_internal_exports` (#5208) by @hyf0
- support opt-in `topLevelVar` (#5188) by @7086cmd
- rolldown: oxc-resolver v11.5.0 (yarn pnp) (#5147) by @Boshen

### 🐛 Bug Fixes

- do not optimize interop code for `mod.default` if mod bind from
default import (#5232) by @IWANABETHATGUY
- return `moduleSideEffects` instead of `sideEffects` from callable
plugins (#5206) by @sapphi-red
- return `moduleSideEffects` set by native plugins from `this.resolve`
(#5205) by @sapphi-red
- incorrect output when importing CJS package (#5201) by @IWANABETHATGUY
- use resolved id instead of module_request when analysis if a module is
a json module (#5200) by @IWANABETHATGUY

### 🚜 Refactor

- use `sort_unstable_by_key` for simple property access (#5233) by
@IWANABETHATGUY
- add Deref impl for TransformPluginContext to access PluginContext
(#5221) by @sapphi-red
- use `BindingHookSideEffects` in CallableBuiltinPlugin (#5204) by
@sapphi-red
- move side effects type bindings logic to rust side (#5203) by
@sapphi-red
- test: improve experience of writing manual integration test (#5186) by
@hyf0
- rust: unify logic of `IntegrationTest` (#5185) by @hyf0

### 🧪 Testing

- rust: automatically run extented test for `minify_internal_exports:
true` (#5213) by @hyf0
- rust: add basic tests for minifying internal exports (#5211) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: oxc-browserslist v2.0.10 and oxc-resolver v11.5.2 (#5222) by
@Boshen
- use jsonc schema for knip config (#5207) by @sapphi-red
- rust: remove unused code related to
`safe_cjs_to_eliminate_interop_default` (#5202) by @shulaoda
- inject test variant name to rust unit test script (#5195) by
@IWANABETHATGUY
- change CC => TARGET_CC (#5194) by @Brooooooklyn
- deps: lock file maintenance npm packages (#5191) by @renovate[bot]
- deps: lock file maintenance (#5193) by @renovate[bot]
- deps: lock file maintenance rust crates (#5192) by @renovate[bot]
- deps: update github-actions (#5190) by @renovate[bot]
- test: remove unnecessary test snapshots (#5183) by @shulaoda
- rolldown: upgrade to NAPI-RS 3.0.0-beta.12 (#5184) by @Brooooooklyn

Co-authored-by: shulaoda <[email protected]>
graphite-app bot pushed a commit that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants