Skip to content

Comments

test(rust): automatically run extented test for minify_internal_exports: true#5213

Merged
IWANABETHATGUY merged 3 commits intomainfrom
07-09-test_rust_automatically_run_extented_test_for_minify_internal_exports_true_
Jul 8, 2025
Merged

test(rust): automatically run extented test for minify_internal_exports: true#5213
IWANABETHATGUY merged 3 commits intomainfrom
07-09-test_rust_automatically_run_extented_test_for_minify_internal_exports_true_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jul 8, 2025

When minify_internal_exports gets stablized in the future, we might remove this or change it to test minify_internal_exports: false automatically.

@hyf0 hyf0 marked this pull request as ready for review July 8, 2025 16:20
Copy link
Member Author

hyf0 commented Jul 8, 2025

@netlify
Copy link

netlify bot commented Jul 8, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 5d6016f
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/686d456670c86300088c5c13

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

Benchmarks Rust

  • target: main(0e46adc)
  • pr: 07-09-test_rust_automatically_run_extented_test_for_minify_internal_exports_true_(5d6016f)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     73.5±1.14ms        ? ?/sec    1.03     75.9±1.45ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     84.3±1.74ms        ? ?/sec    1.02     86.1±1.19ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    113.7±2.28ms        ? ?/sec    1.00    113.7±3.00ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    134.0±1.51ms        ? ?/sec    1.01    135.5±1.71ms        ? ?/sec
bundle/bundle@threejs                                        1.00     40.9±1.94ms        ? ?/sec    1.00     40.9±0.73ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     51.1±2.33ms        ? ?/sec    1.00     50.2±0.44ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    440.1±3.48ms        ? ?/sec    1.01    442.5±6.40ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    512.8±4.92ms        ? ?/sec    1.00    514.2±4.28ms        ? ?/sec
scan/scan@rome_ts                                            1.02     89.0±1.60ms        ? ?/sec    1.00     87.6±1.22ms        ? ?/sec
scan/scan@threejs                                            1.01     30.7±1.95ms        ? ?/sec    1.00     30.5±1.66ms        ? ?/sec
scan/scan@threejs10x                                         1.00    323.8±2.99ms        ? ?/sec    1.00    322.7±4.55ms        ? ?/sec

@hyf0 hyf0 requested a review from IWANABETHATGUY July 8, 2025 16:43
@hyf0 hyf0 changed the base branch from main to graphite-base/5213 July 8, 2025 16:54
@hyf0 hyf0 force-pushed the 07-09-test_rust_automatically_run_extented_test_for_minify_internal_exports_true_ branch from 5d6016f to 6b78f09 Compare July 8, 2025 16:54
@hyf0 hyf0 changed the base branch from graphite-base/5213 to 07-08-test_rust_add_basic_tests_for_minifying_internal_exports July 8, 2025 16:54
Base automatically changed from 07-08-test_rust_add_basic_tests_for_minifying_internal_exports to main July 8, 2025 17:32
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jul 8, 2025
Merged via the queue into main with commit 2b2acd4 Jul 8, 2025
29 of 33 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 07-09-test_rust_automatically_run_extented_test_for_minify_internal_exports_true_ branch July 8, 2025 17:39
IWANABETHATGUY pushed a commit that referenced this pull request Jul 10, 2025
## [1.0.0-beta.25] - 2025-07-10

### 🚀 Features

- hmr: should initialize cjs with correct initializer (#5234) by @hyf0
- hmr: handle `import(..)` on cjs modules (#5225) by @hyf0
- support `chunkModulesOrder`  (#5227) by @IWANABETHATGUY
- add `export`s to `rolldown:runtime` (#5224) by @hyf0
- hmr: support `import(..)` (#5223) by @hyf0
- add analyzed source code side effects field in ecmaMeta (#5226) by
@IWANABETHATGUY
- hmr: return `undefined` from `generateHmrPatch` when there is no patch
(#5218) by @sapphi-red
- pass `isEntry` to resolveId hook of CallableBuiltinPlugin (#5215) by
@sapphi-red
- pass `isEntry` from `this.resolve` (#5214) by @sapphi-red
- node: support `OutputOptions#minifyInternalExports` (#5210) by @hyf0
- rolldown: oxc v0.76.0 (#5212) by @Boshen
- rust: support `minify_internal_exports` (#5208) by @hyf0
- support opt-in `topLevelVar` (#5188) by @7086cmd
- rolldown: oxc-resolver v11.5.0 (yarn pnp) (#5147) by @Boshen

### 🐛 Bug Fixes

- do not optimize interop code for `mod.default` if mod bind from
default import (#5232) by @IWANABETHATGUY
- return `moduleSideEffects` instead of `sideEffects` from callable
plugins (#5206) by @sapphi-red
- return `moduleSideEffects` set by native plugins from `this.resolve`
(#5205) by @sapphi-red
- incorrect output when importing CJS package (#5201) by @IWANABETHATGUY
- use resolved id instead of module_request when analysis if a module is
a json module (#5200) by @IWANABETHATGUY

### 🚜 Refactor

- use `sort_unstable_by_key` for simple property access (#5233) by
@IWANABETHATGUY
- add Deref impl for TransformPluginContext to access PluginContext
(#5221) by @sapphi-red
- use `BindingHookSideEffects` in CallableBuiltinPlugin (#5204) by
@sapphi-red
- move side effects type bindings logic to rust side (#5203) by
@sapphi-red
- test: improve experience of writing manual integration test (#5186) by
@hyf0
- rust: unify logic of `IntegrationTest` (#5185) by @hyf0

### 🧪 Testing

- rust: automatically run extented test for `minify_internal_exports:
true` (#5213) by @hyf0
- rust: add basic tests for minifying internal exports (#5211) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: oxc-browserslist v2.0.10 and oxc-resolver v11.5.2 (#5222) by
@Boshen
- use jsonc schema for knip config (#5207) by @sapphi-red
- rust: remove unused code related to
`safe_cjs_to_eliminate_interop_default` (#5202) by @shulaoda
- inject test variant name to rust unit test script (#5195) by
@IWANABETHATGUY
- change CC => TARGET_CC (#5194) by @Brooooooklyn
- deps: lock file maintenance npm packages (#5191) by @renovate[bot]
- deps: lock file maintenance (#5193) by @renovate[bot]
- deps: lock file maintenance rust crates (#5192) by @renovate[bot]
- deps: update github-actions (#5190) by @renovate[bot]
- test: remove unnecessary test snapshots (#5183) by @shulaoda
- rolldown: upgrade to NAPI-RS 3.0.0-beta.12 (#5184) by @Brooooooklyn

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: minify internal exports

2 participants