Skip to content

Comments

feat(node): support OutputOptions#minifyInternalExports#5210

Merged
IWANABETHATGUY merged 1 commit intomainfrom
07-08-feat_node_support_outputoptions_minifyinternalexports_
Jul 8, 2025
Merged

feat(node): support OutputOptions#minifyInternalExports#5210
IWANABETHATGUY merged 1 commit intomainfrom
07-08-feat_node_support_outputoptions_minifyinternalexports_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jul 8, 2025

No description provided.

@hyf0 hyf0 marked this pull request as ready for review July 8, 2025 15:26
Copy link
Member Author

hyf0 commented Jul 8, 2025

@hyf0 hyf0 force-pushed the 07-08-feat_node_support_outputoptions_minifyinternalexports_ branch from 954d663 to 5970775 Compare July 8, 2025 15:26
@netlify
Copy link

netlify bot commented Jul 8, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 954d663
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/686d389c9bc0460008c94fed
😎 Deploy Preview https://deploy-preview-5210--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jul 8, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 5970775
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/686d38bc37070b00089d12a8
😎 Deploy Preview https://deploy-preview-5210--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

Benchmarks Rust

  • target: main(0e46adc)
  • pr: 07-08-feat_node_support_outputoptions_minifyinternalexports_(5970775)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     77.7±2.17ms        ? ?/sec    1.00     78.0±1.82ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     88.9±1.50ms        ? ?/sec    1.01     89.7±2.89ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    116.6±4.19ms        ? ?/sec    1.00    116.0±1.57ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    136.8±1.92ms        ? ?/sec    1.00    136.7±1.75ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.3±1.03ms        ? ?/sec    1.00     42.4±0.96ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     51.3±0.92ms        ? ?/sec    1.02     52.2±1.67ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    445.6±5.19ms        ? ?/sec    1.00    444.5±4.46ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    519.5±5.23ms        ? ?/sec    1.01    524.4±6.24ms        ? ?/sec
scan/scan@rome_ts                                            1.00     90.6±3.96ms        ? ?/sec    1.03     93.4±4.85ms        ? ?/sec
scan/scan@threejs                                            1.00     31.8±1.79ms        ? ?/sec    1.02     32.3±0.55ms        ? ?/sec
scan/scan@threejs10x                                         1.00    327.9±4.12ms        ? ?/sec    1.00    328.8±3.78ms        ? ?/sec

@hyf0 hyf0 added this pull request to the merge queue Jul 8, 2025
@hyf0 hyf0 removed this pull request from the merge queue due to a manual request Jul 8, 2025
@hyf0 hyf0 requested a review from IWANABETHATGUY July 8, 2025 16:51
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jul 8, 2025
Merged via the queue into main with commit cf09f46 Jul 8, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 07-08-feat_node_support_outputoptions_minifyinternalexports_ branch July 8, 2025 17:25
IWANABETHATGUY pushed a commit that referenced this pull request Jul 10, 2025
## [1.0.0-beta.25] - 2025-07-10

### 🚀 Features

- hmr: should initialize cjs with correct initializer (#5234) by @hyf0
- hmr: handle `import(..)` on cjs modules (#5225) by @hyf0
- support `chunkModulesOrder`  (#5227) by @IWANABETHATGUY
- add `export`s to `rolldown:runtime` (#5224) by @hyf0
- hmr: support `import(..)` (#5223) by @hyf0
- add analyzed source code side effects field in ecmaMeta (#5226) by
@IWANABETHATGUY
- hmr: return `undefined` from `generateHmrPatch` when there is no patch
(#5218) by @sapphi-red
- pass `isEntry` to resolveId hook of CallableBuiltinPlugin (#5215) by
@sapphi-red
- pass `isEntry` from `this.resolve` (#5214) by @sapphi-red
- node: support `OutputOptions#minifyInternalExports` (#5210) by @hyf0
- rolldown: oxc v0.76.0 (#5212) by @Boshen
- rust: support `minify_internal_exports` (#5208) by @hyf0
- support opt-in `topLevelVar` (#5188) by @7086cmd
- rolldown: oxc-resolver v11.5.0 (yarn pnp) (#5147) by @Boshen

### 🐛 Bug Fixes

- do not optimize interop code for `mod.default` if mod bind from
default import (#5232) by @IWANABETHATGUY
- return `moduleSideEffects` instead of `sideEffects` from callable
plugins (#5206) by @sapphi-red
- return `moduleSideEffects` set by native plugins from `this.resolve`
(#5205) by @sapphi-red
- incorrect output when importing CJS package (#5201) by @IWANABETHATGUY
- use resolved id instead of module_request when analysis if a module is
a json module (#5200) by @IWANABETHATGUY

### 🚜 Refactor

- use `sort_unstable_by_key` for simple property access (#5233) by
@IWANABETHATGUY
- add Deref impl for TransformPluginContext to access PluginContext
(#5221) by @sapphi-red
- use `BindingHookSideEffects` in CallableBuiltinPlugin (#5204) by
@sapphi-red
- move side effects type bindings logic to rust side (#5203) by
@sapphi-red
- test: improve experience of writing manual integration test (#5186) by
@hyf0
- rust: unify logic of `IntegrationTest` (#5185) by @hyf0

### 🧪 Testing

- rust: automatically run extented test for `minify_internal_exports:
true` (#5213) by @hyf0
- rust: add basic tests for minifying internal exports (#5211) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: oxc-browserslist v2.0.10 and oxc-resolver v11.5.2 (#5222) by
@Boshen
- use jsonc schema for knip config (#5207) by @sapphi-red
- rust: remove unused code related to
`safe_cjs_to_eliminate_interop_default` (#5202) by @shulaoda
- inject test variant name to rust unit test script (#5195) by
@IWANABETHATGUY
- change CC => TARGET_CC (#5194) by @Brooooooklyn
- deps: lock file maintenance npm packages (#5191) by @renovate[bot]
- deps: lock file maintenance (#5193) by @renovate[bot]
- deps: lock file maintenance rust crates (#5192) by @renovate[bot]
- deps: update github-actions (#5190) by @renovate[bot]
- test: remove unnecessary test snapshots (#5183) by @shulaoda
- rolldown: upgrade to NAPI-RS 3.0.0-beta.12 (#5184) by @Brooooooklyn

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants