Skip to content

Comments

feat(rust): support minify_internal_exports#5208

Merged
hyf0 merged 2 commits intomainfrom
07-08-feat_rust_support_minify_internal_exports_
Jul 8, 2025
Merged

feat(rust): support minify_internal_exports#5208
hyf0 merged 2 commits intomainfrom
07-08-feat_rust_support_minify_internal_exports_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jul 8, 2025

Part of #4785.

@netlify
Copy link

netlify bot commented Jul 8, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 03cf7b7
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/686d35369a28720008c90b64

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

Benchmarks Rust

  • target: main(e6cbb01)
  • pr: 07-08-feat_rust_support_minify_internal_exports_(03cf7b7)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.04     79.1±3.06ms        ? ?/sec    1.00     76.2±2.02ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     87.8±2.74ms        ? ?/sec    1.00     86.6±1.88ms        ? ?/sec
bundle/bundle@rome_ts                                        1.05    118.5±4.41ms        ? ?/sec    1.00    113.3±1.87ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.03    137.5±2.88ms        ? ?/sec    1.00    133.7±2.30ms        ? ?/sec
bundle/bundle@threejs                                        1.03     43.1±3.21ms        ? ?/sec    1.00     41.7±0.98ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     51.8±1.62ms        ? ?/sec    1.00     50.9±0.89ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    442.5±5.56ms        ? ?/sec    1.00    439.7±8.62ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    516.4±4.10ms        ? ?/sec    1.00    512.6±4.80ms        ? ?/sec
scan/scan@rome_ts                                            1.03     91.5±1.44ms        ? ?/sec    1.00     89.0±1.44ms        ? ?/sec
scan/scan@threejs                                            1.00     31.4±0.62ms        ? ?/sec    1.00     31.5±2.12ms        ? ?/sec
scan/scan@threejs10x                                         1.01    328.4±5.26ms        ? ?/sec    1.00    325.0±4.21ms        ? ?/sec

@hyf0 hyf0 enabled auto-merge July 8, 2025 10:52
@hyf0 hyf0 force-pushed the 07-08-feat_rust_support_minify_internal_exports_ branch from 4515a8c to 03cf7b7 Compare July 8, 2025 14:56
Copy link
Member Author

hyf0 commented Jul 8, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 added this pull request to the merge queue Jul 8, 2025
Merged via the queue into main with commit 0e46adc Jul 8, 2025
23 checks passed
@hyf0 hyf0 deleted the 07-08-feat_rust_support_minify_internal_exports_ branch July 8, 2025 15:19
IWANABETHATGUY pushed a commit that referenced this pull request Jul 10, 2025
## [1.0.0-beta.25] - 2025-07-10

### 🚀 Features

- hmr: should initialize cjs with correct initializer (#5234) by @hyf0
- hmr: handle `import(..)` on cjs modules (#5225) by @hyf0
- support `chunkModulesOrder`  (#5227) by @IWANABETHATGUY
- add `export`s to `rolldown:runtime` (#5224) by @hyf0
- hmr: support `import(..)` (#5223) by @hyf0
- add analyzed source code side effects field in ecmaMeta (#5226) by
@IWANABETHATGUY
- hmr: return `undefined` from `generateHmrPatch` when there is no patch
(#5218) by @sapphi-red
- pass `isEntry` to resolveId hook of CallableBuiltinPlugin (#5215) by
@sapphi-red
- pass `isEntry` from `this.resolve` (#5214) by @sapphi-red
- node: support `OutputOptions#minifyInternalExports` (#5210) by @hyf0
- rolldown: oxc v0.76.0 (#5212) by @Boshen
- rust: support `minify_internal_exports` (#5208) by @hyf0
- support opt-in `topLevelVar` (#5188) by @7086cmd
- rolldown: oxc-resolver v11.5.0 (yarn pnp) (#5147) by @Boshen

### 🐛 Bug Fixes

- do not optimize interop code for `mod.default` if mod bind from
default import (#5232) by @IWANABETHATGUY
- return `moduleSideEffects` instead of `sideEffects` from callable
plugins (#5206) by @sapphi-red
- return `moduleSideEffects` set by native plugins from `this.resolve`
(#5205) by @sapphi-red
- incorrect output when importing CJS package (#5201) by @IWANABETHATGUY
- use resolved id instead of module_request when analysis if a module is
a json module (#5200) by @IWANABETHATGUY

### 🚜 Refactor

- use `sort_unstable_by_key` for simple property access (#5233) by
@IWANABETHATGUY
- add Deref impl for TransformPluginContext to access PluginContext
(#5221) by @sapphi-red
- use `BindingHookSideEffects` in CallableBuiltinPlugin (#5204) by
@sapphi-red
- move side effects type bindings logic to rust side (#5203) by
@sapphi-red
- test: improve experience of writing manual integration test (#5186) by
@hyf0
- rust: unify logic of `IntegrationTest` (#5185) by @hyf0

### 🧪 Testing

- rust: automatically run extented test for `minify_internal_exports:
true` (#5213) by @hyf0
- rust: add basic tests for minifying internal exports (#5211) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: oxc-browserslist v2.0.10 and oxc-resolver v11.5.2 (#5222) by
@Boshen
- use jsonc schema for knip config (#5207) by @sapphi-red
- rust: remove unused code related to
`safe_cjs_to_eliminate_interop_default` (#5202) by @shulaoda
- inject test variant name to rust unit test script (#5195) by
@IWANABETHATGUY
- change CC => TARGET_CC (#5194) by @Brooooooklyn
- deps: lock file maintenance npm packages (#5191) by @renovate[bot]
- deps: lock file maintenance (#5193) by @renovate[bot]
- deps: lock file maintenance rust crates (#5192) by @renovate[bot]
- deps: update github-actions (#5190) by @renovate[bot]
- test: remove unnecessary test snapshots (#5183) by @shulaoda
- rolldown: upgrade to NAPI-RS 3.0.0-beta.12 (#5184) by @Brooooooklyn

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants