Skip to content

Comments

chore(rust): remove unused code related to safe_cjs_to_eliminate_interop_default#5202

Merged
shulaoda merged 1 commit intomainfrom
07-08-chore_rust_remove_unused_code_related_to_safe_cjs_to_eliminate_interop_default
Jul 8, 2025
Merged

chore(rust): remove unused code related to safe_cjs_to_eliminate_interop_default#5202
shulaoda merged 1 commit intomainfrom
07-08-chore_rust_remove_unused_code_related_to_safe_cjs_to_eliminate_interop_default

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jul 7, 2025

safe_cjs_to_eliminate_interop_default is no longer used due to the changes introduced in #5142.

Copy link
Member Author

shulaoda commented Jul 7, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jul 7, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 25b8667
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/686c7afe6e00750008f4237d

@shulaoda shulaoda changed the title chore(rust): remove unused code related to safe_cjs_to_eliminate_interop_default chore(rust): remove unused code related to safe_cjs_to_eliminate_interop_default Jul 7, 2025
@shulaoda shulaoda requested a review from IWANABETHATGUY July 7, 2025 16:05
@shulaoda shulaoda marked this pull request as ready for review July 7, 2025 16:06
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Benchmarks Rust

  • target: main(5d60b88)
  • pr: 07-08-chore_rust_remove_unused_code_related_to_safe_cjs_to_eliminate_interop_default(25b8667)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     80.7±2.11ms        ? ?/sec    1.03     83.2±4.49ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     91.8±1.71ms        ? ?/sec    1.03     94.2±2.10ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    120.6±4.04ms        ? ?/sec    1.00    120.8±2.23ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    138.2±2.35ms        ? ?/sec    1.03    142.2±2.64ms        ? ?/sec
bundle/bundle@threejs                                        1.00     44.2±3.16ms        ? ?/sec    1.05     46.3±2.57ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     53.0±1.51ms        ? ?/sec    1.02     54.0±1.18ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    454.4±4.75ms        ? ?/sec    1.01    459.4±6.06ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    529.8±3.99ms        ? ?/sec    1.01    535.5±8.34ms        ? ?/sec
scan/scan@rome_ts                                            1.00     92.0±1.81ms        ? ?/sec    1.03     94.9±1.62ms        ? ?/sec
scan/scan@threejs                                            1.00     32.2±1.83ms        ? ?/sec    1.02     32.9±1.78ms        ? ?/sec
scan/scan@threejs10x                                         1.00    334.9±4.39ms        ? ?/sec    1.01    339.0±3.73ms        ? ?/sec

@shulaoda shulaoda force-pushed the 07-08-chore_rust_remove_unused_code_related_to_safe_cjs_to_eliminate_interop_default branch from 23d9ac0 to 25b8667 Compare July 8, 2025 01:57
@shulaoda shulaoda added this pull request to the merge queue Jul 8, 2025
Merged via the queue into main with commit 24a8b5b Jul 8, 2025
23 checks passed
@shulaoda shulaoda deleted the 07-08-chore_rust_remove_unused_code_related_to_safe_cjs_to_eliminate_interop_default branch July 8, 2025 02:11
IWANABETHATGUY pushed a commit that referenced this pull request Jul 10, 2025
## [1.0.0-beta.25] - 2025-07-10

### 🚀 Features

- hmr: should initialize cjs with correct initializer (#5234) by @hyf0
- hmr: handle `import(..)` on cjs modules (#5225) by @hyf0
- support `chunkModulesOrder`  (#5227) by @IWANABETHATGUY
- add `export`s to `rolldown:runtime` (#5224) by @hyf0
- hmr: support `import(..)` (#5223) by @hyf0
- add analyzed source code side effects field in ecmaMeta (#5226) by
@IWANABETHATGUY
- hmr: return `undefined` from `generateHmrPatch` when there is no patch
(#5218) by @sapphi-red
- pass `isEntry` to resolveId hook of CallableBuiltinPlugin (#5215) by
@sapphi-red
- pass `isEntry` from `this.resolve` (#5214) by @sapphi-red
- node: support `OutputOptions#minifyInternalExports` (#5210) by @hyf0
- rolldown: oxc v0.76.0 (#5212) by @Boshen
- rust: support `minify_internal_exports` (#5208) by @hyf0
- support opt-in `topLevelVar` (#5188) by @7086cmd
- rolldown: oxc-resolver v11.5.0 (yarn pnp) (#5147) by @Boshen

### 🐛 Bug Fixes

- do not optimize interop code for `mod.default` if mod bind from
default import (#5232) by @IWANABETHATGUY
- return `moduleSideEffects` instead of `sideEffects` from callable
plugins (#5206) by @sapphi-red
- return `moduleSideEffects` set by native plugins from `this.resolve`
(#5205) by @sapphi-red
- incorrect output when importing CJS package (#5201) by @IWANABETHATGUY
- use resolved id instead of module_request when analysis if a module is
a json module (#5200) by @IWANABETHATGUY

### 🚜 Refactor

- use `sort_unstable_by_key` for simple property access (#5233) by
@IWANABETHATGUY
- add Deref impl for TransformPluginContext to access PluginContext
(#5221) by @sapphi-red
- use `BindingHookSideEffects` in CallableBuiltinPlugin (#5204) by
@sapphi-red
- move side effects type bindings logic to rust side (#5203) by
@sapphi-red
- test: improve experience of writing manual integration test (#5186) by
@hyf0
- rust: unify logic of `IntegrationTest` (#5185) by @hyf0

### 🧪 Testing

- rust: automatically run extented test for `minify_internal_exports:
true` (#5213) by @hyf0
- rust: add basic tests for minifying internal exports (#5211) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: oxc-browserslist v2.0.10 and oxc-resolver v11.5.2 (#5222) by
@Boshen
- use jsonc schema for knip config (#5207) by @sapphi-red
- rust: remove unused code related to
`safe_cjs_to_eliminate_interop_default` (#5202) by @shulaoda
- inject test variant name to rust unit test script (#5195) by
@IWANABETHATGUY
- change CC => TARGET_CC (#5194) by @Brooooooklyn
- deps: lock file maintenance npm packages (#5191) by @renovate[bot]
- deps: lock file maintenance (#5193) by @renovate[bot]
- deps: lock file maintenance rust crates (#5192) by @renovate[bot]
- deps: update github-actions (#5190) by @renovate[bot]
- test: remove unnecessary test snapshots (#5183) by @shulaoda
- rolldown: upgrade to NAPI-RS 3.0.0-beta.12 (#5184) by @Brooooooklyn

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants