Skip to content

Comments

chore(rolldown_testing): avoid unnecessary snapshots#5181

Merged
shulaoda merged 1 commit intomainfrom
07-05-feat_rolldown_testing_avoid_unnecessary_snapshots
Jul 5, 2025
Merged

chore(rolldown_testing): avoid unnecessary snapshots#5181
shulaoda merged 1 commit intomainfrom
07-05-feat_rolldown_testing_avoid_unnecessary_snapshots

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jul 5, 2025

Related to #5134

@shulaoda shulaoda changed the title feat(rolldown_testing): avoid unnecessary snapshots chore(rolldown_testing): avoid unnecessary snapshots Jul 5, 2025
Copy link
Member Author

shulaoda commented Jul 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jul 5, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 38d3c46
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6868de010b169900089c9f31

@shulaoda shulaoda requested review from IWANABETHATGUY and hyf0 July 5, 2025 08:07
@shulaoda shulaoda marked this pull request as ready for review July 5, 2025 08:08
@shulaoda shulaoda force-pushed the 07-05-feat_rolldown_testing_avoid_unnecessary_snapshots branch from 743944f to 38d3c46 Compare July 5, 2025 08:10
@shulaoda shulaoda added this pull request to the merge queue Jul 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2025

Benchmarks Rust

  • target: main(7bbd8bb)
  • pr: 07-05-feat_rolldown_testing_avoid_unnecessary_snapshots(38d3c46)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     75.8±2.53ms        ? ?/sec    1.01     76.9±2.05ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     86.3±1.30ms        ? ?/sec    1.01     87.2±1.43ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    116.2±3.88ms        ? ?/sec    1.00    114.0±1.42ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    135.0±2.80ms        ? ?/sec    1.00    134.7±1.61ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.3±0.89ms        ? ?/sec    1.00     41.3±0.94ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     50.9±0.87ms        ? ?/sec    1.00     50.7±0.75ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    443.1±4.73ms        ? ?/sec    1.00    443.4±5.97ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    517.5±2.85ms        ? ?/sec    1.01    521.9±7.97ms        ? ?/sec
scan/scan@rome_ts                                            1.00     89.4±1.34ms        ? ?/sec    1.03     92.4±2.28ms        ? ?/sec
scan/scan@threejs                                            1.00     31.4±2.01ms        ? ?/sec    1.02     31.9±1.87ms        ? ?/sec
scan/scan@threejs10x                                         1.00    327.6±4.70ms        ? ?/sec    1.02    333.8±4.94ms        ? ?/sec

Merged via the queue into main with commit c969c30 Jul 5, 2025
23 checks passed
@shulaoda shulaoda deleted the 07-05-feat_rolldown_testing_avoid_unnecessary_snapshots branch July 5, 2025 08:25
@github-actions github-actions bot mentioned this pull request Jul 5, 2025
hyf0 pushed a commit that referenced this pull request Jul 5, 2025
## [1.0.0-beta.24] - 2025-07-05

### 🚀 Features

- support `inlineConst` for imported variable (#5165) by @IWANABETHATGUY
- rust: skip transform hook for modules starts with `rolldown:` (#5169)
by @hyf0
- print rolldown version (#5163) by @btea
- add optimization.inlineConst option (#5164) by @IWANABETHATGUY
- hmr: introduce `rolldown_plugin_hmr` to inject runtime code (#5159) by
@hyf0
- rolldown: oxc v0.75.1 (#5157) by @Boshen

### 🐛 Bug Fixes

- generate correct CSS filename in `preserveModules` mode (#5175) by
@shulaoda
- rolldown_plugin_build_import_analysis: avoid `default` keyword error
(#5166) by @shulaoda
- watch: add paths to watcher in batch (#5068) by @branchseer
- debug: should emit chunk data after computing cross chunk links
(#5156) by @hyf0
- simplify commonjs interop `default` prop optimization (#5142) by
@IWANABETHATGUY
- should include modules contain `exports * from '...'` forcefully if
they reexport any wrapped module (#5143) by @hyf0
- use canonical runtime time for `__name` (#5140) by @IWANABETHATGUY
- `options.jsx` is ignored when `options.transform` is set (#5137) by
@shulaoda

### 🚜 Refactor

- polyfill `flatten_iter` for wasm target (#5180) by @IWANABETHATGUY
- rolldown_plugin_dynamic_import_vars: remove unnecessary validity
checks (#5172) by @shulaoda
- hmr: remove hmr-related hacky hard-code (#5168) by @hyf0
- rolldown_plugin_dynamic_import_vars: align with rolldown-vite (#5171)
by @shulaoda
- hmr: use `rolldown:hmr` to load hmr runtime code (#5162) by @hyf0
- rust: remove special fields of `Asset` (#5155) by @hyf0
- rust: make `Asset#originate_from` optional (#5153) by @hyf0
- rust: isolate mutations on assets data (#5152) by @hyf0
- rust: remove unnecessary usage of index vec on assets (#5151) by @hyf0
- merge different member expr in `try_rewrite_member_expr` (#5146) by
@IWANABETHATGUY
- remove unused code (#5144) by @IWANABETHATGUY
- use `self.result.ast_usage` directly (#5135) by @IWANABETHATGUY

### 📚 Documentation

- update syntax lowering transform info (#5145) by @TheAlexLichter

### 🧪 Testing

- rust/hmr: hide hmr runtime code in snapshots (#5160) by @hyf0

### ⚙️ Miscellaneous Tasks

- rolldown_testing: avoid unnecessary snapshots (#5181) by @shulaoda
- fix `flatten_iter` compile error (#5179) by @IWANABETHATGUY
- expose `optimization.inlineConst` option (#5177) by @IWANABETHATGUY
- infra: update `pnpm-lock.yaml` (#5178) by @shulaoda
- rust: remove unnecessary crate `rolldown_loader_utils` (#5173) by
@shulaoda
- print build time use green color (#5158) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5148) by
@renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5138) by
@renovate[bot]
- allow only test without generate snapshot (#5134) by @IWANABETHATGUY

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants