Skip to content

Comments

refactor(rolldown_plugin_dynamic_import_vars): align with rolldown-vite#5171

Merged
shulaoda merged 1 commit intomainfrom
07-05-refactor_rolldown_plugin_dynamic_import_vars_align_with_rolldown-vite
Jul 5, 2025
Merged

refactor(rolldown_plugin_dynamic_import_vars): align with rolldown-vite#5171
shulaoda merged 1 commit intomainfrom
07-05-refactor_rolldown_plugin_dynamic_import_vars_align_with_rolldown-vite

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jul 4, 2025 •
edited
Loading

Refactored the logic to fix edge cases in rolldown-vite test cases and adopted a new structure to avoid unnecessary AST traversal.

@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Jul 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jul 4, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 06fd44b
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68685e722e97fa00083aedff
😎 Deploy Preview https://deploy-preview-5171--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shulaoda shulaoda marked this pull request as ready for review July 4, 2025 23:01
@shulaoda shulaoda marked this pull request as draft July 4, 2025 23:02
@shulaoda shulaoda force-pushed the 07-05-refactor_rolldown_plugin_dynamic_import_vars_align_with_rolldown-vite branch from 0237f31 to 06fd44b Compare July 4, 2025 23:06
@shulaoda shulaoda marked this pull request as ready for review July 4, 2025 23:07
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

Benchmarks Rust

  • target: main(10eeb95)
  • pr: 07-05-refactor_rolldown_plugin_dynamic_import_vars_align_with_rolldown-vite(06fd44b)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     76.1±1.69ms        ? ?/sec    1.02     77.4±2.40ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     88.1±2.76ms        ? ?/sec    1.00     87.2±1.39ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    115.8±2.62ms        ? ?/sec    1.00    114.3±1.72ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    134.7±1.55ms        ? ?/sec    1.00    134.9±1.88ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.7±2.35ms        ? ?/sec    1.02     42.5±1.72ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     51.3±2.01ms        ? ?/sec    1.00     50.9±0.75ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    443.6±4.33ms        ? ?/sec    1.00    442.0±5.28ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    517.0±3.76ms        ? ?/sec    1.00    513.2±4.66ms        ? ?/sec
scan/scan@rome_ts                                            1.00     89.1±1.70ms        ? ?/sec    1.01     90.0±1.81ms        ? ?/sec
scan/scan@threejs                                            1.00     30.8±0.74ms        ? ?/sec    1.01     31.1±0.57ms        ? ?/sec
scan/scan@threejs10x                                         1.00    326.7±3.71ms        ? ?/sec    1.02    333.6±6.61ms        ? ?/sec

@shulaoda shulaoda mentioned this pull request Jul 5, 2025
Merged
@shulaoda shulaoda added this pull request to the merge queue Jul 5, 2025
Merged via the queue into main with commit 333c21b Jul 5, 2025
23 checks passed
@shulaoda shulaoda deleted the 07-05-refactor_rolldown_plugin_dynamic_import_vars_align_with_rolldown-vite branch July 5, 2025 04:23
@github-actions github-actions bot mentioned this pull request Jul 5, 2025
Merged
hyf0 pushed a commit that referenced this pull request Jul 5, 2025
@github-actions @shulaoda
release: v1.0.0-beta.24 (#5182)
2c9c25c 
## [1.0.0-beta.24] - 2025-07-05

### 🚀 Features

- support `inlineConst` for imported variable (#5165) by @IWANABETHATGUY
- rust: skip transform hook for modules starts with `rolldown:` (#5169)
by @hyf0
- print rolldown version (#5163) by @btea
- add optimization.inlineConst option (#5164) by @IWANABETHATGUY
- hmr: introduce `rolldown_plugin_hmr` to inject runtime code (#5159) by
@hyf0
- rolldown: oxc v0.75.1 (#5157) by @Boshen

### 🐛 Bug Fixes

- generate correct CSS filename in `preserveModules` mode (#5175) by
@shulaoda
- rolldown_plugin_build_import_analysis: avoid `default` keyword error
(#5166) by @shulaoda
- watch: add paths to watcher in batch (#5068) by @branchseer
- debug: should emit chunk data after computing cross chunk links
(#5156) by @hyf0
- simplify commonjs interop `default` prop optimization (#5142) by
@IWANABETHATGUY
- should include modules contain `exports * from '...'` forcefully if
they reexport any wrapped module (#5143) by @hyf0
- use canonical runtime time for `__name` (#5140) by @IWANABETHATGUY
- `options.jsx` is ignored when `options.transform` is set (#5137) by
@shulaoda

### 🚜 Refactor

- polyfill `flatten_iter` for wasm target (#5180) by @IWANABETHATGUY
- rolldown_plugin_dynamic_import_vars: remove unnecessary validity
checks (#5172) by @shulaoda
- hmr: remove hmr-related hacky hard-code (#5168) by @hyf0
- rolldown_plugin_dynamic_import_vars: align with rolldown-vite (#5171)
by @shulaoda
- hmr: use `rolldown:hmr` to load hmr runtime code (#5162) by @hyf0
- rust: remove special fields of `Asset` (#5155) by @hyf0
- rust: make `Asset#originate_from` optional (#5153) by @hyf0
- rust: isolate mutations on assets data (#5152) by @hyf0
- rust: remove unnecessary usage of index vec on assets (#5151) by @hyf0
- merge different member expr in `try_rewrite_member_expr` (#5146) by
@IWANABETHATGUY
- remove unused code (#5144) by @IWANABETHATGUY
- use `self.result.ast_usage` directly (#5135) by @IWANABETHATGUY

### 📚 Documentation

- update syntax lowering transform info (#5145) by @TheAlexLichter

### 🧪 Testing

- rust/hmr: hide hmr runtime code in snapshots (#5160) by @hyf0

### ⚙️ Miscellaneous Tasks

- rolldown_testing: avoid unnecessary snapshots (#5181) by @shulaoda
- fix `flatten_iter` compile error (#5179) by @IWANABETHATGUY
- expose `optimization.inlineConst` option (#5177) by @IWANABETHATGUY
- infra: update `pnpm-lock.yaml` (#5178) by @shulaoda
- rust: remove unnecessary crate `rolldown_loader_utils` (#5173) by
@shulaoda
- print build time use green color (#5158) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5148) by
@renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5138) by
@renovate[bot]
- allow only test without generate snapshot (#5134) by @IWANABETHATGUY

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shulaoda @IWANABETHATGUY