Skip to content

Comments

fix(rolldown_plugin_build_import_analysis): avoid default keyword error#5166

Merged
shulaoda merged 1 commit intomainfrom
07-04-fix_rolldown_plugin_build_import_analysis_avoid_default_keyword_error
Jul 4, 2025
Merged

fix(rolldown_plugin_build_import_analysis): avoid default keyword error#5166
shulaoda merged 1 commit intomainfrom
07-04-fix_rolldown_plugin_build_import_analysis_avoid_default_keyword_error

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jul 4, 2025

Should be const { default: __vite_default__ } = instead of const { __vite_default__ } =

Copy link
Member Author

shulaoda commented Jul 4, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 29605e6
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6867b04ebd3fdd0009a23cf6
😎 Deploy Preview https://deploy-preview-5166--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shulaoda shulaoda changed the title fix(rolldown_plugin_build_import_analysis): avoid default keyword error fix(rolldown_plugin_build_import_analysis): avoid default keyword error Jul 4, 2025
@shulaoda shulaoda marked this pull request as ready for review July 4, 2025 10:44
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

Benchmarks Rust

  • target: main(c634a8b)
  • pr: 07-04-fix_rolldown_plugin_build_import_analysis_avoid_default_keyword_error(29605e6)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     77.0±2.20ms        ? ?/sec    1.01     77.7±1.69ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     88.4±2.21ms        ? ?/sec    1.00     88.3±1.79ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    117.2±4.29ms        ? ?/sec    1.00    116.5±2.83ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    137.1±2.41ms        ? ?/sec    1.00    137.3±1.90ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.8±2.84ms        ? ?/sec    1.01     42.0±1.03ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     51.1±0.97ms        ? ?/sec    1.01     51.8±0.99ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    445.4±6.50ms        ? ?/sec    1.00    447.5±6.64ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    521.2±6.34ms        ? ?/sec    1.01    525.2±6.39ms        ? ?/sec
scan/scan@rome_ts                                            1.00     92.1±1.96ms        ? ?/sec    1.01     92.8±2.24ms        ? ?/sec
scan/scan@threejs                                            1.00     30.7±0.40ms        ? ?/sec    1.00     30.6±0.50ms        ? ?/sec
scan/scan@threejs10x                                         1.00    332.5±4.61ms        ? ?/sec    1.00    330.9±3.55ms        ? ?/sec

@shulaoda shulaoda added this pull request to the merge queue Jul 4, 2025
Merged via the queue into main with commit 3969388 Jul 4, 2025
27 checks passed
@shulaoda shulaoda deleted the 07-04-fix_rolldown_plugin_build_import_analysis_avoid_default_keyword_error branch July 4, 2025 11:31
@github-actions github-actions bot mentioned this pull request Jul 5, 2025
hyf0 pushed a commit that referenced this pull request Jul 5, 2025
## [1.0.0-beta.24] - 2025-07-05

### 🚀 Features

- support `inlineConst` for imported variable (#5165) by @IWANABETHATGUY
- rust: skip transform hook for modules starts with `rolldown:` (#5169)
by @hyf0
- print rolldown version (#5163) by @btea
- add optimization.inlineConst option (#5164) by @IWANABETHATGUY
- hmr: introduce `rolldown_plugin_hmr` to inject runtime code (#5159) by
@hyf0
- rolldown: oxc v0.75.1 (#5157) by @Boshen

### 🐛 Bug Fixes

- generate correct CSS filename in `preserveModules` mode (#5175) by
@shulaoda
- rolldown_plugin_build_import_analysis: avoid `default` keyword error
(#5166) by @shulaoda
- watch: add paths to watcher in batch (#5068) by @branchseer
- debug: should emit chunk data after computing cross chunk links
(#5156) by @hyf0
- simplify commonjs interop `default` prop optimization (#5142) by
@IWANABETHATGUY
- should include modules contain `exports * from '...'` forcefully if
they reexport any wrapped module (#5143) by @hyf0
- use canonical runtime time for `__name` (#5140) by @IWANABETHATGUY
- `options.jsx` is ignored when `options.transform` is set (#5137) by
@shulaoda

### 🚜 Refactor

- polyfill `flatten_iter` for wasm target (#5180) by @IWANABETHATGUY
- rolldown_plugin_dynamic_import_vars: remove unnecessary validity
checks (#5172) by @shulaoda
- hmr: remove hmr-related hacky hard-code (#5168) by @hyf0
- rolldown_plugin_dynamic_import_vars: align with rolldown-vite (#5171)
by @shulaoda
- hmr: use `rolldown:hmr` to load hmr runtime code (#5162) by @hyf0
- rust: remove special fields of `Asset` (#5155) by @hyf0
- rust: make `Asset#originate_from` optional (#5153) by @hyf0
- rust: isolate mutations on assets data (#5152) by @hyf0
- rust: remove unnecessary usage of index vec on assets (#5151) by @hyf0
- merge different member expr in `try_rewrite_member_expr` (#5146) by
@IWANABETHATGUY
- remove unused code (#5144) by @IWANABETHATGUY
- use `self.result.ast_usage` directly (#5135) by @IWANABETHATGUY

### 📚 Documentation

- update syntax lowering transform info (#5145) by @TheAlexLichter

### 🧪 Testing

- rust/hmr: hide hmr runtime code in snapshots (#5160) by @hyf0

### ⚙️ Miscellaneous Tasks

- rolldown_testing: avoid unnecessary snapshots (#5181) by @shulaoda
- fix `flatten_iter` compile error (#5179) by @IWANABETHATGUY
- expose `optimization.inlineConst` option (#5177) by @IWANABETHATGUY
- infra: update `pnpm-lock.yaml` (#5178) by @shulaoda
- rust: remove unnecessary crate `rolldown_loader_utils` (#5173) by
@shulaoda
- print build time use green color (#5158) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5148) by
@renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5138) by
@renovate[bot]
- allow only test without generate snapshot (#5134) by @IWANABETHATGUY

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants