Skip to content

Comments

feat: support inlineConst for imported variable#5165

Merged
IWANABETHATGUY merged 1 commit intomainfrom
feat-const-inline
Jul 5, 2025
Merged

feat: support inlineConst for imported variable#5165
IWANABETHATGUY merged 1 commit intomainfrom
feat-const-inline

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jul 4, 2025

Closed #4786

Copy link
Member Author

IWANABETHATGUY commented Jul 4, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY changed the title chore: 🤖 init feat: support inlineConst for imported variable Jul 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.04     81.8±2.96ms        ? ?/sec    1.00     79.0±2.42ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     89.9±2.46ms        ? ?/sec    1.00     89.0±2.11ms        ? ?/sec
bundle/bundle@rome_ts                                        1.08    125.2±5.47ms        ? ?/sec    1.00    115.6±1.77ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    136.2±2.34ms        ? ?/sec    1.00    135.9±1.94ms        ? ?/sec
bundle/bundle@threejs                                        1.13     47.7±0.93ms        ? ?/sec    1.00     42.4±2.50ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.11     57.1±2.34ms        ? ?/sec    1.00     51.6±0.78ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    445.4±6.35ms        ? ?/sec    1.02    453.8±7.40ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    521.4±6.19ms        ? ?/sec    1.00    514.5±6.69ms        ? ?/sec
scan/scan@rome_ts                                            1.01     91.2±1.92ms        ? ?/sec    1.00     90.6±1.54ms        ? ?/sec
scan/scan@threejs                                            1.02     31.7±0.67ms        ? ?/sec    1.00     31.1±0.46ms        ? ?/sec
scan/scan@threejs10x                                         1.01    329.7±5.22ms        ? ?/sec    1.00    327.5±4.71ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY force-pushed the 07-04-feat_add_optimization.inlineconst_option branch from 57dcb90 to 2887f9d Compare July 4, 2025 11:27
Base automatically changed from 07-04-feat_add_optimization.inlineconst_option to main July 4, 2025 11:55
@netlify
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 7f71ad4
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6868c493b9ea170008ca1f8a

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review July 5, 2025 06:26
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jul 5, 2025
Merged via the queue into main with commit f14d94b Jul 5, 2025
25 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the feat-const-inline branch July 5, 2025 06:50
@github-actions github-actions bot mentioned this pull request Jul 5, 2025
hyf0 pushed a commit that referenced this pull request Jul 5, 2025
## [1.0.0-beta.24] - 2025-07-05

### 🚀 Features

- support `inlineConst` for imported variable (#5165) by @IWANABETHATGUY
- rust: skip transform hook for modules starts with `rolldown:` (#5169)
by @hyf0
- print rolldown version (#5163) by @btea
- add optimization.inlineConst option (#5164) by @IWANABETHATGUY
- hmr: introduce `rolldown_plugin_hmr` to inject runtime code (#5159) by
@hyf0
- rolldown: oxc v0.75.1 (#5157) by @Boshen

### 🐛 Bug Fixes

- generate correct CSS filename in `preserveModules` mode (#5175) by
@shulaoda
- rolldown_plugin_build_import_analysis: avoid `default` keyword error
(#5166) by @shulaoda
- watch: add paths to watcher in batch (#5068) by @branchseer
- debug: should emit chunk data after computing cross chunk links
(#5156) by @hyf0
- simplify commonjs interop `default` prop optimization (#5142) by
@IWANABETHATGUY
- should include modules contain `exports * from '...'` forcefully if
they reexport any wrapped module (#5143) by @hyf0
- use canonical runtime time for `__name` (#5140) by @IWANABETHATGUY
- `options.jsx` is ignored when `options.transform` is set (#5137) by
@shulaoda

### 🚜 Refactor

- polyfill `flatten_iter` for wasm target (#5180) by @IWANABETHATGUY
- rolldown_plugin_dynamic_import_vars: remove unnecessary validity
checks (#5172) by @shulaoda
- hmr: remove hmr-related hacky hard-code (#5168) by @hyf0
- rolldown_plugin_dynamic_import_vars: align with rolldown-vite (#5171)
by @shulaoda
- hmr: use `rolldown:hmr` to load hmr runtime code (#5162) by @hyf0
- rust: remove special fields of `Asset` (#5155) by @hyf0
- rust: make `Asset#originate_from` optional (#5153) by @hyf0
- rust: isolate mutations on assets data (#5152) by @hyf0
- rust: remove unnecessary usage of index vec on assets (#5151) by @hyf0
- merge different member expr in `try_rewrite_member_expr` (#5146) by
@IWANABETHATGUY
- remove unused code (#5144) by @IWANABETHATGUY
- use `self.result.ast_usage` directly (#5135) by @IWANABETHATGUY

### 📚 Documentation

- update syntax lowering transform info (#5145) by @TheAlexLichter

### 🧪 Testing

- rust/hmr: hide hmr runtime code in snapshots (#5160) by @hyf0

### ⚙️ Miscellaneous Tasks

- rolldown_testing: avoid unnecessary snapshots (#5181) by @shulaoda
- fix `flatten_iter` compile error (#5179) by @IWANABETHATGUY
- expose `optimization.inlineConst` option (#5177) by @IWANABETHATGUY
- infra: update `pnpm-lock.yaml` (#5178) by @shulaoda
- rust: remove unnecessary crate `rolldown_loader_utils` (#5173) by
@shulaoda
- print build time use green color (#5158) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5148) by
@renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5138) by
@renovate[bot]
- allow only test without generate snapshot (#5134) by @IWANABETHATGUY

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: cross chunk dead code elimination depending on constant inlining / propagation

2 participants