Skip to content

Comments

refactor(hmr): use rolldown:hmr to load hmr runtime code#5162

Merged
hyf0 merged 1 commit intomainfrom
07-04-refactor_hmr_use_rolldown_hmr_to_load_hmr_runtime_code
Jul 5, 2025
Merged

refactor(hmr): use rolldown:hmr to load hmr runtime code#5162
hyf0 merged 1 commit intomainfrom
07-04-refactor_hmr_use_rolldown_hmr_to_load_hmr_runtime_code

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jul 4, 2025

I'll remove other hmr-related hard-code in the next PR.

@hyf0 hyf0 force-pushed the 07-04-refactor_hmr_use_rolldown_hmr_to_load_hmr_runtime_code branch from 2b90a30 to 5d40e54 Compare July 4, 2025 10:10
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

Benchmarks Rust

  • target: main(10eeb95)
  • pr: 07-04-refactor_hmr_use_rolldown_hmr_to_load_hmr_runtime_code(7e6dcd9)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     81.8±2.95ms        ? ?/sec    1.00     81.1±3.22ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     93.5±2.98ms        ? ?/sec    1.00     92.4±2.99ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    125.1±3.28ms        ? ?/sec    1.00    124.2±4.11ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    139.1±2.57ms        ? ?/sec    1.01    140.5±2.46ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.9±1.83ms        ? ?/sec    1.03     44.0±2.28ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     53.4±2.47ms        ? ?/sec    1.00     52.5±1.27ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    459.9±5.48ms        ? ?/sec    1.00    459.4±6.23ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    535.1±7.45ms        ? ?/sec    1.00    527.8±8.18ms        ? ?/sec
scan/scan@rome_ts                                            1.00     94.9±2.70ms        ? ?/sec    1.01     95.6±2.85ms        ? ?/sec
scan/scan@threejs                                            1.01     32.2±1.88ms        ? ?/sec    1.00     31.8±0.60ms        ? ?/sec
scan/scan@threejs10x                                         1.00    333.8±4.70ms        ? ?/sec    1.00    335.0±3.38ms        ? ?/sec

@graphite-app graphite-app bot changed the base branch from 07-04-test_rust_hmr_hide_hmr_runtime_code_in_snapshots to graphite-base/5162 July 4, 2025 10:25
@hyf0 hyf0 force-pushed the 07-04-refactor_hmr_use_rolldown_hmr_to_load_hmr_runtime_code branch from 5d40e54 to 2b70a0f Compare July 4, 2025 12:00
@hyf0 hyf0 force-pushed the graphite-base/5162 branch from 154515c to 10eeb95 Compare July 4, 2025 12:00
@graphite-app graphite-app bot changed the base branch from graphite-base/5162 to main July 4, 2025 12:01
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 4, 2025

Merge activity

  • Jul 4, 12:01 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Jul 4, 12:01 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@hyf0 hyf0 force-pushed the 07-04-refactor_hmr_use_rolldown_hmr_to_load_hmr_runtime_code branch from 2b70a0f to 8a07740 Compare July 4, 2025 15:08
@netlify
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 7e6dcd9
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6867efe182ef0800087b7a8c
😎 Deploy Preview https://deploy-preview-5162--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hyf0 hyf0 force-pushed the 07-04-refactor_hmr_use_rolldown_hmr_to_load_hmr_runtime_code branch from 8a07740 to 7e6dcd9 Compare July 4, 2025 15:14
@hyf0 hyf0 requested a review from IWANABETHATGUY July 4, 2025 15:46
@hyf0 hyf0 added this pull request to the merge queue Jul 5, 2025
Merged via the queue into main with commit 2e0a946 Jul 5, 2025
24 checks passed
@hyf0 hyf0 deleted the 07-04-refactor_hmr_use_rolldown_hmr_to_load_hmr_runtime_code branch July 5, 2025 04:19
@github-actions github-actions bot mentioned this pull request Jul 5, 2025
hyf0 pushed a commit that referenced this pull request Jul 5, 2025
## [1.0.0-beta.24] - 2025-07-05

### 🚀 Features

- support `inlineConst` for imported variable (#5165) by @IWANABETHATGUY
- rust: skip transform hook for modules starts with `rolldown:` (#5169)
by @hyf0
- print rolldown version (#5163) by @btea
- add optimization.inlineConst option (#5164) by @IWANABETHATGUY
- hmr: introduce `rolldown_plugin_hmr` to inject runtime code (#5159) by
@hyf0
- rolldown: oxc v0.75.1 (#5157) by @Boshen

### 🐛 Bug Fixes

- generate correct CSS filename in `preserveModules` mode (#5175) by
@shulaoda
- rolldown_plugin_build_import_analysis: avoid `default` keyword error
(#5166) by @shulaoda
- watch: add paths to watcher in batch (#5068) by @branchseer
- debug: should emit chunk data after computing cross chunk links
(#5156) by @hyf0
- simplify commonjs interop `default` prop optimization (#5142) by
@IWANABETHATGUY
- should include modules contain `exports * from '...'` forcefully if
they reexport any wrapped module (#5143) by @hyf0
- use canonical runtime time for `__name` (#5140) by @IWANABETHATGUY
- `options.jsx` is ignored when `options.transform` is set (#5137) by
@shulaoda

### 🚜 Refactor

- polyfill `flatten_iter` for wasm target (#5180) by @IWANABETHATGUY
- rolldown_plugin_dynamic_import_vars: remove unnecessary validity
checks (#5172) by @shulaoda
- hmr: remove hmr-related hacky hard-code (#5168) by @hyf0
- rolldown_plugin_dynamic_import_vars: align with rolldown-vite (#5171)
by @shulaoda
- hmr: use `rolldown:hmr` to load hmr runtime code (#5162) by @hyf0
- rust: remove special fields of `Asset` (#5155) by @hyf0
- rust: make `Asset#originate_from` optional (#5153) by @hyf0
- rust: isolate mutations on assets data (#5152) by @hyf0
- rust: remove unnecessary usage of index vec on assets (#5151) by @hyf0
- merge different member expr in `try_rewrite_member_expr` (#5146) by
@IWANABETHATGUY
- remove unused code (#5144) by @IWANABETHATGUY
- use `self.result.ast_usage` directly (#5135) by @IWANABETHATGUY

### 📚 Documentation

- update syntax lowering transform info (#5145) by @TheAlexLichter

### 🧪 Testing

- rust/hmr: hide hmr runtime code in snapshots (#5160) by @hyf0

### ⚙️ Miscellaneous Tasks

- rolldown_testing: avoid unnecessary snapshots (#5181) by @shulaoda
- fix `flatten_iter` compile error (#5179) by @IWANABETHATGUY
- expose `optimization.inlineConst` option (#5177) by @IWANABETHATGUY
- infra: update `pnpm-lock.yaml` (#5178) by @shulaoda
- rust: remove unnecessary crate `rolldown_loader_utils` (#5173) by
@shulaoda
- print build time use green color (#5158) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5148) by
@renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5138) by
@renovate[bot]
- allow only test without generate snapshot (#5134) by @IWANABETHATGUY

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants