Skip to content

Comments

refactor(rust): remove special fields of Asset#5155

Merged
hyf0 merged 2 commits intomainfrom
07-03-refactor_rust_remove_special_fields_of_asset_
Jul 3, 2025
Merged

refactor(rust): remove special fields of Asset#5155
hyf0 merged 2 commits intomainfrom
07-03-refactor_rust_remove_special_fields_of_asset_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jul 3, 2025

Asset should be a generic struct, domain-specific fields should be isolated to meta.

Copy link
Member Author

hyf0 commented Jul 3, 2025

@hyf0 hyf0 marked this pull request as ready for review July 3, 2025 10:19
@hyf0 hyf0 force-pushed the 07-03-refactor_rust_remove_special_fields_of_asset_ branch from fbf0588 to 3f618d6 Compare July 3, 2025 10:21
@graphite-app graphite-app bot changed the base branch from 07-03-refactor_rust_make_asset_originate_from_optional to graphite-base/5155 July 3, 2025 10:31
@hyf0 hyf0 force-pushed the 07-03-refactor_rust_remove_special_fields_of_asset_ branch from 3f618d6 to d2f7605 Compare July 3, 2025 10:31
@hyf0 hyf0 force-pushed the graphite-base/5155 branch from 7bf14d9 to 8ea9fdc Compare July 3, 2025 10:31
@hyf0 hyf0 changed the base branch from graphite-base/5155 to 07-03-refactor_rust_make_asset_originate_from_optional July 3, 2025 10:31
Base automatically changed from 07-03-refactor_rust_make_asset_originate_from_optional to main July 3, 2025 10:44
@hyf0 hyf0 added this pull request to the merge queue Jul 3, 2025
Merged via the queue into main with commit b37e4b4 Jul 3, 2025
22 of 30 checks passed
@hyf0 hyf0 deleted the 07-03-refactor_rust_remove_special_fields_of_asset_ branch July 3, 2025 10:50
@github-actions github-actions bot mentioned this pull request Jul 5, 2025
hyf0 pushed a commit that referenced this pull request Jul 5, 2025
## [1.0.0-beta.24] - 2025-07-05

### 🚀 Features

- support `inlineConst` for imported variable (#5165) by @IWANABETHATGUY
- rust: skip transform hook for modules starts with `rolldown:` (#5169)
by @hyf0
- print rolldown version (#5163) by @btea
- add optimization.inlineConst option (#5164) by @IWANABETHATGUY
- hmr: introduce `rolldown_plugin_hmr` to inject runtime code (#5159) by
@hyf0
- rolldown: oxc v0.75.1 (#5157) by @Boshen

### 🐛 Bug Fixes

- generate correct CSS filename in `preserveModules` mode (#5175) by
@shulaoda
- rolldown_plugin_build_import_analysis: avoid `default` keyword error
(#5166) by @shulaoda
- watch: add paths to watcher in batch (#5068) by @branchseer
- debug: should emit chunk data after computing cross chunk links
(#5156) by @hyf0
- simplify commonjs interop `default` prop optimization (#5142) by
@IWANABETHATGUY
- should include modules contain `exports * from '...'` forcefully if
they reexport any wrapped module (#5143) by @hyf0
- use canonical runtime time for `__name` (#5140) by @IWANABETHATGUY
- `options.jsx` is ignored when `options.transform` is set (#5137) by
@shulaoda

### 🚜 Refactor

- polyfill `flatten_iter` for wasm target (#5180) by @IWANABETHATGUY
- rolldown_plugin_dynamic_import_vars: remove unnecessary validity
checks (#5172) by @shulaoda
- hmr: remove hmr-related hacky hard-code (#5168) by @hyf0
- rolldown_plugin_dynamic_import_vars: align with rolldown-vite (#5171)
by @shulaoda
- hmr: use `rolldown:hmr` to load hmr runtime code (#5162) by @hyf0
- rust: remove special fields of `Asset` (#5155) by @hyf0
- rust: make `Asset#originate_from` optional (#5153) by @hyf0
- rust: isolate mutations on assets data (#5152) by @hyf0
- rust: remove unnecessary usage of index vec on assets (#5151) by @hyf0
- merge different member expr in `try_rewrite_member_expr` (#5146) by
@IWANABETHATGUY
- remove unused code (#5144) by @IWANABETHATGUY
- use `self.result.ast_usage` directly (#5135) by @IWANABETHATGUY

### 📚 Documentation

- update syntax lowering transform info (#5145) by @TheAlexLichter

### 🧪 Testing

- rust/hmr: hide hmr runtime code in snapshots (#5160) by @hyf0

### ⚙️ Miscellaneous Tasks

- rolldown_testing: avoid unnecessary snapshots (#5181) by @shulaoda
- fix `flatten_iter` compile error (#5179) by @IWANABETHATGUY
- expose `optimization.inlineConst` option (#5177) by @IWANABETHATGUY
- infra: update `pnpm-lock.yaml` (#5178) by @shulaoda
- rust: remove unnecessary crate `rolldown_loader_utils` (#5173) by
@shulaoda
- print build time use green color (#5158) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5148) by
@renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5138) by
@renovate[bot]
- allow only test without generate snapshot (#5134) by @IWANABETHATGUY

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants