Skip to content

Comments

refactor(rust): make Asset#originate_from optional#5153

Merged
hyf0 merged 1 commit intomainfrom
07-03-refactor_rust_make_asset_originate_from_optional
Jul 3, 2025
Merged

refactor(rust): make Asset#originate_from optional#5153
hyf0 merged 1 commit intomainfrom
07-03-refactor_rust_make_asset_originate_from_optional

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jul 3, 2025

No description provided.

@hyf0 hyf0 marked this pull request as ready for review July 3, 2025 09:56
Copy link
Member Author

hyf0 commented Jul 3, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

Benchmarks Rust

  • target: main(2680358)
  • pr: 07-03-refactor_rust_make_asset_originate_from_optional(8ea9fdc)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     79.6±2.69ms        ? ?/sec    1.03     82.3±2.84ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     90.1±2.97ms        ? ?/sec    1.00     89.5±3.16ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    115.5±4.04ms        ? ?/sec    1.00    115.6±2.48ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    136.8±3.81ms        ? ?/sec    1.00    134.9±2.58ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.5±2.37ms        ? ?/sec    1.02     42.3±1.07ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     52.1±4.20ms        ? ?/sec    1.00     51.6±1.17ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    437.9±6.30ms        ? ?/sec    1.00    438.4±6.35ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00   512.4±10.34ms        ? ?/sec    1.00   510.5±11.29ms        ? ?/sec
scan/scan@rome_ts                                            1.00     89.0±1.92ms        ? ?/sec    1.02     90.6±2.15ms        ? ?/sec
scan/scan@threejs                                            1.00     30.5±0.67ms        ? ?/sec    1.03     31.4±1.92ms        ? ?/sec
scan/scan@threejs10x                                         1.00    317.5±4.34ms        ? ?/sec    1.02    323.9±5.81ms        ? ?/sec

@graphite-app graphite-app bot changed the base branch from 07-03-refactor_rust_isolate_mutations_on_assets_data to graphite-base/5153 July 3, 2025 10:12
@hyf0 hyf0 force-pushed the graphite-base/5153 branch from 63b9fce to 6e2a72a Compare July 3, 2025 10:17
@hyf0 hyf0 force-pushed the 07-03-refactor_rust_make_asset_originate_from_optional branch from 0598b1e to 7bf14d9 Compare July 3, 2025 10:17
@hyf0 hyf0 changed the base branch from graphite-base/5153 to 07-03-refactor_rust_isolate_mutations_on_assets_data July 3, 2025 10:17
Base automatically changed from 07-03-refactor_rust_isolate_mutations_on_assets_data to main July 3, 2025 10:30
@hyf0 hyf0 force-pushed the 07-03-refactor_rust_make_asset_originate_from_optional branch from 7bf14d9 to 3c741cb Compare July 3, 2025 10:31
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 3, 2025

Merge activity

  • Jul 3, 10:31 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@hyf0 hyf0 force-pushed the 07-03-refactor_rust_make_asset_originate_from_optional branch from 3c741cb to 8ea9fdc Compare July 3, 2025 10:31
@netlify
Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 3c741cb
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68665bec5ca8a80008986284

@netlify
Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 8ea9fdc
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68665c0ed37a220008b36292

@hyf0 hyf0 added this pull request to the merge queue Jul 3, 2025
Merged via the queue into main with commit 023b5e9 Jul 3, 2025
23 checks passed
@hyf0 hyf0 deleted the 07-03-refactor_rust_make_asset_originate_from_optional branch July 3, 2025 10:44
@github-actions github-actions bot mentioned this pull request Jul 5, 2025
hyf0 pushed a commit that referenced this pull request Jul 5, 2025
## [1.0.0-beta.24] - 2025-07-05

### 🚀 Features

- support `inlineConst` for imported variable (#5165) by @IWANABETHATGUY
- rust: skip transform hook for modules starts with `rolldown:` (#5169)
by @hyf0
- print rolldown version (#5163) by @btea
- add optimization.inlineConst option (#5164) by @IWANABETHATGUY
- hmr: introduce `rolldown_plugin_hmr` to inject runtime code (#5159) by
@hyf0
- rolldown: oxc v0.75.1 (#5157) by @Boshen

### 🐛 Bug Fixes

- generate correct CSS filename in `preserveModules` mode (#5175) by
@shulaoda
- rolldown_plugin_build_import_analysis: avoid `default` keyword error
(#5166) by @shulaoda
- watch: add paths to watcher in batch (#5068) by @branchseer
- debug: should emit chunk data after computing cross chunk links
(#5156) by @hyf0
- simplify commonjs interop `default` prop optimization (#5142) by
@IWANABETHATGUY
- should include modules contain `exports * from '...'` forcefully if
they reexport any wrapped module (#5143) by @hyf0
- use canonical runtime time for `__name` (#5140) by @IWANABETHATGUY
- `options.jsx` is ignored when `options.transform` is set (#5137) by
@shulaoda

### 🚜 Refactor

- polyfill `flatten_iter` for wasm target (#5180) by @IWANABETHATGUY
- rolldown_plugin_dynamic_import_vars: remove unnecessary validity
checks (#5172) by @shulaoda
- hmr: remove hmr-related hacky hard-code (#5168) by @hyf0
- rolldown_plugin_dynamic_import_vars: align with rolldown-vite (#5171)
by @shulaoda
- hmr: use `rolldown:hmr` to load hmr runtime code (#5162) by @hyf0
- rust: remove special fields of `Asset` (#5155) by @hyf0
- rust: make `Asset#originate_from` optional (#5153) by @hyf0
- rust: isolate mutations on assets data (#5152) by @hyf0
- rust: remove unnecessary usage of index vec on assets (#5151) by @hyf0
- merge different member expr in `try_rewrite_member_expr` (#5146) by
@IWANABETHATGUY
- remove unused code (#5144) by @IWANABETHATGUY
- use `self.result.ast_usage` directly (#5135) by @IWANABETHATGUY

### 📚 Documentation

- update syntax lowering transform info (#5145) by @TheAlexLichter

### 🧪 Testing

- rust/hmr: hide hmr runtime code in snapshots (#5160) by @hyf0

### ⚙️ Miscellaneous Tasks

- rolldown_testing: avoid unnecessary snapshots (#5181) by @shulaoda
- fix `flatten_iter` compile error (#5179) by @IWANABETHATGUY
- expose `optimization.inlineConst` option (#5177) by @IWANABETHATGUY
- infra: update `pnpm-lock.yaml` (#5178) by @shulaoda
- rust: remove unnecessary crate `rolldown_loader_utils` (#5173) by
@shulaoda
- print build time use green color (#5158) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5148) by
@renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5138) by
@renovate[bot]
- allow only test without generate snapshot (#5134) by @IWANABETHATGUY

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants