refactor(rust): isolate mutations on assets data#5152
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hyf0
commented
Jul 3, 2025
hyf0
commented
Jul 3, 2025
Contributor
Benchmarks Rust |
Base automatically changed from
07-03-refactor_rust_remove_unnecessary_usage_of_index_vec_on_assets
to
main
July 3, 2025 10:12
hyf0
force-pushed
the
07-03-refactor_rust_isolate_mutations_on_assets_data
branch
from
63b9fce to
aec7809
Compare
✅ Deploy Preview for rolldown-rs canceled.
|
Contributor
Merge activity
|
hyf0
force-pushed
the
07-03-refactor_rust_isolate_mutations_on_assets_data
branch
from
aec7809 to
6e2a72a
Compare
hyf0
commented
Jul 3, 2025
hyf0
commented
Jul 3, 2025
IWANABETHATGUY
approved these changes
Jul 3, 2025
hyf0
pushed a commit
that referenced
this pull request
Jul 5, 2025
## [1.0.0-beta.24] - 2025-07-05 ### 🚀 Features - support `inlineConst` for imported variable (#5165) by @IWANABETHATGUY - rust: skip transform hook for modules starts with `rolldown:` (#5169) by @hyf0 - print rolldown version (#5163) by @btea - add optimization.inlineConst option (#5164) by @IWANABETHATGUY - hmr: introduce `rolldown_plugin_hmr` to inject runtime code (#5159) by @hyf0 - rolldown: oxc v0.75.1 (#5157) by @Boshen ### 🐛 Bug Fixes - generate correct CSS filename in `preserveModules` mode (#5175) by @shulaoda - rolldown_plugin_build_import_analysis: avoid `default` keyword error (#5166) by @shulaoda - watch: add paths to watcher in batch (#5068) by @branchseer - debug: should emit chunk data after computing cross chunk links (#5156) by @hyf0 - simplify commonjs interop `default` prop optimization (#5142) by @IWANABETHATGUY - should include modules contain `exports * from '...'` forcefully if they reexport any wrapped module (#5143) by @hyf0 - use canonical runtime time for `__name` (#5140) by @IWANABETHATGUY - `options.jsx` is ignored when `options.transform` is set (#5137) by @shulaoda ### 🚜 Refactor - polyfill `flatten_iter` for wasm target (#5180) by @IWANABETHATGUY - rolldown_plugin_dynamic_import_vars: remove unnecessary validity checks (#5172) by @shulaoda - hmr: remove hmr-related hacky hard-code (#5168) by @hyf0 - rolldown_plugin_dynamic_import_vars: align with rolldown-vite (#5171) by @shulaoda - hmr: use `rolldown:hmr` to load hmr runtime code (#5162) by @hyf0 - rust: remove special fields of `Asset` (#5155) by @hyf0 - rust: make `Asset#originate_from` optional (#5153) by @hyf0 - rust: isolate mutations on assets data (#5152) by @hyf0 - rust: remove unnecessary usage of index vec on assets (#5151) by @hyf0 - merge different member expr in `try_rewrite_member_expr` (#5146) by @IWANABETHATGUY - remove unused code (#5144) by @IWANABETHATGUY - use `self.result.ast_usage` directly (#5135) by @IWANABETHATGUY ### 📚 Documentation - update syntax lowering transform info (#5145) by @TheAlexLichter ### 🧪 Testing - rust/hmr: hide hmr runtime code in snapshots (#5160) by @hyf0 ### ⚙️ Miscellaneous Tasks - rolldown_testing: avoid unnecessary snapshots (#5181) by @shulaoda - fix `flatten_iter` compile error (#5179) by @IWANABETHATGUY - expose `optimization.inlineConst` option (#5177) by @IWANABETHATGUY - infra: update `pnpm-lock.yaml` (#5178) by @shulaoda - rust: remove unnecessary crate `rolldown_loader_utils` (#5173) by @shulaoda - print build time use green color (#5158) by @btea - deps: update dependency rolldown-plugin-dts to v0.13.13 (#5148) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.13.13 (#5138) by @renovate[bot] - allow only test without generate snapshot (#5134) by @IWANABETHATGUY Co-authored-by: shulaoda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two purposes:
asset.contentduring transformingAssettoOutput. It's not an ideal logic, we want this step to be pure converting option without any mutation.1., the asset data we emitted to devtool are not the final data. This causes some inconsistency, which we don't want this to happen.