Skip to content

Comments

refactor: remove unused code#5144

Merged
IWANABETHATGUY merged 2 commits intomainfrom
07-02-refactor_remove_unused_code
Jul 2, 2025
Merged

refactor: remove unused code#5144
IWANABETHATGUY merged 2 commits intomainfrom
07-02-refactor_remove_unused_code

Conversation

@IWANABETHATGUY
Copy link
Member

No description provided.

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review July 2, 2025 09:08
Copy link
Member Author

IWANABETHATGUY commented Jul 2, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Benchmarks Rust

  • target: main(63f646e)
  • pr: 07-02-refactor_remove_unused_code(f203fd9)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     79.6±2.39ms        ? ?/sec    1.00     78.6±2.55ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     90.2±2.24ms        ? ?/sec    1.00     89.0±2.50ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    116.4±5.24ms        ? ?/sec    1.00    115.2±2.60ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    138.2±3.55ms        ? ?/sec    1.00    135.3±3.08ms        ? ?/sec
bundle/bundle@threejs                                        1.01     42.2±2.46ms        ? ?/sec    1.00     41.9±2.30ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     51.0±1.01ms        ? ?/sec    1.01     51.4±1.11ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    448.7±9.75ms        ? ?/sec    1.00    447.9±6.50ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    517.8±6.75ms        ? ?/sec    1.00    518.7±8.03ms        ? ?/sec
scan/scan@rome_ts                                            1.00     92.4±2.87ms        ? ?/sec    1.01     93.2±2.32ms        ? ?/sec
scan/scan@threejs                                            1.03     32.4±2.08ms        ? ?/sec    1.00     31.5±0.64ms        ? ?/sec
scan/scan@threejs10x                                         1.00    325.9±4.27ms        ? ?/sec    1.01    328.7±4.68ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY marked this pull request as draft July 2, 2025 09:43
@IWANABETHATGUY IWANABETHATGUY force-pushed the 07-02-refactor_remove_unused_code branch from cb434c1 to ceb1ad6 Compare July 2, 2025 09:46
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review July 2, 2025 09:46
Base automatically changed from 07-02-fix_rv-274 to main July 2, 2025 10:02
@IWANABETHATGUY IWANABETHATGUY force-pushed the 07-02-refactor_remove_unused_code branch from ceb1ad6 to f203fd9 Compare July 2, 2025 10:02
@netlify
Copy link

netlify bot commented Jul 2, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit f203fd9
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/686503cc7a74890008880c27

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 2, 2025

Merge activity

  • Jul 2, 10:03 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jul 2, 2025
Merged via the queue into main with commit cc5713c Jul 2, 2025
22 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 07-02-refactor_remove_unused_code branch July 2, 2025 10:16
@github-actions github-actions bot mentioned this pull request Jul 5, 2025
hyf0 pushed a commit that referenced this pull request Jul 5, 2025
## [1.0.0-beta.24] - 2025-07-05

### 🚀 Features

- support `inlineConst` for imported variable (#5165) by @IWANABETHATGUY
- rust: skip transform hook for modules starts with `rolldown:` (#5169)
by @hyf0
- print rolldown version (#5163) by @btea
- add optimization.inlineConst option (#5164) by @IWANABETHATGUY
- hmr: introduce `rolldown_plugin_hmr` to inject runtime code (#5159) by
@hyf0
- rolldown: oxc v0.75.1 (#5157) by @Boshen

### 🐛 Bug Fixes

- generate correct CSS filename in `preserveModules` mode (#5175) by
@shulaoda
- rolldown_plugin_build_import_analysis: avoid `default` keyword error
(#5166) by @shulaoda
- watch: add paths to watcher in batch (#5068) by @branchseer
- debug: should emit chunk data after computing cross chunk links
(#5156) by @hyf0
- simplify commonjs interop `default` prop optimization (#5142) by
@IWANABETHATGUY
- should include modules contain `exports * from '...'` forcefully if
they reexport any wrapped module (#5143) by @hyf0
- use canonical runtime time for `__name` (#5140) by @IWANABETHATGUY
- `options.jsx` is ignored when `options.transform` is set (#5137) by
@shulaoda

### 🚜 Refactor

- polyfill `flatten_iter` for wasm target (#5180) by @IWANABETHATGUY
- rolldown_plugin_dynamic_import_vars: remove unnecessary validity
checks (#5172) by @shulaoda
- hmr: remove hmr-related hacky hard-code (#5168) by @hyf0
- rolldown_plugin_dynamic_import_vars: align with rolldown-vite (#5171)
by @shulaoda
- hmr: use `rolldown:hmr` to load hmr runtime code (#5162) by @hyf0
- rust: remove special fields of `Asset` (#5155) by @hyf0
- rust: make `Asset#originate_from` optional (#5153) by @hyf0
- rust: isolate mutations on assets data (#5152) by @hyf0
- rust: remove unnecessary usage of index vec on assets (#5151) by @hyf0
- merge different member expr in `try_rewrite_member_expr` (#5146) by
@IWANABETHATGUY
- remove unused code (#5144) by @IWANABETHATGUY
- use `self.result.ast_usage` directly (#5135) by @IWANABETHATGUY

### 📚 Documentation

- update syntax lowering transform info (#5145) by @TheAlexLichter

### 🧪 Testing

- rust/hmr: hide hmr runtime code in snapshots (#5160) by @hyf0

### ⚙️ Miscellaneous Tasks

- rolldown_testing: avoid unnecessary snapshots (#5181) by @shulaoda
- fix `flatten_iter` compile error (#5179) by @IWANABETHATGUY
- expose `optimization.inlineConst` option (#5177) by @IWANABETHATGUY
- infra: update `pnpm-lock.yaml` (#5178) by @shulaoda
- rust: remove unnecessary crate `rolldown_loader_utils` (#5173) by
@shulaoda
- print build time use green color (#5158) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5148) by
@renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5138) by
@renovate[bot]
- allow only test without generate snapshot (#5134) by @IWANABETHATGUY

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants