Skip to content

Comments

fix: simplify commonjs interop default prop optimization #5142

Merged
IWANABETHATGUY merged 1 commit intomainfrom
07-02-fix_rv-274
Jul 2, 2025
Merged

fix: simplify commonjs interop default prop optimization #5142
IWANABETHATGUY merged 1 commit intomainfrom
07-02-fix_rv-274

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jul 2, 2025 •
edited
Loading

Closed vitejs/rolldown-vite#274

Since we are already able to analyze the export of commonjs, we could simplify the code related to interop default prop optimization

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jul 2, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jul 2, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 40651ed
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6864ffe746424d000861484a

@IWANABETHATGUY IWANABETHATGUY changed the title fix: rv-274 fix: simplify commonjs interop default prop optimization Jul 2, 2025
@IWANABETHATGUY IWANABETHATGUY force-pushed the 07-02-fix_rv-274 branch 2 times, most recently from 2576596 to 488ba65 Compare July 2, 2025 08:56
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review July 2, 2025 08:59
This was referenced Jul 2, 2025
Closed
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025 •
edited
Loading

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     82.9±2.60ms        ? ?/sec    1.00     82.9±3.00ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.04     89.9±3.44ms        ? ?/sec    1.00     86.7±1.91ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    116.1±3.76ms        ? ?/sec    1.02    118.7±4.36ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.03    139.3±3.93ms        ? ?/sec    1.00    135.1±2.82ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.4±1.32ms        ? ?/sec    1.01     42.8±2.38ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     52.7±1.55ms        ? ?/sec    1.00     52.0±1.32ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    441.7±7.09ms        ? ?/sec    1.00    442.9±6.93ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    514.8±4.69ms        ? ?/sec    1.00    513.8±7.75ms        ? ?/sec
scan/scan@rome_ts                                            1.04     90.8±1.74ms        ? ?/sec    1.00     87.6±1.48ms        ? ?/sec
scan/scan@threejs                                            1.01     30.7±1.88ms        ? ?/sec    1.00     30.5±1.96ms        ? ?/sec
scan/scan@threejs10x                                         1.00    324.1±4.17ms        ? ?/sec    1.00    323.5±7.90ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Jul 2, 2025
Merged
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jul 2, 2025
Merged via the queue into main with commit 63f646e Jul 2, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 07-02-fix_rv-274 branch July 2, 2025 10:02
@github-actions github-actions bot mentioned this pull request Jul 5, 2025
Merged
hyf0 pushed a commit that referenced this pull request Jul 5, 2025
@github-actions @shulaoda
release: v1.0.0-beta.24 (#5182)
2c9c25c 
## [1.0.0-beta.24] - 2025-07-05

### 🚀 Features

- support `inlineConst` for imported variable (#5165) by @IWANABETHATGUY
- rust: skip transform hook for modules starts with `rolldown:` (#5169)
by @hyf0
- print rolldown version (#5163) by @btea
- add optimization.inlineConst option (#5164) by @IWANABETHATGUY
- hmr: introduce `rolldown_plugin_hmr` to inject runtime code (#5159) by
@hyf0
- rolldown: oxc v0.75.1 (#5157) by @Boshen

### 🐛 Bug Fixes

- generate correct CSS filename in `preserveModules` mode (#5175) by
@shulaoda
- rolldown_plugin_build_import_analysis: avoid `default` keyword error
(#5166) by @shulaoda
- watch: add paths to watcher in batch (#5068) by @branchseer
- debug: should emit chunk data after computing cross chunk links
(#5156) by @hyf0
- simplify commonjs interop `default` prop optimization (#5142) by
@IWANABETHATGUY
- should include modules contain `exports * from '...'` forcefully if
they reexport any wrapped module (#5143) by @hyf0
- use canonical runtime time for `__name` (#5140) by @IWANABETHATGUY
- `options.jsx` is ignored when `options.transform` is set (#5137) by
@shulaoda

### 🚜 Refactor

- polyfill `flatten_iter` for wasm target (#5180) by @IWANABETHATGUY
- rolldown_plugin_dynamic_import_vars: remove unnecessary validity
checks (#5172) by @shulaoda
- hmr: remove hmr-related hacky hard-code (#5168) by @hyf0
- rolldown_plugin_dynamic_import_vars: align with rolldown-vite (#5171)
by @shulaoda
- hmr: use `rolldown:hmr` to load hmr runtime code (#5162) by @hyf0
- rust: remove special fields of `Asset` (#5155) by @hyf0
- rust: make `Asset#originate_from` optional (#5153) by @hyf0
- rust: isolate mutations on assets data (#5152) by @hyf0
- rust: remove unnecessary usage of index vec on assets (#5151) by @hyf0
- merge different member expr in `try_rewrite_member_expr` (#5146) by
@IWANABETHATGUY
- remove unused code (#5144) by @IWANABETHATGUY
- use `self.result.ast_usage` directly (#5135) by @IWANABETHATGUY

### 📚 Documentation

- update syntax lowering transform info (#5145) by @TheAlexLichter

### 🧪 Testing

- rust/hmr: hide hmr runtime code in snapshots (#5160) by @hyf0

### ⚙️ Miscellaneous Tasks

- rolldown_testing: avoid unnecessary snapshots (#5181) by @shulaoda
- fix `flatten_iter` compile error (#5179) by @IWANABETHATGUY
- expose `optimization.inlineConst` option (#5177) by @IWANABETHATGUY
- infra: update `pnpm-lock.yaml` (#5178) by @shulaoda
- rust: remove unnecessary crate `rolldown_loader_utils` (#5173) by
@shulaoda
- print build time use green color (#5158) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5148) by
@renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.13 (#5138) by
@renovate[bot]
- allow only test without generate snapshot (#5134) by @IWANABETHATGUY

Co-authored-by: shulaoda <[email protected]>
@shulaoda shulaoda mentioned this pull request Jul 7, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 8, 2025
@shulaoda
chore(rust): remove unused code related to `safe_cjs_to_eliminate_int…
24a8b5b 
…erop_default` (#5202)

`safe_cjs_to_eliminate_interop_default` is no longer used due to the
changes introduced in #5142.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Imported array missing Array.prototype methods

2 participants

@IWANABETHATGUY @hyf0