Skip to content

Comments

refactor(rust): unify outdated namings#5127

Merged
hyf0 merged 1 commit intomainfrom
07-01-refactor_rust_unify_outdated_namings
Jul 1, 2025
Merged

refactor(rust): unify outdated namings#5127
hyf0 merged 1 commit intomainfrom
07-01-refactor_rust_unify_outdated_namings

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jul 1, 2025 •
edited
Loading

I'm trying to improve the clarity of asset-related code. There're too many historical code here.

@hyf0 hyf0 marked this pull request as ready for review July 1, 2025 06:39
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Jul 1, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 mentioned this pull request Jul 1, 2025
Merged
@hyf0 hyf0 force-pushed the 07-01-refactor_rust_unify_outdated_namings branch from 634115b to fd97390 Compare July 1, 2025 06:41
Base automatically changed from 07-01-feat_debug_emit_asset-related_data to main July 1, 2025 06:46
@hyf0 hyf0 force-pushed the 07-01-refactor_rust_unify_outdated_namings branch from fd97390 to e30d491 Compare July 1, 2025 06:46
@netlify
Copy link

netlify bot commented Jul 1, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit e30d491
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6863844734ed3500084bba74

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 1, 2025

Merge activity

  • Jul 1, 6:47 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@hyf0 hyf0 requested a review from shulaoda July 1, 2025 06:48
@hyf0 hyf0 added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit 8688118 Jul 1, 2025
22 checks passed
@hyf0 hyf0 deleted the 07-01-refactor_rust_unify_outdated_namings branch July 1, 2025 06:59
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Benchmarks Rust

  • target: main(7f7651e)
  • pr: 07-01-refactor_rust_unify_outdated_namings(e30d491)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.12     84.3±3.67ms        ? ?/sec    1.00     75.6±1.89ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.13     97.3±3.95ms        ? ?/sec    1.00     86.0±1.87ms        ? ?/sec
bundle/bundle@rome_ts                                        1.09    122.8±4.82ms        ? ?/sec    1.00    112.7±2.63ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.04    140.2±2.44ms        ? ?/sec    1.00    134.9±2.46ms        ? ?/sec
bundle/bundle@threejs                                        1.05     42.9±1.07ms        ? ?/sec    1.00     40.9±2.40ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.03     52.5±2.41ms        ? ?/sec    1.00     50.9±1.07ms        ? ?/sec
bundle/bundle@threejs10x                                     1.05   454.4±10.39ms        ? ?/sec    1.00    433.5±4.24ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.04    524.7±8.71ms        ? ?/sec    1.00    506.2±6.75ms        ? ?/sec
scan/scan@rome_ts                                            1.01     93.2±3.54ms        ? ?/sec    1.00     92.4±2.20ms        ? ?/sec
scan/scan@threejs                                            1.04     32.2±0.61ms        ? ?/sec    1.00     30.8±0.76ms        ? ?/sec
scan/scan@threejs10x                                         1.01    328.9±4.04ms        ? ?/sec    1.00    324.7±4.45ms        ? ?/sec

This was referenced Jul 1, 2025
Closed
Merged
hyf0 pushed a commit that referenced this pull request Jul 1, 2025
@github-actions @shulaoda
release: v1.0.0-beta.23 (#5133)
fbab789 
## [1.0.0-beta.23] - 2025-07-01

### 💥 BREAKING CHANGES

- debug: rename debug logs fields to be consitent (#5125) by @antfu

### 🚀 Features

- debug: append `content` for asset data and unify `source` field to
`content`. (#5130) by @hyf0
- debug: emit asset-related data (#5124) by @hyf0
- commonjs tree shaking. (#5095) by @IWANABETHATGUY
- rolldown_plugin_wasm_helper: align behaviors for expected
functionality (#5120) by @shulaoda
- remove `experimental.enableComposingJsPlugins` (#5122) by @shulaoda
- use same option object reference (#5114) by @sapphi-red
- add util function to inspect why the facade symbol is created (#5115)
by @IWANABETHATGUY
- types: expose `ChunkingContext` type (#5112) by @sapphi-red
- scan commonjs exports (#5111) by @IWANABETHATGUY
- debug: remove unneeded source info of render chunk events (#5109) by
@hyf0
- debug: only emit debug information for trace level (#5108) by @hyf0
- debug: emit chunk related informations (#5106) by @hyf0

### 🐛 Bug Fixes

- debug: add hook render chunk start and end events to Meta enum (#5117)
by @hyf0

### 🚜 Refactor

- rust: unify outdated namings (#5127) by @hyf0

### 📚 Documentation

- advanced-chunks: clarify module capturing behavior (#5129) by @hyf0

### 🧪 Testing

- support array output options (#5113) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- remove unused code (#5128) by @IWANABETHATGUY
- remove unnecessary `skipComposingJsPlugin` (#5123) by @shulaoda
- deps: update crate-ci/typos action to v1.34.0 (#5119) by
@renovate[bot]
- deps: update NAPI-RS to 3.0.0-beta.11 (#5110) by @shulaoda

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shulaoda shulaoda shulaoda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @shulaoda