Skip to content

Comments

chore: remove unnecessary skipComposingJsPlugin#5123

Merged
shulaoda merged 1 commit intomainfrom
07-01-chore_remove_unnecessary_skipcomposingjsplugin
Jul 1, 2025
Merged

chore: remove unnecessary skipComposingJsPlugin#5123
shulaoda merged 1 commit intomainfrom
07-01-chore_remove_unnecessary_skipcomposingjsplugin

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jul 1, 2025

Could you search the codebase with skipComposingJsPlugin and remove them?

Originally posted by @hyf0 in #5122 (review)

Copy link
Member Author

shulaoda commented Jul 1, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda changed the title chore: remove unnecessary skipComposingJsPlugin chore: remove unnecessary skipComposingJsPlugin Jul 1, 2025
@netlify
Copy link

netlify bot commented Jul 1, 2025

Deploy Preview for rolldown-rs failed.

Name Link
🔨 Latest commit f2a8198
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68636d8e7c983000082c3727

@shulaoda shulaoda requested a review from hyf0 July 1, 2025 05:10
@shulaoda shulaoda marked this pull request as ready for review July 1, 2025 05:10
@shulaoda shulaoda added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit 7c1ee27 Jul 1, 2025
19 of 23 checks passed
@shulaoda shulaoda deleted the 07-01-chore_remove_unnecessary_skipcomposingjsplugin branch July 1, 2025 05:23
This was referenced Jul 1, 2025
hyf0 pushed a commit that referenced this pull request Jul 1, 2025
## [1.0.0-beta.23] - 2025-07-01

### 💥 BREAKING CHANGES

- debug: rename debug logs fields to be consitent (#5125) by @antfu

### 🚀 Features

- debug: append `content` for asset data and unify `source` field to
`content`. (#5130) by @hyf0
- debug: emit asset-related data (#5124) by @hyf0
- commonjs tree shaking. (#5095) by @IWANABETHATGUY
- rolldown_plugin_wasm_helper: align behaviors for expected
functionality (#5120) by @shulaoda
- remove `experimental.enableComposingJsPlugins` (#5122) by @shulaoda
- use same option object reference (#5114) by @sapphi-red
- add util function to inspect why the facade symbol is created (#5115)
by @IWANABETHATGUY
- types: expose `ChunkingContext` type (#5112) by @sapphi-red
- scan commonjs exports (#5111) by @IWANABETHATGUY
- debug: remove unneeded source info of render chunk events (#5109) by
@hyf0
- debug: only emit debug information for trace level (#5108) by @hyf0
- debug: emit chunk related informations (#5106) by @hyf0

### 🐛 Bug Fixes

- debug: add hook render chunk start and end events to Meta enum (#5117)
by @hyf0

### 🚜 Refactor

- rust: unify outdated namings (#5127) by @hyf0

### 📚 Documentation

- advanced-chunks: clarify module capturing behavior (#5129) by @hyf0

### 🧪 Testing

- support array output options (#5113) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- remove unused code (#5128) by @IWANABETHATGUY
- remove unnecessary `skipComposingJsPlugin` (#5123) by @shulaoda
- deps: update crate-ci/typos action to v1.34.0 (#5119) by
@renovate[bot]
- deps: update NAPI-RS to 3.0.0-beta.11 (#5110) by @shulaoda

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants