Skip to content

Comments

feat(rolldown_plugin_wasm_helper): align behaviors for expected functionality#5120

Merged
shulaoda merged 1 commit intomainfrom
07-01-feat_rolldown_plugin_wasm_helper_align_behaviors_for_expected_functionality
Jul 1, 2025
Merged

feat(rolldown_plugin_wasm_helper): align behaviors for expected functionality#5120
shulaoda merged 1 commit intomainfrom
07-01-feat_rolldown_plugin_wasm_helper_align_behaviors_for_expected_functionality

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jul 1, 2025 •
edited
Loading

@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Jul 1, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jul 1, 2025

❌ Deploy Preview for rolldown-rs failed.

Name Link
🔨 Latest commit b9aaefb
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68633a9eb14141000803f5eb

@shulaoda shulaoda marked this pull request as ready for review July 1, 2025 01:33
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Benchmarks Rust

  • target: main(2315466)
  • pr: 07-01-feat_rolldown_plugin_wasm_helper_align_behaviors_for_expected_functionality(b9aaefb)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     75.6±2.25ms        ? ?/sec    1.01     76.1±1.39ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     84.3±1.26ms        ? ?/sec    1.03     87.0±1.27ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    113.5±2.29ms        ? ?/sec    1.00    113.8±1.63ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    132.2±2.70ms        ? ?/sec    1.01    133.1±2.50ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.9±1.89ms        ? ?/sec    1.03     41.0±0.80ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     49.7±0.78ms        ? ?/sec    1.02     50.7±0.75ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    432.1±4.68ms        ? ?/sec    1.01    437.2±5.60ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    509.8±7.39ms        ? ?/sec    1.00    506.0±5.30ms        ? ?/sec
scan/scan@rome_ts                                            1.02     88.9±1.31ms        ? ?/sec    1.00     86.9±1.38ms        ? ?/sec
scan/scan@threejs                                            1.04     31.0±1.98ms        ? ?/sec    1.00     29.8±0.36ms        ? ?/sec
scan/scan@threejs10x                                         1.01    323.6±3.88ms        ? ?/sec    1.00    319.6±4.33ms        ? ?/sec

@shulaoda shulaoda mentioned this pull request Jul 1, 2025
Merged
@shulaoda shulaoda added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit 41b5aca Jul 1, 2025
22 of 26 checks passed
@shulaoda shulaoda deleted the 07-01-feat_rolldown_plugin_wasm_helper_align_behaviors_for_expected_functionality branch July 1, 2025 05:09
This was referenced Jul 1, 2025
Closed
Merged
hyf0 pushed a commit that referenced this pull request Jul 1, 2025
@github-actions @shulaoda
release: v1.0.0-beta.23 (#5133)
fbab789 
## [1.0.0-beta.23] - 2025-07-01

### 💥 BREAKING CHANGES

- debug: rename debug logs fields to be consitent (#5125) by @antfu

### 🚀 Features

- debug: append `content` for asset data and unify `source` field to
`content`. (#5130) by @hyf0
- debug: emit asset-related data (#5124) by @hyf0
- commonjs tree shaking. (#5095) by @IWANABETHATGUY
- rolldown_plugin_wasm_helper: align behaviors for expected
functionality (#5120) by @shulaoda
- remove `experimental.enableComposingJsPlugins` (#5122) by @shulaoda
- use same option object reference (#5114) by @sapphi-red
- add util function to inspect why the facade symbol is created (#5115)
by @IWANABETHATGUY
- types: expose `ChunkingContext` type (#5112) by @sapphi-red
- scan commonjs exports (#5111) by @IWANABETHATGUY
- debug: remove unneeded source info of render chunk events (#5109) by
@hyf0
- debug: only emit debug information for trace level (#5108) by @hyf0
- debug: emit chunk related informations (#5106) by @hyf0

### 🐛 Bug Fixes

- debug: add hook render chunk start and end events to Meta enum (#5117)
by @hyf0

### 🚜 Refactor

- rust: unify outdated namings (#5127) by @hyf0

### 📚 Documentation

- advanced-chunks: clarify module capturing behavior (#5129) by @hyf0

### 🧪 Testing

- support array output options (#5113) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- remove unused code (#5128) by @IWANABETHATGUY
- remove unnecessary `skipComposingJsPlugin` (#5123) by @shulaoda
- deps: update crate-ci/typos action to v1.34.0 (#5119) by
@renovate[bot]
- deps: update NAPI-RS to 3.0.0-beta.11 (#5110) by @shulaoda

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shulaoda @IWANABETHATGUY