Skip to content

Comments

feat: add util function to inspect why the facade symbol is created#5115

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-30-feat_add_util_function_to_inspect_why_the_facade_symbol_is_created
Jun 30, 2025
Merged

feat: add util function to inspect why the facade symbol is created#5115
IWANABETHATGUY merged 1 commit intomainfrom
06-30-feat_add_util_function_to_inspect_why_the_facade_symbol_is_created

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 30, 2025 •
edited
Loading

There is no way to know why a facade symbol is created, add this function to make the debugging experience better.

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 30, 2025 10:45
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Jun 30, 2025
Merged
@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jun 30, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Base automatically changed from 06-30-feat_scan_commonjs_exports to main June 30, 2025 10:46
@shulaoda shulaoda force-pushed the 06-30-feat_add_util_function_to_inspect_why_the_facade_symbol_is_created branch from a406cc0 to 1be2360 Compare June 30, 2025 10:54
@netlify
Copy link

netlify bot commented Jun 30, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 6e35dba
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68626e3e0086150008ae4334

@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-30-feat_add_util_function_to_inspect_why_the_facade_symbol_is_created branch from 1be2360 to 6e35dba Compare June 30, 2025 11:00
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit 7196bca Jun 30, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-30-feat_add_util_function_to_inspect_why_the_facade_symbol_is_created branch June 30, 2025 11:13
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025

Benchmarks Rust

  • target: main(4b6f174)
  • pr: 06-30-feat_add_util_function_to_inspect_why_the_facade_symbol_is_created(6e35dba)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     73.6±1.33ms        ? ?/sec    1.00     73.6±1.85ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     84.1±1.12ms        ? ?/sec    1.00     83.7±1.28ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    112.2±2.04ms        ? ?/sec    1.00    111.9±1.58ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    131.2±2.56ms        ? ?/sec    1.00    131.8±1.48ms        ? ?/sec
bundle/bundle@threejs                                        1.01     40.0±1.79ms        ? ?/sec    1.00     39.5±0.86ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     49.6±0.57ms        ? ?/sec    1.00     49.5±0.61ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    429.2±4.34ms        ? ?/sec    1.00    430.6±4.41ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    500.7±3.75ms        ? ?/sec    1.00    500.8±3.53ms        ? ?/sec
scan/scan@rome_ts                                            1.00     86.7±1.31ms        ? ?/sec    1.00     87.0±1.25ms        ? ?/sec
scan/scan@threejs                                            1.00     29.8±0.36ms        ? ?/sec    1.01     30.2±1.83ms        ? ?/sec
scan/scan@threejs10x                                         1.00    316.5±4.64ms        ? ?/sec    1.01    318.2±4.52ms        ? ?/sec

This was referenced Jul 1, 2025
Closed
Merged
hyf0 pushed a commit that referenced this pull request Jul 1, 2025
@github-actions @shulaoda
release: v1.0.0-beta.23 (#5133)
fbab789 
## [1.0.0-beta.23] - 2025-07-01

### 💥 BREAKING CHANGES

- debug: rename debug logs fields to be consitent (#5125) by @antfu

### 🚀 Features

- debug: append `content` for asset data and unify `source` field to
`content`. (#5130) by @hyf0
- debug: emit asset-related data (#5124) by @hyf0
- commonjs tree shaking. (#5095) by @IWANABETHATGUY
- rolldown_plugin_wasm_helper: align behaviors for expected
functionality (#5120) by @shulaoda
- remove `experimental.enableComposingJsPlugins` (#5122) by @shulaoda
- use same option object reference (#5114) by @sapphi-red
- add util function to inspect why the facade symbol is created (#5115)
by @IWANABETHATGUY
- types: expose `ChunkingContext` type (#5112) by @sapphi-red
- scan commonjs exports (#5111) by @IWANABETHATGUY
- debug: remove unneeded source info of render chunk events (#5109) by
@hyf0
- debug: only emit debug information for trace level (#5108) by @hyf0
- debug: emit chunk related informations (#5106) by @hyf0

### 🐛 Bug Fixes

- debug: add hook render chunk start and end events to Meta enum (#5117)
by @hyf0

### 🚜 Refactor

- rust: unify outdated namings (#5127) by @hyf0

### 📚 Documentation

- advanced-chunks: clarify module capturing behavior (#5129) by @hyf0

### 🧪 Testing

- support array output options (#5113) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- remove unused code (#5128) by @IWANABETHATGUY
- remove unnecessary `skipComposingJsPlugin` (#5123) by @shulaoda
- deps: update crate-ci/typos action to v1.34.0 (#5119) by
@renovate[bot]
- deps: update NAPI-RS to 3.0.0-beta.11 (#5110) by @shulaoda

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shulaoda shulaoda shulaoda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @shulaoda