Skip to content

Comments

feat: scan commonjs exports#5111

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-30-feat_scan_commonjs_exports
Jun 30, 2025
Merged

feat: scan commonjs exports#5111
IWANABETHATGUY merged 1 commit intomainfrom
06-30-feat_scan_commonjs_exports

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 30, 2025

No description provided.

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 30, 2025 10:19
@netlify
Copy link

netlify bot commented Jun 30, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit ec28842
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68626728ec7e650008f001c3

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jun 30, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY force-pushed the 06-30-feat_scan_commonjs_exports branch from 1757ab0 to ec28842 Compare June 30, 2025 10:29
@IWANABETHATGUY IWANABETHATGUY requested a review from hyf0 June 30, 2025 10:38
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.03     87.5±3.53ms        ? ?/sec    1.00     84.8±2.38ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     99.5±3.02ms        ? ?/sec    1.00     97.0±3.49ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    120.4±2.97ms        ? ?/sec    1.00    117.6±2.70ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    141.5±2.84ms        ? ?/sec    1.00    141.5±4.88ms        ? ?/sec
bundle/bundle@threejs                                        1.02     43.7±2.80ms        ? ?/sec    1.00     43.0±1.12ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     52.7±2.29ms        ? ?/sec    1.00     52.8±1.18ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    466.3±8.90ms        ? ?/sec    1.00    465.1±9.58ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    533.9±8.05ms        ? ?/sec    1.01    538.0±8.87ms        ? ?/sec
scan/scan@rome_ts                                            1.01     95.1±2.24ms        ? ?/sec    1.00     94.0±2.15ms        ? ?/sec
scan/scan@threejs                                            1.00     32.6±1.77ms        ? ?/sec    1.02     33.1±1.98ms        ? ?/sec
scan/scan@threejs10x                                         1.00    334.6±5.87ms        ? ?/sec    1.01    339.2±7.46ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Jun 30, 2025
Merged
Merged via the queue into main with commit 0c468f8 Jun 30, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-30-feat_scan_commonjs_exports branch June 30, 2025 10:46
This was referenced Jul 1, 2025
Closed
Merged
hyf0 pushed a commit that referenced this pull request Jul 1, 2025
@github-actions @shulaoda
release: v1.0.0-beta.23 (#5133)
fbab789 
## [1.0.0-beta.23] - 2025-07-01

### 💥 BREAKING CHANGES

- debug: rename debug logs fields to be consitent (#5125) by @antfu

### 🚀 Features

- debug: append `content` for asset data and unify `source` field to
`content`. (#5130) by @hyf0
- debug: emit asset-related data (#5124) by @hyf0
- commonjs tree shaking. (#5095) by @IWANABETHATGUY
- rolldown_plugin_wasm_helper: align behaviors for expected
functionality (#5120) by @shulaoda
- remove `experimental.enableComposingJsPlugins` (#5122) by @shulaoda
- use same option object reference (#5114) by @sapphi-red
- add util function to inspect why the facade symbol is created (#5115)
by @IWANABETHATGUY
- types: expose `ChunkingContext` type (#5112) by @sapphi-red
- scan commonjs exports (#5111) by @IWANABETHATGUY
- debug: remove unneeded source info of render chunk events (#5109) by
@hyf0
- debug: only emit debug information for trace level (#5108) by @hyf0
- debug: emit chunk related informations (#5106) by @hyf0

### 🐛 Bug Fixes

- debug: add hook render chunk start and end events to Meta enum (#5117)
by @hyf0

### 🚜 Refactor

- rust: unify outdated namings (#5127) by @hyf0

### 📚 Documentation

- advanced-chunks: clarify module capturing behavior (#5129) by @hyf0

### 🧪 Testing

- support array output options (#5113) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- remove unused code (#5128) by @IWANABETHATGUY
- remove unnecessary `skipComposingJsPlugin` (#5123) by @shulaoda
- deps: update crate-ci/typos action to v1.34.0 (#5119) by
@renovate[bot]
- deps: update NAPI-RS to 3.0.0-beta.11 (#5110) by @shulaoda

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shulaoda shulaoda shulaoda approved these changes

@hyf0 hyf0 Awaiting requested review from hyf0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @shulaoda