Skip to content

Comments

refactor(rolldown_loader_utils): inline unnecessary binary_to_esm#5100

Merged
shulaoda merged 1 commit intomainfrom
06-30-refactor_rolldown_loader_utils_inline_unnecessary_binary_to_esm
Jun 30, 2025
Merged

refactor(rolldown_loader_utils): inline unnecessary binary_to_esm#5100
shulaoda merged 1 commit intomainfrom
06-30-refactor_rolldown_loader_utils_inline_unnecessary_binary_to_esm

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jun 29, 2025

It seems that rolldown_loader_utils doesn't need to be split into a separate crate.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 29, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b87eb7f
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6861679005d5600008862fdd

@shulaoda shulaoda changed the title refactor(rolldown_loader_utils): inline unnecessary binary_to_esm refactor(rolldown_loader_utils): inline unnecessary binary_to_esm Jun 29, 2025
@shulaoda shulaoda marked this pull request as ready for review June 29, 2025 16:21
@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(f6415bb)
  • pr: 06-30-refactor_rolldown_loader_utils_inline_unnecessary_binary_to_esm(b87eb7f)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     75.8±2.00ms        ? ?/sec    1.00     74.9±1.86ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     86.5±1.63ms        ? ?/sec    1.01     87.2±2.41ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    115.1±4.43ms        ? ?/sec    1.00    114.6±2.35ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    135.7±2.42ms        ? ?/sec    1.00    134.6±2.41ms        ? ?/sec
bundle/bundle@threejs                                        1.00     40.8±0.88ms        ? ?/sec    1.02     41.7±1.05ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     50.8±0.86ms        ? ?/sec    1.01     51.1±1.04ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    441.6±6.60ms        ? ?/sec    1.00    438.5±6.55ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    518.8±6.53ms        ? ?/sec    1.00    510.3±5.26ms        ? ?/sec
scan/scan@rome_ts                                            1.02     89.4±1.48ms        ? ?/sec    1.00     87.9±1.68ms        ? ?/sec
scan/scan@threejs                                            1.01     31.3±1.87ms        ? ?/sec    1.00     31.0±1.91ms        ? ?/sec
scan/scan@threejs10x                                         1.01    323.7±4.40ms        ? ?/sec    1.00    319.9±5.47ms        ? ?/sec

@shulaoda shulaoda added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit 68d0391 Jun 30, 2025
27 checks passed
@shulaoda shulaoda deleted the 06-30-refactor_rolldown_loader_utils_inline_unnecessary_binary_to_esm branch June 30, 2025 03:57
Boshen pushed a commit that referenced this pull request Jun 30, 2025
## [1.0.0-beta.22] - 2025-06-30

### 🚀 Features

- plugin: use `Log` instead of `BuildDiagnostic` for `PluginContext#log` (#5099) by @shulaoda
- plugin: support info/warn/debug in native plugin context (#5098) by @shulaoda
- plugin: support vite plugin custom in `PluginContext#resolve` (#5097) by @shulaoda
- rolldown_plugin_import_glob: align edge cases with `rolldown-vite` (#5094) by @shulaoda
- rolldown_plugin_vite_resolve: align subpath import resolution (#5093) by @shulaoda
- add commonjs tree shake option (#5096) by @IWANABETHATGUY
- rolldown_plugin_web_worker_post: align with `rolldown-vite` (#5092) by @shulaoda
- manual-chunks: support `getModuleInfo` (#5087) by @hyf0
- advanced-chunks: support `getModuleInfo` in `groups.{group}.name` (#5086) by @hyf0

### 🚜 Refactor

- rolldown_loader_utils: inline unnecessary `binary_to_esm` (#5100) by @shulaoda

### ⚡ Performance

- hmr: remove `console.debug` in `runtime.registerModule` (#5091) by @sapphi-red
- hmr: remove no-op `runtime.__toCommonJS` call (#5089) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance rust crates (#5105) by @renovate[bot]
- deps: lock file maintenance npm packages (#5104) by @renovate[bot]
- deps: update rust crate schemars to v1 (#5103) by @renovate[bot]
- deps: update dependency vite to v7 (#5102) by @renovate[bot]
- deps: update github-actions (#5101) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5088) by @renovate[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants