Skip to content

Comments

test: add Rollup test#51

Merged
underfin merged 8 commits intomainfrom
rollup-test
Oct 17, 2023
Merged

test: add Rollup test#51
underfin merged 8 commits intomainfrom
rollup-test

Conversation

@underfin
Copy link
Contributor

@underfin underfin commented Oct 12, 2023

Description

close #46.
You can use yarn test:update if run some test success, The packages/rollup-tests/src/failed-tests.json will remove some success tests.

Current test status

┌────────────┬────────┐
│ (index) │ Values │
├────────────┼────────┤
│ total │ 869 │
│ failed │ 0 │
│ skipFailed │ 629 │
│ ignored │ 8 │
│ skipped │ 0 │
│ passed │ 232 │
└────────────┴────────┘

Test Plan


@Boshen
Copy link
Member

Boshen commented Oct 13, 2023

Rollup is a moving target, perhaps we should submodule it instead of adding so many files.

@underfin
Copy link
Contributor Author

underfin commented Oct 13, 2023

I have a try for as rollup as git submodules, here has some problems.

  • rollup test runner(utils.js) and test case depend on the runner(require some method from runner), so I meet crash at run rollup test using custom runner. It means we need port test cases and using custom runner.
  • rollup test runner need a lot of node_modules dependencies, which has some post-install package, eg esbuild/puppeteer,etc.So it look like isn't a clean way if we use it as test runner.

@underfin underfin merged commit b041898 into main Oct 17, 2023
@underfin underfin deleted the rollup-test branch October 17, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup rollup test suite

3 participants