Skip to content

Comments

feat(plugin): use Log instead of BuildDiagnostic for PluginContext#log#5099

Merged
shulaoda merged 1 commit intomainfrom
06-29-feat_plugin_use_log_instead_of_builddiagnostic_for_plugincontext_log
Jun 30, 2025
Merged

feat(plugin): use Log instead of BuildDiagnostic for PluginContext#log#5099
shulaoda merged 1 commit intomainfrom
06-29-feat_plugin_use_log_instead_of_builddiagnostic_for_plugincontext_log

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jun 29, 2025

No description provided.

@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Jun 29, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda mentioned this pull request Jun 29, 2025
Merged
@shulaoda shulaoda marked this pull request as ready for review June 29, 2025 15:13
@shulaoda shulaoda changed the title feat(plugin): use Log instead of BuildDiagnostic for PluginContext#log feat(plugin): use Log instead of BuildDiagnostic for PluginContext#log Jun 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(6534ea1)
  • pr: 06-29-feat_plugin_use_log_instead_of_builddiagnostic_for_plugincontext_log(ab72c51)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     73.7±2.53ms        ? ?/sec    1.00     72.2±1.11ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     83.9±1.17ms        ? ?/sec    1.00     83.5±1.33ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    111.0±1.48ms        ? ?/sec    1.01    111.7±1.35ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    130.6±1.34ms        ? ?/sec    1.00    131.2±1.66ms        ? ?/sec
bundle/bundle@threejs                                        1.01     40.2±1.32ms        ? ?/sec    1.00     39.8±0.64ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     49.8±1.91ms        ? ?/sec    1.00     49.9±1.03ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    431.2±4.22ms        ? ?/sec    1.00    430.7±3.12ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    499.9±2.40ms        ? ?/sec    1.00    500.2±4.65ms        ? ?/sec
scan/scan@rome_ts                                            1.01     88.3±1.50ms        ? ?/sec    1.00     87.2±2.40ms        ? ?/sec
scan/scan@threejs                                            1.00     30.5±0.91ms        ? ?/sec    1.00     30.5±1.82ms        ? ?/sec
scan/scan@threejs10x                                         1.00    319.8±3.80ms        ? ?/sec    1.00    320.9±4.58ms        ? ?/sec

Base automatically changed from 06-29-feat_plugin_support_info_warn_debug_in_native_plugin_context to main June 30, 2025 03:51
@shulaoda shulaoda force-pushed the 06-29-feat_plugin_use_log_instead_of_builddiagnostic_for_plugincontext_log branch from a24ccb3 to ab72c51 Compare June 30, 2025 03:51
@netlify
Copy link

netlify bot commented Jun 30, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit ab72c51
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/686209dd29e083000857dc8c

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 30, 2025

Merge activity

  • Jun 30, 3:52 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@shulaoda shulaoda requested review from IWANABETHATGUY and hyf0 June 30, 2025 04:03
@shulaoda shulaoda added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit 41d1a21 Jun 30, 2025
22 checks passed
@shulaoda shulaoda deleted the 06-29-feat_plugin_use_log_instead_of_builddiagnostic_for_plugincontext_log branch June 30, 2025 05:16
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
Merged
Boshen pushed a commit that referenced this pull request Jun 30, 2025
@github-actions
release: v1.0.0-beta.22 (#5107)
eaf931c 
## [1.0.0-beta.22] - 2025-06-30

### 🚀 Features

- plugin: use `Log` instead of `BuildDiagnostic` for `PluginContext#log` (#5099) by @shulaoda
- plugin: support info/warn/debug in native plugin context (#5098) by @shulaoda
- plugin: support vite plugin custom in `PluginContext#resolve` (#5097) by @shulaoda
- rolldown_plugin_import_glob: align edge cases with `rolldown-vite` (#5094) by @shulaoda
- rolldown_plugin_vite_resolve: align subpath import resolution (#5093) by @shulaoda
- add commonjs tree shake option (#5096) by @IWANABETHATGUY
- rolldown_plugin_web_worker_post: align with `rolldown-vite` (#5092) by @shulaoda
- manual-chunks: support `getModuleInfo` (#5087) by @hyf0
- advanced-chunks: support `getModuleInfo` in `groups.{group}.name` (#5086) by @hyf0

### 🚜 Refactor

- rolldown_loader_utils: inline unnecessary `binary_to_esm` (#5100) by @shulaoda

### ⚡ Performance

- hmr: remove `console.debug` in `runtime.registerModule` (#5091) by @sapphi-red
- hmr: remove no-op `runtime.__toCommonJS` call (#5089) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance rust crates (#5105) by @renovate[bot]
- deps: lock file maintenance npm packages (#5104) by @renovate[bot]
- deps: update rust crate schemars to v1 (#5103) by @renovate[bot]
- deps: update dependency vite to v7 (#5102) by @renovate[bot]
- deps: update github-actions (#5101) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5088) by @renovate[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

@IWANABETHATGUY IWANABETHATGUY Awaiting requested review from IWANABETHATGUY

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shulaoda @hyf0