Skip to content

Comments

feat(plugin): support vite plugin custom in PluginContext#resolve#5097

Merged
shulaoda merged 1 commit intomainfrom
06-29-feat_plugin_support_vite_plugin_custom_in_context_resolve
Jun 29, 2025
Merged

feat(plugin): support vite plugin custom in PluginContext#resolve#5097
shulaoda merged 1 commit intomainfrom
06-29-feat_plugin_support_vite_plugin_custom_in_context_resolve

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jun 29, 2025 •
edited
Loading

Does this work with enableNativePlugins: 'resolver'? Also does this work in dev?

Originally posted by @sapphi-red in #5093 (comment)

@shulaoda shulaoda mentioned this pull request Jun 29, 2025
Merged
@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Jun 29, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda mentioned this pull request Jun 29, 2025
Merged
@shulaoda shulaoda changed the title feat(plugin): support vite plugin custom in context#resolve feat(plugin): support vite plugin custom in context#resolve Jun 29, 2025
@shulaoda shulaoda requested a review from sapphi-red June 29, 2025 09:31
@shulaoda shulaoda marked this pull request as ready for review June 29, 2025 09:31
graphite-app[bot]
graphite-app bot reviewed Jun 29, 2025
View reviewed changes
@shulaoda shulaoda force-pushed the 06-29-feat_plugin_support_vite_plugin_custom_in_context_resolve branch from 2b15b7f to 3e76a4f Compare June 29, 2025 09:36
graphite-app[bot]
graphite-app bot reviewed Jun 29, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(40709e0)
  • pr: 06-29-feat_plugin_support_vite_plugin_custom_in_context_resolve(6a41245)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     77.9±2.06ms        ? ?/sec    1.02     79.7±3.09ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     88.6±1.57ms        ? ?/sec    1.04     92.2±3.22ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    115.2±3.64ms        ? ?/sec    1.00    112.5±1.47ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    135.5±1.65ms        ? ?/sec    1.01    136.3±3.67ms        ? ?/sec
bundle/bundle@threejs                                        1.03     42.2±2.22ms        ? ?/sec    1.00     41.1±0.80ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     50.2±0.75ms        ? ?/sec    1.01     50.7±0.64ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    438.1±6.39ms        ? ?/sec    1.04    453.5±9.59ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.04   524.4±13.29ms        ? ?/sec    1.00    505.9±3.81ms        ? ?/sec
scan/scan@rome_ts                                            1.00     88.6±2.14ms        ? ?/sec    1.00     88.7±1.56ms        ? ?/sec
scan/scan@threejs                                            1.00     30.9±0.41ms        ? ?/sec    1.00     31.0±0.83ms        ? ?/sec
scan/scan@threejs10x                                         1.00    322.3±3.86ms        ? ?/sec    1.01    326.6±6.81ms        ? ?/sec

@shulaoda shulaoda changed the title feat(plugin): support vite plugin custom in context#resolve feat(plugin): support vite plugin custom in PluginContext#resolve Jun 29, 2025
@graphite-app graphite-app bot changed the base branch from 06-28-feat_rolldown_plugin_import_glob_align_edge_cases_with_rolldown-vite to graphite-base/5097 June 29, 2025 16:28
@shulaoda shulaoda force-pushed the graphite-base/5097 branch from 9e8acf2 to 9b63cb5 Compare June 29, 2025 16:49
@shulaoda shulaoda force-pushed the 06-29-feat_plugin_support_vite_plugin_custom_in_context_resolve branch from 3e76a4f to 0e41816 Compare June 29, 2025 16:49
@graphite-app graphite-app bot changed the base branch from graphite-base/5097 to main June 29, 2025 16:49
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 29, 2025 •
edited
Loading

Merge activity

  • Jun 29, 4:49 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Jun 29, 4:50 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@shulaoda shulaoda force-pushed the 06-29-feat_plugin_support_vite_plugin_custom_in_context_resolve branch from 0e41816 to 6a41245 Compare June 29, 2025 17:46
@netlify
Copy link

netlify bot commented Jun 29, 2025

❌ Deploy Preview for rolldown-rs failed.

Name Link
🔨 Latest commit 6a41245
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68617bfe81fcc80008e21a91

@shulaoda shulaoda added this pull request to the merge queue Jun 29, 2025
Merged via the queue into main with commit d6c2e4d Jun 29, 2025
20 of 24 checks passed
@shulaoda shulaoda deleted the 06-29-feat_plugin_support_vite_plugin_custom_in_context_resolve branch June 29, 2025 18:22
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
Merged
Boshen pushed a commit that referenced this pull request Jun 30, 2025
@github-actions
release: v1.0.0-beta.22 (#5107)
eaf931c 
## [1.0.0-beta.22] - 2025-06-30

### 🚀 Features

- plugin: use `Log` instead of `BuildDiagnostic` for `PluginContext#log` (#5099) by @shulaoda
- plugin: support info/warn/debug in native plugin context (#5098) by @shulaoda
- plugin: support vite plugin custom in `PluginContext#resolve` (#5097) by @shulaoda
- rolldown_plugin_import_glob: align edge cases with `rolldown-vite` (#5094) by @shulaoda
- rolldown_plugin_vite_resolve: align subpath import resolution (#5093) by @shulaoda
- add commonjs tree shake option (#5096) by @IWANABETHATGUY
- rolldown_plugin_web_worker_post: align with `rolldown-vite` (#5092) by @shulaoda
- manual-chunks: support `getModuleInfo` (#5087) by @hyf0
- advanced-chunks: support `getModuleInfo` in `groups.{group}.name` (#5086) by @hyf0

### 🚜 Refactor

- rolldown_loader_utils: inline unnecessary `binary_to_esm` (#5100) by @shulaoda

### ⚡ Performance

- hmr: remove `console.debug` in `runtime.registerModule` (#5091) by @sapphi-red
- hmr: remove no-op `runtime.__toCommonJS` call (#5089) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance rust crates (#5105) by @renovate[bot]
- deps: lock file maintenance npm packages (#5104) by @renovate[bot]
- deps: update rust crate schemars to v1 (#5103) by @renovate[bot]
- deps: update dependency vite to v7 (#5102) by @renovate[bot]
- deps: update github-actions (#5101) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5088) by @renovate[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@hyf0 hyf0 hyf0 approved these changes

@sapphi-red sapphi-red Awaiting requested review from sapphi-red

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shulaoda @hyf0