Skip to content

Comments

feat(rolldown_plugin_import_glob): align edge cases with rolldown-vite#5094

Merged
shulaoda merged 1 commit intomainfrom
06-28-feat_rolldown_plugin_import_glob_align_edge_cases_with_rolldown-vite
Jun 29, 2025
Merged

feat(rolldown_plugin_import_glob): align edge cases with rolldown-vite#5094
shulaoda merged 1 commit intomainfrom
06-28-feat_rolldown_plugin_import_glob_align_edge_cases_with_rolldown-vite

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jun 28, 2025 •
edited
Loading

@shulaoda shulaoda mentioned this pull request Jun 28, 2025
Merged
@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Jun 28, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda changed the title feat(rolldown_plugin_import_glob): align edge cases with rolldown-vite feat(rolldown_plugin_import_glob): align edge cases with rolldown-vite Jun 28, 2025
@shulaoda shulaoda marked this pull request as ready for review June 28, 2025 00:56
@shulaoda shulaoda marked this pull request as draft June 28, 2025 00:58
@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(d3afb1e)
  • pr: 06-28-feat_rolldown_plugin_import_glob_align_edge_cases_with_rolldown-vite(6156f4b)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.04     80.2±3.53ms        ? ?/sec    1.00     76.7±2.66ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     87.5±2.16ms        ? ?/sec    1.00     87.8±2.31ms        ? ?/sec
bundle/bundle@rome_ts                                        1.03    118.5±4.42ms        ? ?/sec    1.00    115.4±2.03ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.03    139.5±3.59ms        ? ?/sec    1.00    134.9±2.15ms        ? ?/sec
bundle/bundle@threejs                                        1.01     41.8±2.99ms        ? ?/sec    1.00     41.4±1.06ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     51.2±2.26ms        ? ?/sec    1.01     51.6±1.04ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    445.6±7.81ms        ? ?/sec    1.00    443.6±8.65ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    525.0±8.42ms        ? ?/sec    1.00    519.1±5.53ms        ? ?/sec
scan/scan@rome_ts                                            1.02     90.5±2.08ms        ? ?/sec    1.00     88.4±2.22ms        ? ?/sec
scan/scan@threejs                                            1.04     31.7±2.03ms        ? ?/sec    1.00     30.6±0.60ms        ? ?/sec
scan/scan@threejs10x                                         1.00    323.5±7.40ms        ? ?/sec    1.00    322.0±4.58ms        ? ?/sec

@shulaoda shulaoda force-pushed the 06-28-feat_rolldown_plugin_import_glob_align_edge_cases_with_rolldown-vite branch from 3b0c9e6 to ed2d867 Compare June 28, 2025 01:57
@shulaoda shulaoda marked this pull request as ready for review June 28, 2025 01:57
@shulaoda shulaoda force-pushed the 06-28-feat_rolldown_plugin_import_glob_align_edge_cases_with_rolldown-vite branch from ed2d867 to 9e8acf2 Compare June 28, 2025 02:01
IWANABETHATGUY
IWANABETHATGUY reviewed Jun 28, 2025
View reviewed changes
@shulaoda shulaoda mentioned this pull request Jun 29, 2025
Merged
Base automatically changed from 06-28-feat_rolldown_vite_resolve_align_subpath_import_resolution to main June 29, 2025 16:27
@shulaoda shulaoda force-pushed the 06-28-feat_rolldown_plugin_import_glob_align_edge_cases_with_rolldown-vite branch from 9e8acf2 to 6156f4b Compare June 29, 2025 16:28
@netlify
Copy link

netlify bot commented Jun 29, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 6156f4b
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6861699f0f9c560008b30a4b

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 29, 2025

Merge activity

  • Jun 29, 4:28 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@shulaoda shulaoda added this pull request to the merge queue Jun 29, 2025
Merged via the queue into main with commit 9b63cb5 Jun 29, 2025
23 checks passed
@shulaoda shulaoda deleted the 06-28-feat_rolldown_plugin_import_glob_align_edge_cases_with_rolldown-vite branch June 29, 2025 16:47
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
Merged
Boshen pushed a commit that referenced this pull request Jun 30, 2025
@github-actions
release: v1.0.0-beta.22 (#5107)
eaf931c 
## [1.0.0-beta.22] - 2025-06-30

### 🚀 Features

- plugin: use `Log` instead of `BuildDiagnostic` for `PluginContext#log` (#5099) by @shulaoda
- plugin: support info/warn/debug in native plugin context (#5098) by @shulaoda
- plugin: support vite plugin custom in `PluginContext#resolve` (#5097) by @shulaoda
- rolldown_plugin_import_glob: align edge cases with `rolldown-vite` (#5094) by @shulaoda
- rolldown_plugin_vite_resolve: align subpath import resolution (#5093) by @shulaoda
- add commonjs tree shake option (#5096) by @IWANABETHATGUY
- rolldown_plugin_web_worker_post: align with `rolldown-vite` (#5092) by @shulaoda
- manual-chunks: support `getModuleInfo` (#5087) by @hyf0
- advanced-chunks: support `getModuleInfo` in `groups.{group}.name` (#5086) by @hyf0

### 🚜 Refactor

- rolldown_loader_utils: inline unnecessary `binary_to_esm` (#5100) by @shulaoda

### ⚡ Performance

- hmr: remove `console.debug` in `runtime.registerModule` (#5091) by @sapphi-red
- hmr: remove no-op `runtime.__toCommonJS` call (#5089) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance rust crates (#5105) by @renovate[bot]
- deps: lock file maintenance npm packages (#5104) by @renovate[bot]
- deps: update rust crate schemars to v1 (#5103) by @renovate[bot]
- deps: update dependency vite to v7 (#5102) by @renovate[bot]
- deps: update github-actions (#5101) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5088) by @renovate[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shulaoda @IWANABETHATGUY