Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
❌ Deploy Preview for rolldown-rs failed.
|
shulaoda
changed the title
Contributor
Benchmarks Rust |
Member
|
Does this work with |
Member
Author
Yes, I'm currently working on resolving it. At the moment, it's not yet supported. |
hyf0
approved these changes
Jun 29, 2025
shulaoda
deleted the
06-28-feat_rolldown_vite_resolve_align_subpath_import_resolution
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 29, 2025
…5097) Does this work with `enableNativePlugins: 'resolver'`? Also does this work in dev? _Originally posted by @sapphi-red in #5093 (comment)
Boshen
pushed a commit
that referenced
this pull request
Jun 30, 2025
## [1.0.0-beta.22] - 2025-06-30 ### 🚀 Features - plugin: use `Log` instead of `BuildDiagnostic` for `PluginContext#log` (#5099) by @shulaoda - plugin: support info/warn/debug in native plugin context (#5098) by @shulaoda - plugin: support vite plugin custom in `PluginContext#resolve` (#5097) by @shulaoda - rolldown_plugin_import_glob: align edge cases with `rolldown-vite` (#5094) by @shulaoda - rolldown_plugin_vite_resolve: align subpath import resolution (#5093) by @shulaoda - add commonjs tree shake option (#5096) by @IWANABETHATGUY - rolldown_plugin_web_worker_post: align with `rolldown-vite` (#5092) by @shulaoda - manual-chunks: support `getModuleInfo` (#5087) by @hyf0 - advanced-chunks: support `getModuleInfo` in `groups.{group}.name` (#5086) by @hyf0 ### 🚜 Refactor - rolldown_loader_utils: inline unnecessary `binary_to_esm` (#5100) by @shulaoda ### ⚡ Performance - hmr: remove `console.debug` in `runtime.registerModule` (#5091) by @sapphi-red - hmr: remove no-op `runtime.__toCommonJS` call (#5089) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: lock file maintenance rust crates (#5105) by @renovate[bot] - deps: lock file maintenance npm packages (#5104) by @renovate[bot] - deps: update rust crate schemars to v1 (#5103) by @renovate[bot] - deps: update dependency vite to v7 (#5102) by @renovate[bot] - deps: update github-actions (#5101) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.13.12 (#5088) by @renovate[bot]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although
rolldown-vitealigns partially with the js behavior through the importGlobSubpathImportsResolvePlugin, its logic is not fully consistent. Additionally, thecustomcan only be passed between JS plugins or between native plugins — communication between JS and native plugins is not supported.Therefore, this subpath import resolution logic needs to be moved into the native plugin to ensure correctness and compatibility.