perf(hmr): remove console.debug in runtime.registerModule#5091
Merged
sapphi-red merged 1 commit intomainfrom Jun 27, 2025
Merged
perf(hmr): remove console.debug in runtime.registerModule#5091sapphi-red merged 1 commit intomainfrom
console.debug in runtime.registerModule#5091sapphi-red merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
sapphi-red
force-pushed
the
graphite-base/5091
branch
from
0ba87d7 to
535b36c
Compare
sapphi-red
force-pushed
the
perf/hmr-remove-console-debug-in-register-module
branch
from
bdc04ec to
3c13fe0
Compare
sapphi-red
changed the base branch from
graphite-base/5091
to
perf/hmr-remove-no-op-runtime-to-commonjs-call
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
shulaoda
approved these changes
Jun 27, 2025
Base automatically changed from
perf/hmr-remove-no-op-runtime-to-commonjs-call
to
main
June 27, 2025 12:16
sapphi-red
force-pushed
the
perf/hmr-remove-console-debug-in-register-module
branch
from
3c13fe0 to
ac72ba0
Compare
Contributor
Merge activity
|
Boshen
pushed a commit
that referenced
this pull request
Jun 30, 2025
## [1.0.0-beta.22] - 2025-06-30 ### 🚀 Features - plugin: use `Log` instead of `BuildDiagnostic` for `PluginContext#log` (#5099) by @shulaoda - plugin: support info/warn/debug in native plugin context (#5098) by @shulaoda - plugin: support vite plugin custom in `PluginContext#resolve` (#5097) by @shulaoda - rolldown_plugin_import_glob: align edge cases with `rolldown-vite` (#5094) by @shulaoda - rolldown_plugin_vite_resolve: align subpath import resolution (#5093) by @shulaoda - add commonjs tree shake option (#5096) by @IWANABETHATGUY - rolldown_plugin_web_worker_post: align with `rolldown-vite` (#5092) by @shulaoda - manual-chunks: support `getModuleInfo` (#5087) by @hyf0 - advanced-chunks: support `getModuleInfo` in `groups.{group}.name` (#5086) by @hyf0 ### 🚜 Refactor - rolldown_loader_utils: inline unnecessary `binary_to_esm` (#5100) by @shulaoda ### ⚡ Performance - hmr: remove `console.debug` in `runtime.registerModule` (#5091) by @sapphi-red - hmr: remove no-op `runtime.__toCommonJS` call (#5089) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: lock file maintenance rust crates (#5105) by @renovate[bot] - deps: lock file maintenance npm packages (#5104) by @renovate[bot] - deps: update rust crate schemars to v1 (#5103) by @renovate[bot] - deps: update dependency vite to v7 (#5102) by @renovate[bot] - deps: update github-actions (#5101) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.13.12 (#5088) by @renovate[bot]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtime.registerModuleis a hot path andconsole.debugis slow even if we filter it out in dev tools.