Skip to content

Comments

feat(rolldown): oxc v0.75.0#5069

Merged
Boshen merged 1 commit intomainfrom
06-25-feat_rolldown_oxc_v0.75.0
Jun 25, 2025
Merged

feat(rolldown): oxc v0.75.0#5069
Boshen merged 1 commit intomainfrom
06-25-feat_rolldown_oxc_v0.75.0

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jun 25, 2025

closes #3753

Copy link
Member Author

Boshen commented Jun 25, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for rolldown-rs failed.

Name Link
🔨 Latest commit eea5788
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/685bf35a61cb8200087a3fd1

@socket-security
Copy link

socket-security bot commented Jun 25, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​oxc-project/​types@​0.74.0 ⏵ 0.75.01001007096 +1100
Updated@​oxc-project/​runtime@​0.74.0 ⏵ 0.75.01001007396 +1100
Updatedoxc-transform@​0.74.0 ⏵ 0.75.098 +11008896 +1100
Updatedoxc-parser@​0.74.0 ⏵ 0.75.098 +1100100 +196 +1100

View full report

@Boshen Boshen force-pushed the 06-25-feat_rolldown_oxc_v0.75.0 branch from 90f2af8 to 22914d1 Compare June 25, 2025 13:00
@Boshen Boshen force-pushed the 06-25-feat_rolldown_oxc_v0.75.0 branch from 22914d1 to eea5788 Compare June 25, 2025 13:02
@github-actions
Copy link
Contributor

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     81.1±2.41ms        ? ?/sec    1.01     81.8±2.08ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     92.3±2.11ms        ? ?/sec    1.01     93.5±2.62ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    117.1±3.69ms        ? ?/sec    1.02    119.8±1.89ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    138.3±3.36ms        ? ?/sec    1.01    139.0±2.10ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.8±1.39ms        ? ?/sec    1.01     42.1±2.58ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.03     53.1±0.73ms        ? ?/sec    1.00     51.8±0.89ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00   446.8±10.36ms        ? ?/sec    1.00    445.3±6.13ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    516.3±5.99ms        ? ?/sec    1.00    512.8±6.28ms        ? ?/sec
scan/scan@rome_ts                                            1.00     88.6±1.37ms        ? ?/sec    1.05     93.4±1.66ms        ? ?/sec
scan/scan@threejs                                            1.00     31.5±0.46ms        ? ?/sec    1.05     33.1±1.95ms        ? ?/sec
scan/scan@threejs10x                                         1.00    323.1±4.91ms        ? ?/sec    1.04    335.1±4.68ms        ? ?/sec

@Boshen Boshen added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit cb2ebba Jun 25, 2025
20 of 24 checks passed
@Boshen Boshen deleted the 06-25-feat_rolldown_oxc_v0.75.0 branch June 25, 2025 13:49
Boshen added a commit that referenced this pull request Jun 25, 2025
## [1.0.0-beta.20] - 2025-06-25

### 🚀 Features

- rolldown: oxc v0.75.0 (#5069) by @Boshen
- rolldown: oxc 0.74.0 (#5047) by @Boshen

### 🐛 Bug Fixes

- vite-tests: avoid crash when `packageJson.pnpm` is undefined (#5066)
by @shulaoda
- JSX preset options not working correctly (#5060) by @shulaoda
- remove improper jsdoc of builtin define plugin (#5046) by
@AliceLanniste

### 🚜 Refactor

- passing vec length directly (#5050) by @ShroXd

### 📚 Documentation

- explain that a chunk may be bigger than `maxSize` (#5014) by
@sapphi-red
- update example about `withFilter` (#5040) by @IWANABETHATGUY

### ⚡ Performance

- preallocate smaller vec for hash placeholder finder (#5064) by
@sapphi-red
- reduce temporary memory usage by avoiding output chunk clone until
needed (#5058) by @sapphi-red
- skip empty write bundle hook with `hook_usage` meta (#5057) by
@sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5065) by
@renovate[bot]
- rolldown: upgrade NAPI-RS to 3.0.0-beta.10 (#5063) by @Brooooooklyn
- bump oxc-resolver to v11.2.1 (#5061) by @Boshen
- deps: update dependency tsdown to v0.12.9 (#5056) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5054) by
@renovate[bot]
- remove long-commented-out code (#5048) by @shulaoda
- deps: lock file maintenance npm packages (#5042) by @renovate[bot]
- deps: lock file maintenance rust crates (#5043) by @renovate[bot]
- deps: update taiki-e/install-action action to v2.54.0 (#5045) by
@renovate[bot]
- deps: update taiki-e/install-action action to v2.53.2 (#5041) by
@renovate[bot]

Co-authored-by: Boshen <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jul 30, 2025
Fix what I think is a bug in the scanner.

Prior to #5069 this code was:

```rs
match parent_parent_kind {
    AstKind::MemberExpression(parent_parent) => {
        self.check_assignment_target_property(parent_parent, cursor - 1)
    }
}
```

#5069 [changed
it](https://github.com/rolldown/rolldown/pull/5069/files#diff-75d46c668c6a1268220bfc745c56ee8fbd1652c0ae6fefef4d7fc77725de8462L38-R42)
to:

```rs
match parent_parent_kind {
    parent_parent_kind if parent_parent_kind.is_member_expression_kind() => {
        let parent_parent = kind.as_member_expression_kind().unwrap();
        //                  ^^^^
        self.check_assignment_target_property(&parent_parent, cursor - 1)
    }
}
```

I believe this change introduced a bug - `kind` is the `AstKind` of the
*parent* of `module`, which is `module.exports`. But what we want to
check here is the *grandparent* - to see if it's
`module.exports.__esModule`. Consequently I'd expect that
`module.exports.__esModule = true` is not being correctly identified.

However, I'm not familiar with Rolldown, and this PR change makes no
difference to test results. So could someone else please check my logic?

(came across this while preparing a PR to update to latest Oxc, which
touches the same code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tracking]: Shoud revert skipped tests when oxc support opt-out treeshake.annotation

2 participants