Conversation
❌ Deploy Preview for rolldown-rs failed.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
90f2af8 to
22914d1
Compare
Boshen
commented
Jun 25, 2025
22914d1 to
eea5788
Compare
Contributor
Benchmarks Rust |
hyf0
approved these changes
Jun 25, 2025
Boshen
added a commit
that referenced
this pull request
Jun 25, 2025
## [1.0.0-beta.20] - 2025-06-25 ### 🚀 Features - rolldown: oxc v0.75.0 (#5069) by @Boshen - rolldown: oxc 0.74.0 (#5047) by @Boshen ### 🐛 Bug Fixes - vite-tests: avoid crash when `packageJson.pnpm` is undefined (#5066) by @shulaoda - JSX preset options not working correctly (#5060) by @shulaoda - remove improper jsdoc of builtin define plugin (#5046) by @AliceLanniste ### 🚜 Refactor - passing vec length directly (#5050) by @ShroXd ### 📚 Documentation - explain that a chunk may be bigger than `maxSize` (#5014) by @sapphi-red - update example about `withFilter` (#5040) by @IWANABETHATGUY ### ⚡ Performance - preallocate smaller vec for hash placeholder finder (#5064) by @sapphi-red - reduce temporary memory usage by avoiding output chunk clone until needed (#5058) by @sapphi-red - skip empty write bundle hook with `hook_usage` meta (#5057) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency rolldown-plugin-dts to v0.13.12 (#5065) by @renovate[bot] - rolldown: upgrade NAPI-RS to 3.0.0-beta.10 (#5063) by @Brooooooklyn - bump oxc-resolver to v11.2.1 (#5061) by @Boshen - deps: update dependency tsdown to v0.12.9 (#5056) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.13.12 (#5054) by @renovate[bot] - remove long-commented-out code (#5048) by @shulaoda - deps: lock file maintenance npm packages (#5042) by @renovate[bot] - deps: lock file maintenance rust crates (#5043) by @renovate[bot] - deps: update taiki-e/install-action action to v2.54.0 (#5045) by @renovate[bot] - deps: update taiki-e/install-action action to v2.53.2 (#5041) by @renovate[bot] Co-authored-by: Boshen <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
Fix what I think is a bug in the scanner. Prior to #5069 this code was: ```rs match parent_parent_kind { AstKind::MemberExpression(parent_parent) => { self.check_assignment_target_property(parent_parent, cursor - 1) } } ``` #5069 [changed it](https://github.com/rolldown/rolldown/pull/5069/files#diff-75d46c668c6a1268220bfc745c56ee8fbd1652c0ae6fefef4d7fc77725de8462L38-R42) to: ```rs match parent_parent_kind { parent_parent_kind if parent_parent_kind.is_member_expression_kind() => { let parent_parent = kind.as_member_expression_kind().unwrap(); // ^^^^ self.check_assignment_target_property(&parent_parent, cursor - 1) } } ``` I believe this change introduced a bug - `kind` is the `AstKind` of the *parent* of `module`, which is `module.exports`. But what we want to check here is the *grandparent* - to see if it's `module.exports.__esModule`. Consequently I'd expect that `module.exports.__esModule = true` is not being correctly identified. However, I'm not familiar with Rolldown, and this PR change makes no difference to test results. So could someone else please check my logic? (came across this while preparing a PR to update to latest Oxc, which touches the same code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

closes #3753