Skip to content

Comments

perf: preallocate smaller vec for hash placeholder finder#5064

Merged
Boshen merged 1 commit intomainfrom
06-25-perf_preallocate_smaller_vec_for_hash_placeholder_finder
Jun 25, 2025
Merged

perf: preallocate smaller vec for hash placeholder finder#5064
Boshen merged 1 commit intomainfrom
06-25-perf_preallocate_smaller_vec_for_hash_placeholder_finder

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 25, 2025 •
edited
Loading

Pre-allocate smaller vec as it was pre-allocating too big vec.

@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Jun 25, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 25, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit bd77b02
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/685bcaf63733370008ae70e2

@sapphi-red sapphi-red marked this pull request as ready for review June 25, 2025 10:11
@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

Benchmarks Rust

  • target: main(79b77ec)
  • pr: 06-25-perf_preallocate_smaller_vec_for_hash_placeholder_finder(bd77b02)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.06     81.4±2.24ms        ? ?/sec    1.00     77.1±1.96ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     90.7±2.08ms        ? ?/sec    1.00     89.9±3.10ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    114.5±1.70ms        ? ?/sec    1.00    114.5±1.44ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.05    135.3±1.39ms        ? ?/sec    1.00    129.3±2.51ms        ? ?/sec
bundle/bundle@threejs                                        1.02     42.3±2.22ms        ? ?/sec    1.00     41.6±2.20ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.08     51.3±0.88ms        ? ?/sec    1.00     47.6±0.87ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    443.5±5.66ms        ? ?/sec    1.00    440.7±4.86ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    521.4±6.96ms        ? ?/sec    1.00    513.2±6.11ms        ? ?/sec
scan/scan@rome_ts                                            1.00     93.1±2.12ms        ? ?/sec    1.00     93.0±2.38ms        ? ?/sec
scan/scan@threejs                                            1.02     32.9±2.02ms        ? ?/sec    1.00     32.3±1.99ms        ? ?/sec
scan/scan@threejs10x                                         1.01    336.2±6.96ms        ? ?/sec    1.00    332.2±5.28ms        ? ?/sec

@Boshen Boshen added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit 912e6fc Jun 25, 2025
25 checks passed
@Boshen Boshen deleted the 06-25-perf_preallocate_smaller_vec_for_hash_placeholder_finder branch June 25, 2025 11:02
@github-actions github-actions bot mentioned this pull request Jun 25, 2025
Merged
Boshen added a commit that referenced this pull request Jun 25, 2025
@github-actions @Boshen
release: v1.0.0-beta.20 (#5071)
a99964d 
## [1.0.0-beta.20] - 2025-06-25

### 🚀 Features

- rolldown: oxc v0.75.0 (#5069) by @Boshen
- rolldown: oxc 0.74.0 (#5047) by @Boshen

### 🐛 Bug Fixes

- vite-tests: avoid crash when `packageJson.pnpm` is undefined (#5066)
by @shulaoda
- JSX preset options not working correctly (#5060) by @shulaoda
- remove improper jsdoc of builtin define plugin (#5046) by
@AliceLanniste

### 🚜 Refactor

- passing vec length directly (#5050) by @ShroXd

### 📚 Documentation

- explain that a chunk may be bigger than `maxSize` (#5014) by
@sapphi-red
- update example about `withFilter` (#5040) by @IWANABETHATGUY

### ⚡ Performance

- preallocate smaller vec for hash placeholder finder (#5064) by
@sapphi-red
- reduce temporary memory usage by avoiding output chunk clone until
needed (#5058) by @sapphi-red
- skip empty write bundle hook with `hook_usage` meta (#5057) by
@sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5065) by
@renovate[bot]
- rolldown: upgrade NAPI-RS to 3.0.0-beta.10 (#5063) by @Brooooooklyn
- bump oxc-resolver to v11.2.1 (#5061) by @Boshen
- deps: update dependency tsdown to v0.12.9 (#5056) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5054) by
@renovate[bot]
- remove long-commented-out code (#5048) by @shulaoda
- deps: lock file maintenance npm packages (#5042) by @renovate[bot]
- deps: lock file maintenance rust crates (#5043) by @renovate[bot]
- deps: update taiki-e/install-action action to v2.54.0 (#5045) by
@renovate[bot]
- deps: update taiki-e/install-action action to v2.53.2 (#5041) by
@renovate[bot]

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sapphi-red @hyf0 @Boshen