Skip to content

Comments

fix: JSX preset options not working correctly#5060

Merged
shulaoda merged 1 commit intomainfrom
06-25-fix_jsx_preset_options_not_working_correctly
Jun 25, 2025
Merged

fix: JSX preset options not working correctly#5060
shulaoda merged 1 commit intomainfrom
06-25-fix_jsx_preset_options_not_working_correctly

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jun 25, 2025 •
edited
Loading

closes #5059

Corrected the validity checks in Node-side JSX preset test cases, and removed redundant and ineffective JSX preset tests on the Rust side.

@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Jun 25, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda marked this pull request as ready for review June 25, 2025 07:00
@netlify
Copy link

netlify bot commented Jun 25, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 7560594
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/685ba00e37b77600078bf330
😎 Deploy Preview https://deploy-preview-5060--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shulaoda shulaoda force-pushed the 06-25-fix_jsx_preset_options_not_working_correctly branch from 4805f16 to 7560594 Compare June 25, 2025 07:06
@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

Benchmarks Rust

  • target: main(299e8c0)
  • pr: 06-25-fix_jsx_preset_options_not_working_correctly(7560594)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     85.6±3.12ms        ? ?/sec    1.00     85.6±4.72ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     96.9±3.64ms        ? ?/sec    1.00     95.7±4.25ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    119.0±3.45ms        ? ?/sec    1.00    119.0±2.43ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    134.0±3.57ms        ? ?/sec    1.00    134.7±3.54ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.3±0.98ms        ? ?/sec    1.04     44.0±1.24ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     49.3±1.86ms        ? ?/sec    1.02     50.4±1.29ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    455.5±8.20ms        ? ?/sec    1.00    453.6±7.15ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00   532.5±10.30ms        ? ?/sec    1.00    530.2±6.62ms        ? ?/sec
scan/scan@rome_ts                                            1.00     93.4±3.25ms        ? ?/sec    1.00     93.0±2.00ms        ? ?/sec
scan/scan@threejs                                            1.00     32.6±2.17ms        ? ?/sec    1.00     32.5±0.74ms        ? ?/sec
scan/scan@threejs10x                                         1.00    338.6±6.51ms        ? ?/sec    1.00    339.4±9.18ms        ? ?/sec

@shulaoda shulaoda added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit 84662b4 Jun 25, 2025
23 checks passed
@shulaoda shulaoda deleted the 06-25-fix_jsx_preset_options_not_working_correctly branch June 25, 2025 11:16
@github-actions github-actions bot mentioned this pull request Jun 25, 2025
Merged
Boshen added a commit that referenced this pull request Jun 25, 2025
@github-actions @Boshen
release: v1.0.0-beta.20 (#5071)
a99964d 
## [1.0.0-beta.20] - 2025-06-25

### 🚀 Features

- rolldown: oxc v0.75.0 (#5069) by @Boshen
- rolldown: oxc 0.74.0 (#5047) by @Boshen

### 🐛 Bug Fixes

- vite-tests: avoid crash when `packageJson.pnpm` is undefined (#5066)
by @shulaoda
- JSX preset options not working correctly (#5060) by @shulaoda
- remove improper jsdoc of builtin define plugin (#5046) by
@AliceLanniste

### 🚜 Refactor

- passing vec length directly (#5050) by @ShroXd

### 📚 Documentation

- explain that a chunk may be bigger than `maxSize` (#5014) by
@sapphi-red
- update example about `withFilter` (#5040) by @IWANABETHATGUY

### ⚡ Performance

- preallocate smaller vec for hash placeholder finder (#5064) by
@sapphi-red
- reduce temporary memory usage by avoiding output chunk clone until
needed (#5058) by @sapphi-red
- skip empty write bundle hook with `hook_usage` meta (#5057) by
@sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5065) by
@renovate[bot]
- rolldown: upgrade NAPI-RS to 3.0.0-beta.10 (#5063) by @Brooooooklyn
- bump oxc-resolver to v11.2.1 (#5061) by @Boshen
- deps: update dependency tsdown to v0.12.9 (#5056) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5054) by
@renovate[bot]
- remove long-commented-out code (#5048) by @shulaoda
- deps: lock file maintenance npm packages (#5042) by @renovate[bot]
- deps: lock file maintenance rust crates (#5043) by @renovate[bot]
- deps: update taiki-e/install-action action to v2.54.0 (#5045) by
@renovate[bot]
- deps: update taiki-e/install-action action to v2.53.2 (#5041) by
@renovate[bot]

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Jsx preset option not works

2 participants

@shulaoda @hyf0