Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sapphi-red
changed the base branch from
06-25-perf_skip_empty_write_bundle_hook_with_hook_usage_meta
to
graphite-base/5058
sapphi-red
force-pushed
the
06-25-perf_reduce_temporary_memory_usage_by_avoiding_output_chunk_cloning_until_needed
branch
from
f3ddb46 to
c9c48c2
Compare
sapphi-red
force-pushed
the
graphite-base/5058
branch
from
302e90e to
35d8e15
Compare
sapphi-red
force-pushed
the
06-25-perf_reduce_temporary_memory_usage_by_avoiding_output_chunk_cloning_until_needed
branch
from
c9c48c2 to
a3d4959
Compare
✅ Deploy Preview for rolldown-rs canceled.
|
sapphi-red
changed the title
Contributor
Benchmarks Rust
|
Member
Author
|
Running Vite tests, just in case: https://github.com/rolldown/rolldown/actions/runs/15867992355 Update: Passed ✅ |
shulaoda
approved these changes
Jun 25, 2025
shulaoda
deleted the
06-25-perf_reduce_temporary_memory_usage_by_avoiding_output_chunk_cloning_until_needed
branch
Boshen
added a commit
that referenced
this pull request
Jun 25, 2025
## [1.0.0-beta.20] - 2025-06-25 ### 🚀 Features - rolldown: oxc v0.75.0 (#5069) by @Boshen - rolldown: oxc 0.74.0 (#5047) by @Boshen ### 🐛 Bug Fixes - vite-tests: avoid crash when `packageJson.pnpm` is undefined (#5066) by @shulaoda - JSX preset options not working correctly (#5060) by @shulaoda - remove improper jsdoc of builtin define plugin (#5046) by @AliceLanniste ### 🚜 Refactor - passing vec length directly (#5050) by @ShroXd ### 📚 Documentation - explain that a chunk may be bigger than `maxSize` (#5014) by @sapphi-red - update example about `withFilter` (#5040) by @IWANABETHATGUY ### ⚡ Performance - preallocate smaller vec for hash placeholder finder (#5064) by @sapphi-red - reduce temporary memory usage by avoiding output chunk clone until needed (#5058) by @sapphi-red - skip empty write bundle hook with `hook_usage` meta (#5057) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency rolldown-plugin-dts to v0.13.12 (#5065) by @renovate[bot] - rolldown: upgrade NAPI-RS to 3.0.0-beta.10 (#5063) by @Brooooooklyn - bump oxc-resolver to v11.2.1 (#5061) by @Boshen - deps: update dependency tsdown to v0.12.9 (#5056) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.13.12 (#5054) by @renovate[bot] - remove long-commented-out code (#5048) by @shulaoda - deps: lock file maintenance npm packages (#5042) by @renovate[bot] - deps: lock file maintenance rust crates (#5043) by @renovate[bot] - deps: update taiki-e/install-action action to v2.54.0 (#5045) by @renovate[bot] - deps: update taiki-e/install-action action to v2.53.2 (#5041) by @renovate[bot] Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two lines clones the whole bundle output. This is because
args.bundleisVec<Output>whereOutputis a enum that contains aBox.rolldown/crates/rolldown_binding/src/options/plugin/js_plugin.rs
Line 483 in 35d8e15
rolldown/crates/rolldown_binding/src/options/plugin/js_plugin.rs
Line 510 in 35d8e15
While this
.cloneis inevitable to allow referencing thebundleparameter ofgenerateBundlehook after the hook has end, the content ofbundleparameter does not need to have a separate value, because it is readonly (the modification is done viaChangedOutputsinstead). This PR changesBoxtoArcso that we can share the underlying value.This PR will have a bigger impact if the output is large. For example,
astro buildwith https://github.com/withastro/astro.build used ~8GB of memory previously (if the GC does not run frequently enough). With this PR, it now uses ~3GB.refs #1082