Skip to content

Comments

perf: skip empty write bundle hook with hook_usage meta#5057

Merged
sapphi-red merged 2 commits intomainfrom
06-25-perf_skip_empty_write_bundle_hook_with_hook_usage_meta
Jun 25, 2025
Merged

perf: skip empty write bundle hook with hook_usage meta#5057
sapphi-red merged 2 commits intomainfrom
06-25-perf_skip_empty_write_bundle_hook_with_hook_usage_meta

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 25, 2025

write bundle hook was missing hook_usage meta check. This PR adds that.

refs #4187

Copy link
Member Author

sapphi-red commented Jun 25, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit e62ddcc
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/685b7e34a8a4c90008d3567f

@sapphi-red sapphi-red marked this pull request as ready for review June 25, 2025 04:45
@sapphi-red sapphi-red added this pull request to the merge queue Jun 25, 2025
@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(35d8e15)
  • pr: 06-25-perf_skip_empty_write_bundle_hook_with_hook_usage_meta(e62ddcc)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     74.7±1.79ms        ? ?/sec    1.01     75.7±2.78ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     85.9±1.88ms        ? ?/sec    1.00     84.8±1.58ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    111.8±1.49ms        ? ?/sec    1.00    112.0±1.45ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    127.1±1.95ms        ? ?/sec    1.00    127.3±1.62ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.8±1.29ms        ? ?/sec    1.00     39.9±0.89ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     46.3±0.40ms        ? ?/sec    1.00     46.5±0.41ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    431.7±5.12ms        ? ?/sec    1.01    434.3±6.37ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    504.7±3.33ms        ? ?/sec    1.01    507.6±4.71ms        ? ?/sec
scan/scan@rome_ts                                            1.01     88.4±1.71ms        ? ?/sec    1.00     87.1±1.42ms        ? ?/sec
scan/scan@threejs                                            1.02     31.0±1.85ms        ? ?/sec    1.00     30.3±0.49ms        ? ?/sec
scan/scan@threejs10x                                         1.01    321.6±4.96ms        ? ?/sec    1.00    319.8±7.07ms        ? ?/sec

Merged via the queue into main with commit 1bf31f8 Jun 25, 2025
24 checks passed
@sapphi-red sapphi-red deleted the 06-25-perf_skip_empty_write_bundle_hook_with_hook_usage_meta branch June 25, 2025 05:02
Boshen added a commit that referenced this pull request Jun 25, 2025
## [1.0.0-beta.20] - 2025-06-25

### 🚀 Features

- rolldown: oxc v0.75.0 (#5069) by @Boshen
- rolldown: oxc 0.74.0 (#5047) by @Boshen

### 🐛 Bug Fixes

- vite-tests: avoid crash when `packageJson.pnpm` is undefined (#5066)
by @shulaoda
- JSX preset options not working correctly (#5060) by @shulaoda
- remove improper jsdoc of builtin define plugin (#5046) by
@AliceLanniste

### 🚜 Refactor

- passing vec length directly (#5050) by @ShroXd

### 📚 Documentation

- explain that a chunk may be bigger than `maxSize` (#5014) by
@sapphi-red
- update example about `withFilter` (#5040) by @IWANABETHATGUY

### ⚡ Performance

- preallocate smaller vec for hash placeholder finder (#5064) by
@sapphi-red
- reduce temporary memory usage by avoiding output chunk clone until
needed (#5058) by @sapphi-red
- skip empty write bundle hook with `hook_usage` meta (#5057) by
@sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5065) by
@renovate[bot]
- rolldown: upgrade NAPI-RS to 3.0.0-beta.10 (#5063) by @Brooooooklyn
- bump oxc-resolver to v11.2.1 (#5061) by @Boshen
- deps: update dependency tsdown to v0.12.9 (#5056) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5054) by
@renovate[bot]
- remove long-commented-out code (#5048) by @shulaoda
- deps: lock file maintenance npm packages (#5042) by @renovate[bot]
- deps: lock file maintenance rust crates (#5043) by @renovate[bot]
- deps: update taiki-e/install-action action to v2.54.0 (#5045) by
@renovate[bot]
- deps: update taiki-e/install-action action to v2.53.2 (#5041) by
@renovate[bot]

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants