Skip to content

Comments

chore: remove long-commented-out code#5048

Merged
shulaoda merged 1 commit intomainfrom
06-23-chore_remove_long-commented-out_code
Jun 23, 2025
Merged

chore: remove long-commented-out code#5048
shulaoda merged 1 commit intomainfrom
06-23-chore_remove_long-commented-out_code

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jun 23, 2025

These code blocks have been commented out for over six months to a year and are no longer in use. Removing them helps prevent unnecessary code bloat and keeps the codebase clean.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 23, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b2530bd
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68597d5cd8776c00083ae8e0

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

Benchmarks Rust

  • target: main(d256c6b)
  • pr: 06-23-chore_remove_long-commented-out_code(b2530bd)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     75.8±1.60ms        ? ?/sec    1.03     78.2±3.02ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     88.5±3.60ms        ? ?/sec    1.01     89.5±2.33ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    115.2±3.05ms        ? ?/sec    1.01    116.1±2.89ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    129.5±2.14ms        ? ?/sec    1.02    132.4±2.84ms        ? ?/sec
bundle/bundle@threejs                                        1.02     41.6±1.87ms        ? ?/sec    1.00     40.7±0.71ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     48.1±0.74ms        ? ?/sec    1.00     47.9±0.82ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01   453.8±15.90ms        ? ?/sec    1.00    447.1±6.71ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    525.0±6.25ms        ? ?/sec    1.00    518.5±7.36ms        ? ?/sec
scan/scan@rome_ts                                            1.02     90.7±1.88ms        ? ?/sec    1.00     88.6±2.23ms        ? ?/sec
scan/scan@threejs                                            1.00     31.9±0.83ms        ? ?/sec    1.00     31.9±2.19ms        ? ?/sec
scan/scan@threejs10x                                         1.00    329.3±5.38ms        ? ?/sec    1.00    328.6±6.50ms        ? ?/sec

@shulaoda shulaoda force-pushed the 06-23-chore_remove_long-commented-out_code branch from 8143f20 to b2530bd Compare June 23, 2025 16:14
@shulaoda shulaoda marked this pull request as ready for review June 23, 2025 16:15
@shulaoda shulaoda added this pull request to the merge queue Jun 23, 2025
Merged via the queue into main with commit 3423892 Jun 23, 2025
24 checks passed
@shulaoda shulaoda deleted the 06-23-chore_remove_long-commented-out_code branch June 23, 2025 18:44
Boshen added a commit that referenced this pull request Jun 25, 2025
## [1.0.0-beta.20] - 2025-06-25

### 🚀 Features

- rolldown: oxc v0.75.0 (#5069) by @Boshen
- rolldown: oxc 0.74.0 (#5047) by @Boshen

### 🐛 Bug Fixes

- vite-tests: avoid crash when `packageJson.pnpm` is undefined (#5066)
by @shulaoda
- JSX preset options not working correctly (#5060) by @shulaoda
- remove improper jsdoc of builtin define plugin (#5046) by
@AliceLanniste

### 🚜 Refactor

- passing vec length directly (#5050) by @ShroXd

### 📚 Documentation

- explain that a chunk may be bigger than `maxSize` (#5014) by
@sapphi-red
- update example about `withFilter` (#5040) by @IWANABETHATGUY

### ⚡ Performance

- preallocate smaller vec for hash placeholder finder (#5064) by
@sapphi-red
- reduce temporary memory usage by avoiding output chunk clone until
needed (#5058) by @sapphi-red
- skip empty write bundle hook with `hook_usage` meta (#5057) by
@sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5065) by
@renovate[bot]
- rolldown: upgrade NAPI-RS to 3.0.0-beta.10 (#5063) by @Brooooooklyn
- bump oxc-resolver to v11.2.1 (#5061) by @Boshen
- deps: update dependency tsdown to v0.12.9 (#5056) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.13.12 (#5054) by
@renovate[bot]
- remove long-commented-out code (#5048) by @shulaoda
- deps: lock file maintenance npm packages (#5042) by @renovate[bot]
- deps: lock file maintenance rust crates (#5043) by @renovate[bot]
- deps: update taiki-e/install-action action to v2.54.0 (#5045) by
@renovate[bot]
- deps: update taiki-e/install-action action to v2.53.2 (#5041) by
@renovate[bot]

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants