Skip to content

Comments

feat(advanced-chunks): support advancedChunks#gruop#name to be function#5035

Merged
hyf0 merged 1 commit intomainfrom
06-21-feat_advanced-chunks_support_advancedchunks_gruop_name_to_be_function
Jun 21, 2025
Merged

feat(advanced-chunks): support advancedChunks#gruop#name to be function#5035
hyf0 merged 1 commit intomainfrom
06-21-feat_advanced-chunks_support_advancedchunks_gruop_name_to_be_function

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jun 21, 2025 •
edited
Loading

preparation for #4311. manualChunks will be implemented built on top of this.

@hyf0 hyf0 marked this pull request as ready for review June 21, 2025 10:12
@hyf0 hyf0 mentioned this pull request Jun 21, 2025
Merged
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Jun 21, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(4d93246)
  • pr: 06-21-feat_advanced-chunks_support_advancedchunks_gruop_name_to_be_function(e94c643)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     77.2±3.17ms        ? ?/sec    1.00     76.9±1.99ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     87.1±1.88ms        ? ?/sec    1.00     86.3±1.60ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    112.8±1.79ms        ? ?/sec    1.01    114.1±2.07ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    127.3±2.00ms        ? ?/sec    1.01    129.0±2.77ms        ? ?/sec
bundle/bundle@threejs                                        1.01     40.9±2.50ms        ? ?/sec    1.00     40.4±0.57ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     47.5±0.76ms        ? ?/sec    1.00     47.2±0.61ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    431.9±5.51ms        ? ?/sec    1.01    436.2±6.18ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    501.0±3.23ms        ? ?/sec    1.01    504.8±4.52ms        ? ?/sec
scan/scan@rome_ts                                            1.00     90.2±1.62ms        ? ?/sec    1.01     90.7±1.34ms        ? ?/sec
scan/scan@threejs                                            1.01     31.3±0.52ms        ? ?/sec    1.00     31.0±0.54ms        ? ?/sec
scan/scan@threejs10x                                         1.00    323.7±4.70ms        ? ?/sec    1.01    325.6±4.78ms        ? ?/sec

@hyf0 hyf0 force-pushed the 06-21-feat_advanced-chunks_support_advancedchunks_gruop_name_to_be_function branch from ec402cc to 9925f4f Compare June 21, 2025 10:57
@hyf0 hyf0 mentioned this pull request Jun 21, 2025
Merged
Base automatically changed from 06-21-feat_rust_advanced-chunks_support_matchgroup_name_to_be_dynamic to main June 21, 2025 12:08
@hyf0 hyf0 force-pushed the 06-21-feat_advanced-chunks_support_advancedchunks_gruop_name_to_be_function branch from 9925f4f to 6032296 Compare June 21, 2025 12:09
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 21, 2025

Merge activity

  • Jun 21, 12:10 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@netlify
Copy link

netlify bot commented Jun 21, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit e94c643
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6856a3c3ed2e5d00086b4cb2
😎 Deploy Preview https://deploy-preview-5035--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hyf0 hyf0 force-pushed the 06-21-feat_advanced-chunks_support_advancedchunks_gruop_name_to_be_function branch from 6032296 to e94c643 Compare June 21, 2025 12:21
@hyf0 hyf0 added this pull request to the merge queue Jun 21, 2025
Merged via the queue into main with commit 9eed85e Jun 21, 2025
22 checks passed
@hyf0 hyf0 deleted the 06-21-feat_advanced-chunks_support_advancedchunks_gruop_name_to_be_function branch June 21, 2025 13:51
@github-actions github-actions bot mentioned this pull request Jun 22, 2025
Merged
hyf0 pushed a commit that referenced this pull request Jun 22, 2025
@github-actions @shulaoda
release: v1.0.0-beta.19 (#5038)
8950628 
## [1.0.0-beta.19] - 2025-06-22

### 🚀 Features

- support `OutputOptions#manualChunks` (#5037) by @hyf0
- advanced-chunks: support `advancedChunks#gruop#name` to be function
(#5035) by @hyf0
- rolldown_plugin_import_glob: align with `vitejs/vite#20163` (#5034) by
@shulaoda
- rust/advanced-chunks: support `MatchGroup#name` to be dynamic (#5033)
by @hyf0
- rolldown_plugin_build_import_analysis: align with `vitejs/vite#20117`
(#5027) by @shulaoda
- rolldown_plugin_build_import_analysis: align with `vitejs/vite#20115`
(#5020) by @shulaoda
- add validation warning for advanced chunks options without groups
(#5009) by @sapphi-red

### 🐛 Bug Fixes

- moduleInfo is not updated when entry module is emitted by
this.emitFile (#5032) by @IWANABETHATGUY
- preserveEntrySignatures: false generates circular imports that hangs
with TLA (#5029) by @IWANABETHATGUY
- rolldown_plugin_build_import_analysis: align pure dynamic import
handling with rolldown-vite (#5016) by @shulaoda
- plugin/vite-resolve: normalize leading slash (#5013) by @sapphi-red
- debug: `build_id` doesn't increase (#5015) by @hyf0
- side effects in this.emitFile({ type: 'chunk' }) is removed when
preserveEntrySignatures: false is set (#5012) by @IWANABETHATGUY

### 🚜 Refactor

- rolldown_utils: simplify `block_on_spawn_all` (#5019) by @shulaoda
- use `rolldown_utils::futures::block_on` for `WatcherImpl#start`
(#5018) by @shulaoda

### 📚 Documentation

- jsdoc: document `experimental.attachDebugInfo` (#5028) by @hyf0
- clarify that `advancedChunks` options are in bytes (#5022) by
@sapphi-red
- add a note that sequential conversion may break the code (#5024) by
@sapphi-red

### ⚙️ Miscellaneous Tasks

- infra: clean up `dist` before building `rolldown` (#5036) by @hyf0
- Align status notice in readme with documentation (#5021) by
@rijkvanzanten

### ❤️ New Contributors

* @rijkvanzanten made their first contribution in
[#5021](#5021)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shulaoda shulaoda shulaoda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @shulaoda