Skip to content

Comments

feat(rust/advanced-chunks): support MatchGroup#name to be dynamic#5033

Merged
hyf0 merged 1 commit intomainfrom
06-21-feat_rust_advanced-chunks_support_matchgroup_name_to_be_dynamic
Jun 21, 2025
Merged

feat(rust/advanced-chunks): support MatchGroup#name to be dynamic#5033
hyf0 merged 1 commit intomainfrom
06-21-feat_rust_advanced-chunks_support_matchgroup_name_to_be_dynamic

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jun 21, 2025

preparation for #4311.

@hyf0 hyf0 marked this pull request as ready for review June 21, 2025 08:21
Copy link
Member Author

hyf0 commented Jun 21, 2025

@netlify
Copy link

netlify bot commented Jun 21, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b589b62
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68566b87ca25d40008f06685

@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(1cea807)
  • pr: 06-21-feat_rust_advanced-chunks_support_matchgroup_name_to_be_dynamic(b589b62)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     80.0±3.46ms        ? ?/sec    1.00     78.4±2.70ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     90.1±2.65ms        ? ?/sec    1.00     89.9±2.60ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    116.6±3.19ms        ? ?/sec    1.00    114.9±2.12ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    129.2±2.10ms        ? ?/sec    1.00    129.7±2.49ms        ? ?/sec
bundle/bundle@threejs                                        1.02     42.5±2.65ms        ? ?/sec    1.00     41.6±0.84ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     47.8±1.41ms        ? ?/sec    1.00     47.7±0.70ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    438.4±6.83ms        ? ?/sec    1.01    441.4±6.15ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    510.6±4.88ms        ? ?/sec    1.01    516.8±7.13ms        ? ?/sec
scan/scan@rome_ts                                            1.00     88.7±1.70ms        ? ?/sec    1.04     92.0±1.94ms        ? ?/sec
scan/scan@threejs                                            1.02     32.2±1.77ms        ? ?/sec    1.00     31.6±1.20ms        ? ?/sec
scan/scan@threejs10x                                         1.00    326.8±6.76ms        ? ?/sec    1.00    327.6±6.61ms        ? ?/sec

@hyf0 hyf0 added this pull request to the merge queue Jun 21, 2025
Merged via the queue into main with commit 4d93246 Jun 21, 2025
25 checks passed
@hyf0 hyf0 deleted the 06-21-feat_rust_advanced-chunks_support_matchgroup_name_to_be_dynamic branch June 21, 2025 12:08
hyf0 pushed a commit that referenced this pull request Jun 22, 2025
## [1.0.0-beta.19] - 2025-06-22

### 🚀 Features

- support `OutputOptions#manualChunks` (#5037) by @hyf0
- advanced-chunks: support `advancedChunks#gruop#name` to be function
(#5035) by @hyf0
- rolldown_plugin_import_glob: align with `vitejs/vite#20163` (#5034) by
@shulaoda
- rust/advanced-chunks: support `MatchGroup#name` to be dynamic (#5033)
by @hyf0
- rolldown_plugin_build_import_analysis: align with `vitejs/vite#20117`
(#5027) by @shulaoda
- rolldown_plugin_build_import_analysis: align with `vitejs/vite#20115`
(#5020) by @shulaoda
- add validation warning for advanced chunks options without groups
(#5009) by @sapphi-red

### 🐛 Bug Fixes

- moduleInfo is not updated when entry module is emitted by
this.emitFile (#5032) by @IWANABETHATGUY
- preserveEntrySignatures: false generates circular imports that hangs
with TLA (#5029) by @IWANABETHATGUY
- rolldown_plugin_build_import_analysis: align pure dynamic import
handling with rolldown-vite (#5016) by @shulaoda
- plugin/vite-resolve: normalize leading slash (#5013) by @sapphi-red
- debug: `build_id` doesn't increase (#5015) by @hyf0
- side effects in this.emitFile({ type: 'chunk' }) is removed when
preserveEntrySignatures: false is set (#5012) by @IWANABETHATGUY

### 🚜 Refactor

- rolldown_utils: simplify `block_on_spawn_all` (#5019) by @shulaoda
- use `rolldown_utils::futures::block_on` for `WatcherImpl#start`
(#5018) by @shulaoda

### 📚 Documentation

- jsdoc: document `experimental.attachDebugInfo` (#5028) by @hyf0
- clarify that `advancedChunks` options are in bytes (#5022) by
@sapphi-red
- add a note that sequential conversion may break the code (#5024) by
@sapphi-red

### ⚙️ Miscellaneous Tasks

- infra: clean up `dist` before building `rolldown` (#5036) by @hyf0
- Align status notice in readme with documentation (#5021) by
@rijkvanzanten

### ❤️ New Contributors

* @rijkvanzanten made their first contribution in
[#5021](#5021)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants