Skip to content

Comments

fix: preserveEntrySignatures: false generates circular imports that hangs with TLA#5029

Merged
IWANABETHATGUY merged 1 commit intomainfrom
06-20-fix_5026
Jun 20, 2025
Merged

fix: preserveEntrySignatures: false generates circular imports that hangs with TLA#5029
IWANABETHATGUY merged 1 commit intomainfrom
06-20-fix_5026

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 20, 2025 •
edited
Loading

Closed #5026

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Jun 20, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jun 20, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 119265d
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/685541207ad5a30008b61c14

@IWANABETHATGUY IWANABETHATGUY changed the title fix: 5026 fix: preserveEntrySignatures: false generates circular imports that hangs with TLA Jun 20, 2025
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 20, 2025 09:23
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025 •
edited
Loading

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     76.0±3.11ms        ? ?/sec    1.04     79.1±1.95ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     86.0±2.27ms        ? ?/sec    1.05     89.9±2.12ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    113.5±2.09ms        ? ?/sec    1.03    117.3±1.89ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    128.8±2.08ms        ? ?/sec    1.03    132.5±1.65ms        ? ?/sec
bundle/bundle@threejs                                        1.03     41.9±2.26ms        ? ?/sec    1.00     40.9±2.47ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     47.8±0.99ms        ? ?/sec    1.02     48.7±0.57ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    433.8±4.81ms        ? ?/sec    1.01    439.3±5.37ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    506.0±3.45ms        ? ?/sec    1.00    508.3±7.43ms        ? ?/sec
scan/scan@rome_ts                                            1.01     87.5±1.62ms        ? ?/sec    1.00     87.1±1.28ms        ? ?/sec
scan/scan@threejs                                            1.00     30.6±1.73ms        ? ?/sec    1.02     31.1±1.90ms        ? ?/sec
scan/scan@threejs10x                                         1.01    321.7±6.93ms        ? ?/sec    1.00    319.8±3.89ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jun 20, 2025
Merged via the queue into main with commit 88921eb Jun 20, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 06-20-fix_5026 branch June 20, 2025 11:36
@github-actions github-actions bot mentioned this pull request Jun 22, 2025
Merged
hyf0 pushed a commit that referenced this pull request Jun 22, 2025
@github-actions @shulaoda
release: v1.0.0-beta.19 (#5038)
8950628 
## [1.0.0-beta.19] - 2025-06-22

### 🚀 Features

- support `OutputOptions#manualChunks` (#5037) by @hyf0
- advanced-chunks: support `advancedChunks#gruop#name` to be function
(#5035) by @hyf0
- rolldown_plugin_import_glob: align with `vitejs/vite#20163` (#5034) by
@shulaoda
- rust/advanced-chunks: support `MatchGroup#name` to be dynamic (#5033)
by @hyf0
- rolldown_plugin_build_import_analysis: align with `vitejs/vite#20117`
(#5027) by @shulaoda
- rolldown_plugin_build_import_analysis: align with `vitejs/vite#20115`
(#5020) by @shulaoda
- add validation warning for advanced chunks options without groups
(#5009) by @sapphi-red

### 🐛 Bug Fixes

- moduleInfo is not updated when entry module is emitted by
this.emitFile (#5032) by @IWANABETHATGUY
- preserveEntrySignatures: false generates circular imports that hangs
with TLA (#5029) by @IWANABETHATGUY
- rolldown_plugin_build_import_analysis: align pure dynamic import
handling with rolldown-vite (#5016) by @shulaoda
- plugin/vite-resolve: normalize leading slash (#5013) by @sapphi-red
- debug: `build_id` doesn't increase (#5015) by @hyf0
- side effects in this.emitFile({ type: 'chunk' }) is removed when
preserveEntrySignatures: false is set (#5012) by @IWANABETHATGUY

### 🚜 Refactor

- rolldown_utils: simplify `block_on_spawn_all` (#5019) by @shulaoda
- use `rolldown_utils::futures::block_on` for `WatcherImpl#start`
(#5018) by @shulaoda

### 📚 Documentation

- jsdoc: document `experimental.attachDebugInfo` (#5028) by @hyf0
- clarify that `advancedChunks` options are in bytes (#5022) by
@sapphi-red
- add a note that sequential conversion may break the code (#5024) by
@sapphi-red

### ⚙️ Miscellaneous Tasks

- infra: clean up `dist` before building `rolldown` (#5036) by @hyf0
- Align status notice in readme with documentation (#5021) by
@rijkvanzanten

### ❤️ New Contributors

* @rijkvanzanten made their first contribution in
[#5021](#5021)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: preserveEntrySignatures: false generates circular imports that hangs with TLA

2 participants

@IWANABETHATGUY @hyf0