Skip to content

Comments

fix(rolldown_plugin_build_import_analysis): align pure dynamic import handling with rolldown-vite#5016

Merged
shulaoda merged 1 commit intomainfrom
06-19-fix_rolldown_plugin_build_import_analysis_align_pure_dynamic_import_handling_with_rolldown-vite
Jun 19, 2025
Merged

fix(rolldown_plugin_build_import_analysis): align pure dynamic import handling with rolldown-vite#5016
shulaoda merged 1 commit intomainfrom
06-19-fix_rolldown_plugin_build_import_analysis_align_pure_dynamic_import_handling_with_rolldown-vite

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jun 19, 2025

Copy link
Member Author

@netlify
Copy link

netlify bot commented Jun 19, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 3c81c76
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6854169f9752c500088c0d4c
😎 Deploy Preview https://deploy-preview-5016--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shulaoda shulaoda requested a review from IWANABETHATGUY June 19, 2025 13:57
@shulaoda shulaoda marked this pull request as ready for review June 19, 2025 13:57
@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(92372c2)
  • pr: 06-19-fix_rolldown_plugin_build_import_analysis_align_pure_dynamic_import_handling_with_rolldown-vite(3c81c76)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.14     87.9±4.50ms        ? ?/sec    1.00     77.1±5.41ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.16    103.5±6.88ms        ? ?/sec    1.00     88.9±4.97ms        ? ?/sec
bundle/bundle@rome_ts                                        1.07    122.2±5.35ms        ? ?/sec    1.00    114.5±3.59ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.09    142.9±2.58ms        ? ?/sec    1.00    131.4±4.83ms        ? ?/sec
bundle/bundle@threejs                                        1.12     44.8±2.34ms        ? ?/sec    1.00     39.9±0.44ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.07     50.6±1.60ms        ? ?/sec    1.00     47.1±0.68ms        ? ?/sec
bundle/bundle@threejs10x                                     1.05   456.9±15.20ms        ? ?/sec    1.00    436.0±6.42ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    509.3±3.42ms        ? ?/sec    1.01   516.2±10.41ms        ? ?/sec
scan/scan@rome_ts                                            1.00     86.9±1.55ms        ? ?/sec    1.01     87.5±2.14ms        ? ?/sec
scan/scan@threejs                                            1.00     30.6±1.90ms        ? ?/sec    1.09     33.2±0.81ms        ? ?/sec
scan/scan@threejs10x                                         1.00    319.3±6.42ms        ? ?/sec    1.00    319.9±4.88ms        ? ?/sec

@shulaoda shulaoda added this pull request to the merge queue Jun 19, 2025
Merged via the queue into main with commit f66a7e1 Jun 19, 2025
27 checks passed
@shulaoda shulaoda deleted the 06-19-fix_rolldown_plugin_build_import_analysis_align_pure_dynamic_import_handling_with_rolldown-vite branch June 19, 2025 16:49
hyf0 pushed a commit that referenced this pull request Jun 22, 2025
## [1.0.0-beta.19] - 2025-06-22

### 🚀 Features

- support `OutputOptions#manualChunks` (#5037) by @hyf0
- advanced-chunks: support `advancedChunks#gruop#name` to be function
(#5035) by @hyf0
- rolldown_plugin_import_glob: align with `vitejs/vite#20163` (#5034) by
@shulaoda
- rust/advanced-chunks: support `MatchGroup#name` to be dynamic (#5033)
by @hyf0
- rolldown_plugin_build_import_analysis: align with `vitejs/vite#20117`
(#5027) by @shulaoda
- rolldown_plugin_build_import_analysis: align with `vitejs/vite#20115`
(#5020) by @shulaoda
- add validation warning for advanced chunks options without groups
(#5009) by @sapphi-red

### 🐛 Bug Fixes

- moduleInfo is not updated when entry module is emitted by
this.emitFile (#5032) by @IWANABETHATGUY
- preserveEntrySignatures: false generates circular imports that hangs
with TLA (#5029) by @IWANABETHATGUY
- rolldown_plugin_build_import_analysis: align pure dynamic import
handling with rolldown-vite (#5016) by @shulaoda
- plugin/vite-resolve: normalize leading slash (#5013) by @sapphi-red
- debug: `build_id` doesn't increase (#5015) by @hyf0
- side effects in this.emitFile({ type: 'chunk' }) is removed when
preserveEntrySignatures: false is set (#5012) by @IWANABETHATGUY

### 🚜 Refactor

- rolldown_utils: simplify `block_on_spawn_all` (#5019) by @shulaoda
- use `rolldown_utils::futures::block_on` for `WatcherImpl#start`
(#5018) by @shulaoda

### 📚 Documentation

- jsdoc: document `experimental.attachDebugInfo` (#5028) by @hyf0
- clarify that `advancedChunks` options are in bytes (#5022) by
@sapphi-red
- add a note that sequential conversion may break the code (#5024) by
@sapphi-red

### ⚙️ Miscellaneous Tasks

- infra: clean up `dist` before building `rolldown` (#5036) by @hyf0
- Align status notice in readme with documentation (#5021) by
@rijkvanzanten

### ❤️ New Contributors

* @rijkvanzanten made their first contribution in
[#5021](#5021)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable enableNativePlugin, use vue-router sass does not work.

2 participants